
bobbygill at rogers
Aug 21, 2008, 11:28 AM
Post #19 of 29
(6128 views)
Permalink
|
On Thu, Aug 21, 2008 at 2:16 PM, Ashley Bostock <abostock[at]gmail.com> wrote: > 2008/8/21 Ashley Bostock <abostock[at]gmail.com>: > > 2008/8/21 Brian Sanders <brian.sanders[at]gmail.com>: > >> So I just found this thread, and applied the patch this morning. It did > >> actually fix a few problems, but it seems Transformers is still low > quality > >> compared to the others. Anyone else seen this specific title look any > >> better? > >> > >> On Wed, Aug 20, 2008 at 6:23 PM, Bobby Gill <bobbygill[at]rogers.com> > wrote: > >>> > >>> > >>> On Wed, Aug 20, 2008 at 4:39 PM, Damian <damian[at]gingermagic.co.uk> > wrote: > >>>> > >>>> Bobby Gill wrote: > >>>> > > >>>> > > >>>> > On Wed, Aug 20, 2008 at 7:34 AM, Ashley Bostock <abostock[at]gmail.com > >>>> > <mailto:abostock[at]gmail.com>> wrote: > >>>> > > >>>> > 2008/8/20 Ashley Bostock <abostock[at]gmail.com > >>>> > <mailto:abostock[at]gmail.com>>: > >>>> > > 2008/8/20 Ashley Bostock <abostock[at]gmail.com > >>>> > <mailto:abostock[at]gmail.com>>: > >>>> > >> 2008/8/20 Damian <damian[at]gingermagic.co.uk > >>>> > <mailto:damian[at]gingermagic.co.uk>>: > >>>> > >>> Brian Phillips wrote: > >>>> > >>>> Bobby Gill wrote: > >>>> > >>>>> James, I just glanced at my V poster as well hehe, yeah > it's > >>>> > high-res > >>>> > >>>>> too. > >>>> > >>>>> > >>>> > >>>>> Yes another source would be good, maybe movieposter.com > >>>> > <http://movieposter.com> or something? > >>>> > >>>>> > >>>> > >>>>> Bob > >>>> > >>>> > >>>> > >>>> If I'm not mistaken, the grabber goes to imdb.com > >>>> > <http://imdb.com> and then goes to the > >>>> > >>>> "posters" page. > >>>> > >>>> > >>>> > >>>> Once on that page it looks for URLs for various sites in a > >>>> > "preference" > >>>> > >>>> order. IMDB images are the last grabbed (if the previous > >>>> > URLs > >>>> > time out). > >>>> > >>>> > >>>> > >>>>>From line 277 of my imdb.pl there's a comment: > >>>> > >>>> # look for references to impawards.com > >>>> > <http://impawards.com> posters - they are high quality > >>>> > >>>> > >>>> > >>>> Then if it can't get a poster from that site, it tries > >>>> > "nexbase", then > >>>> > >>>> "cinemablend", then finally imdb.com <http://imdb.com>. > >>>> > >>>> > >>>> > >>>> If all of them fail, it doesn't grab a poster. > >>>> > >>>> > >>>> > >>>> Brian > >>>> > >>> > >>>> > >>> So maybe it's the images on the first search that have > >>>> > changed? > >>>> > Is that > >>>> > >>> impawards.com <http://impawards.com>? > >>>> > >>> > >>>> > >>> Damian > >>>> > >>> _______________________________________________ > >>>> > >>> mythtv-users mailing list > >>>> > >>> mythtv-users[at]mythtv.org <mailto:mythtv-users[at]mythtv.org> > >>>> > >>> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > >>>> > >>> > >>>> > >> > >>>> > >> Looks like imdb have changed their posters page layout. Just > >>>> > edit you > >>>> > >> imdb.pl file (probably located in > >>>> > >> /usr/local/share/mythtv/mythvideo/scripts) and change line > 282 > >>>> > from... > >>>> > >> > >>>> > >> my $impsite = parseBetween($response, "<a href=\"".$site, > >>>> > "\">".$site); > >>>> > >> > >>>> > >> ...to... > >>>> > >> > >>>> > >> my $impsite = parseBetween($response, "<a href=\"".$site, > >>>> > >> "\">\(Theatrical Movie Posters\)"); > >>>> > >> > >>>> > >> > >>>> > >> That should fix the problem. > >>>> > >> Ash > >>>> > >> > >>>> > > > >>>> > > Adding this additional line under 282 is also required for > other > >>>> > movies... > >>>> > > $impsite = parseBetween($response, "<a href=\"".$site, > >>>> > "\">\(Internet > >>>> > > Movie Poster Awards") if ($impsite eq ""); > >>>> > > > >>>> > > ...the above should be all on one line (looks like gmail is > >>>> > splitting > >>>> > > it on to two). > >>>> > > > >>>> > > Ash > >>>> > > > >>>> > > >>>> > Patch (imdb.pl.patchv2) is attached to this ticket... > >>>> > http://svn.mythtv.org/trac/ticket/5633 > >>>> > > >>>> > Ash > >>>> > _______________________________________________ > >>>> > mythtv-users mailing list > >>>> > mythtv-users[at]mythtv.org <mailto:mythtv-users[at]mythtv.org> > >>>> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > >>>> > > >>>> > > >>>> > Fantastic Ashley, it works! Thanks so much! Just had to rm * from > >>>> > ~/.mythtv/MythVideo and redownload 'em, they're coming in nice and > high > >>>> > quality now. > >>>> > > >>>> > Thanks! > >>>> > Bob > >>>> > >>>> I'm very happy that there's a fix so quickly! Thanks! > >>>> > >>>> Out of interest, does anyone know how long it would take for this to > >>>> filter through into the Mythbuntu weekly fixes branch (is the clue in > >>>> the name of the branch??)? If it'll be there in a week or so, then > I'll > >>>> let the updates fix it for me. If not, I'll dive in myself but I'm > >>>> scared to break something or do something that Mythbuntu doesn't > expect. > >>>> Yes, I know I'm sounding like a wussy-geek, but the family is upset > >>>> every time I break Myth of a few days/weeks/months. > >>>> > >>>> Damian > >>>> _______________________________________________ > >>>> mythtv-users mailing list > >>>> mythtv-users[at]mythtv.org > >>>> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > >>> > >>> Damian, > >>> > >>> Upto you, if it's not urgent just hang on until hopefully Ashley's fix > has > >>> been included, otherwise I've uploaded the imdb.pl script right from my > >>> /usr/share/mythtv/mythvideo/scripts if you'd like. If you're on Ubuntu > it > >>> should go into that path or perhaps > >>> /usr/local/share/mythtv/mythvideo/scripts. It's gotta be > >>> "/mythtv/mythvideo/scripts" at end of path either way. Just pop the > script > >>> in there and make sure you clear youre ~/.mythtv/mythvideo/ folder of > any > >>> .jpg's (all previous posters). Then go to the video manager and try > grabbing > >>> the metadata again and check the posters, they should come in right. > >>> > >>> bobgill.net/imdb.tgz > >>> > >>> Bob > >>> > >>> _______________________________________________ > >>> mythtv-users mailing list > >>> mythtv-users[at]mythtv.org > >>> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > >>> > >> > >> > >> > >> -- > >> "Faithless is he, who says 'farewell', when the path darkens > >> "you just keep on trying till you run out of cake" > >> > >> _______________________________________________ > >> mythtv-users mailing list > >> mythtv-users[at]mythtv.org > >> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > >> > >> > > 2008/8/21 Brian Sanders <brian.sanders[at]gmail.com>: > >> So I just found this thread, and applied the patch this morning. It did > >> actually fix a few problems, but it seems Transformers is still low > quality > >> compared to the others. Anyone else seen this specific title look any > >> better? > >> > > > > Blimey they really are inconsistent with the way the poster page links > > are presented. > > Attached is a much better "fixed" version that should work for all > > films that have www.impawards.com linked posters. > > > > I'll update the ticket with an svn diff later today. > > > > Ash > > > > I've updated the patch on the ticket (imdb.pl.patchv4) > http://svn.mythtv.org/trac/ticket/5633 > > I noticed that the impawards site didn't have posters for all my > movies but MoTechPosters did. > So I've added in the grabber code for that website as well :) > > Ash > _______________________________________________ > mythtv-users mailing list > mythtv-users[at]mythtv.org > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-users > Yeah I forgot to take out the +'s, my bad. That's a perfect fix I think Ashley, I just removed about 10 posters that had still been coming in at LQ and are now just mint and high quality. Great stuff, thanks so much! Bob
|