Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Users

[PATCH] Added Recording "Under" Time to enable to start recordings early

 

 

MythTV users RSS feed   Index | Next | Previous | View Threaded


quintesse at palacio-cristal

Jun 27, 2003, 3:27 PM

Post #1 of 20 (2232 views)
Permalink
[PATCH] Added Recording "Under" Time to enable to start recordings early

The setting can be changed in the same screen where you can set the
"Recording Over Time".
I know "Recording Under Time" sounds silly but it _is_ the opposite of
"Recording Over Time" =)
Others can think of a better label, I just wanted to get this patch out
because I needed it at this moment (never trust Dutch programs to start
or end at the designated times!)

While looking at the code to make this patch I _did _ notice that the
conflict handling stuff doesn't seem to take into account the Over Time
setting (and neither does it the Under Time course). Maybe people
normally set Over Time to short values (therefore you set it in seconds
instead of minutes?) but I would probably set Under Time to 5 minutes
and Over Time to at least 10-15 to make sure that minor delays are taken
into account (wouldn't want to miss the ending of the last episode of my
favorite show!). Just letting you know.

Have fun,
-Tako

PS: I know! I should probably send this to the dev list instead ;-)
Attachments: scheduler.diff (0.44 KB)
  globalsettings.diff (0.58 KB)


ijr at po

Jun 27, 2003, 4:05 PM

Post #2 of 20 (2223 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Friday 27 June 2003 06:27 pm, Tako Schotanus wrote:
> The setting can be changed in the same screen where you can set the
> "Recording Over Time".
> I know "Recording Under Time" sounds silly but it _is_ the opposite of
> "Recording Over Time" =)
> Others can think of a better label, I just wanted to get this patch out
> because I needed it at this moment (never trust Dutch programs to start
> or end at the designated times!)

This won't work properly, though you're on the right track.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


quintesse at palacio-cristal

Jun 27, 2003, 4:30 PM

Post #3 of 20 (2228 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

Ok, it seemed to work here. So can you tell me what I should be doing so
I can fix it?

-Tako

Isaac Richards wrote:

>On Friday 27 June 2003 06:27 pm, Tako Schotanus wrote:
>
>
>>The setting can be changed in the same screen where you can set the
>>"Recording Over Time".
>>I know "Recording Under Time" sounds silly but it _is_ the opposite of
>>"Recording Over Time" =)
>>Others can think of a better label, I just wanted to get this patch out
>>because I needed it at this moment (never trust Dutch programs to start
>>or end at the designated times!)
>>
>>
>
>This won't work properly, though you're on the right track.
>
>Isaac
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>


ijr at po

Jun 27, 2003, 4:48 PM

Post #4 of 20 (2228 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Friday 27 June 2003 07:30 pm, Tako Schotanus wrote:
> Ok, it seemed to work here. So can you tell me what I should be doing so
> I can fix it?

If you've got a program to record from 8-9 pm, and one from 9-10 pm, the
second wouldn't get recorded if you had a non-zero under-record time.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


hosting at j2solutions

Jun 27, 2003, 5:16 PM

Post #5 of 20 (2193 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Friday 27 June 2003 16:48, Isaac Richards wrote:
> If you've got a program to record from 8-9 pm, and one from 9-10 pm,
> the second wouldn't get recorded if you had a non-zero under-record
> time.

What about an option for a per-recording buffer of one way or another?
I think XP MCE allows for this, but will alert you if your buffer
infringes on another scheduled recording.

--
Jesse Keating RHCE MCSE
http://geek.j2solutions.net
Mondo DevTeam (http://www.microwerks.net/~hugo/)

Was I helpful? Let others know:
http://svcs.affero.net/rm.php?r=jkeating
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


wd at pobox

Jun 27, 2003, 6:29 PM

Post #6 of 20 (2232 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enabletostart recordings early [In reply to]

At 07:48 PM 6/27/2003 -0400, you wrote:
>On Friday 27 June 2003 07:30 pm, Tako Schotanus wrote:
>> Ok, it seemed to work here. So can you tell me what I should be doing so
>> I can fix it?
>
>If you've got a program to record from 8-9 pm, and one from 9-10 pm, the
>second wouldn't get recorded if you had a non-zero under-record time.


I would think that perhaps the logical thing to do would be to "pre-roll"
as long as there are no other recordings immediately before it. In the
case of two consecutive recordings, it would ignore the pre- or
post-recording and skip directly between the two.

Does that make sense?

-WD
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


lists at forevermore

Jun 27, 2003, 6:37 PM

Post #7 of 20 (2194 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enabletostart recordings early [In reply to]

> I would think that perhaps the logical thing to do would be to "pre-roll"
> as long as there are no other recordings immediately before it. In the
> case of two consecutive recordings, it would ignore the pre- or
> post-recording and skip directly between the two.

there's this, or averaging the two together to find a good midpoint for
start/stop... then again, I'd rather miss the beginning of a show than
the end.

-Chris

_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


joe at thefrys

Jun 27, 2003, 7:46 PM

Post #8 of 20 (2231 views)
Permalink
RE: [PATCH] Added Recording "Under" Time to enableto start recordings early [In reply to]

So now we need to have it detect this conflict and either finish the
recording show or end recording early... maybe a "under time priority"
option. Set to low, it is overridden by current recordings, high, it
overrides.

Good luck,

Joe

> -----Original Message-----
> From: mythtv-users-bounces [at] snowman [mailto:mythtv-users-
> bounces [at] snowman] On Behalf Of Isaac Richards
> Sent: Friday, June 27, 2003 7:49 PM
> To: Discussion about mythtv
> Subject: Re: [mythtv-users] [PATCH] Added Recording "Under" Time to
> enableto start recordings early
>
> On Friday 27 June 2003 07:30 pm, Tako Schotanus wrote:
> > Ok, it seemed to work here. So can you tell me what I should be
doing so
> > I can fix it?
>
> If you've got a program to record from 8-9 pm, and one from 9-10 pm,
the
> second wouldn't get recorded if you had a non-zero under-record time.
>
> Isaac
> _______________________________________________
> mythtv-users mailing list
> mythtv-users [at] snowman
> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users

_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


joe at thefrys

Jun 27, 2003, 7:53 PM

Post #9 of 20 (2227 views)
Permalink
RE: [PATCH] Added Recording "Under" Time toenabletostart recordings early [In reply to]

How about using commercial detection to determine if the show is
actually over. Say a show's scheduled time to end is 9:00, and a
commercial is detected at 8:58, recording ends and the next one starts.
If a commercial is not detected by the time the scheduled end time
elapses and no show is scheduled to start on that tuner, it continues to
record for a few more minutes waiting for one. If there is a show
scheduled to start, it cuts the current show short.

Joe

> -----Original Message-----
> From: mythtv-users-bounces [at] snowman [mailto:mythtv-users-
> bounces [at] snowman] On Behalf Of Chris Petersen
> Sent: Friday, June 27, 2003 9:38 PM
> To: Discussion about mythtv
> Subject: Re: [mythtv-users] [PATCH] Added Recording "Under" Time
> toenabletostart recordings early
>
> > I would think that perhaps the logical thing to do would be to "pre-
> roll"
> > as long as there are no other recordings immediately before it. In
the
> > case of two consecutive recordings, it would ignore the pre- or
> > post-recording and skip directly between the two.
>
> there's this, or averaging the two together to find a good midpoint
for
> start/stop... then again, I'd rather miss the beginning of a show
than
> the end.
>
> -Chris
>
> _______________________________________________
> mythtv-users mailing list
> mythtv-users [at] snowman
> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users

_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


ijr at po

Jun 27, 2003, 8:20 PM

Post #10 of 20 (2239 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Friday 27 June 2003 10:46 pm, Joseph H. Fry wrote:
> So now we need to have it detect this conflict and either finish the
> recording show or end recording early... maybe a "under time priority"
> option. Set to low, it is overridden by current recordings, high, it
> overrides.

I don't see why you'd ever want to cut a recording short, especially if you're
starting even a minute early. It should be just like the over-record setting
-- it only comes into affect only if there's nothing recording at that time.

Basically, all that patch needs is to check if the recorder object is busy
recording before applying the pre-record offset, and then it should work
properly.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


joe at thefrys

Jun 27, 2003, 8:50 PM

Post #11 of 20 (2192 views)
Permalink
RE: [PATCH] Added Recording "Under" Time to enable tostart recordings early [In reply to]

> -----Original Message-----
> From: mythtv-users-bounces [at] snowman [mailto:mythtv-users-
> bounces [at] snowman] On Behalf Of Isaac Richards
> Sent: Friday, June 27, 2003 11:21 PM
> To: Discussion about mythtv
> Subject: Re: [mythtv-users] [PATCH] Added Recording "Under" Time to
enable
> tostart recordings early
>
> On Friday 27 June 2003 10:46 pm, Joseph H. Fry wrote:
> > So now we need to have it detect this conflict and either finish the
> > recording show or end recording early... maybe a "under time
priority"
> > option. Set to low, it is overridden by current recordings, high,
it
> > overrides.
>
> I don't see why you'd ever want to cut a recording short, especially
if
> you're
> starting even a minute early. It should be just like the over-record
> setting
> -- it only comes into affect only if there's nothing recording at that
> time.
>
> Basically, all that patch needs is to check if the recorder object is
busy
> recording before applying the pre-record offset, and then it should
work
> properly.
>
> Isaac
> _______________________________________________
> mythtv-users mailing list
> mythtv-users [at] snowman
> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


What about situations where users experience shows starting early more
often than running until their allotted end time.

For example, where I live I rarely see shows that run past their
scheduled end time, but I frequently see them start early. (my clocks
are synced to world time daily) I think if given the choice, I would
rather record the beginning of the show in my recordings, rather than
the commercials at the end of the previous one.

Maybe the solution is a "show offset" as a positive or negative value...
rarely will a 1/2 hour show run more than 30 minutes... but some places
they start a minute early, some a minute late... how about just a value
to define how different your clocks are than the broadcasters.

So if I set my offset to -1 minute, than all my scheduled times (start
and end) are reduced by 1 minute, if I set it to +1 they are increased
by 1 minute... I think you can see what I mean. Therefore there is no
overlap of recordings.

Hell, this offset could even be set on a per channel basis (of course
this will cause conflicts).

Joe

_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


quintesse at palacio-cristal

Jun 28, 2003, 3:11 AM

Post #12 of 20 (2230 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

Yes, that's because I thought it didn't take Over Time into account
either, but now that I take another look at the code I see that a
recording that is in Over Time can be cancelled if another program needs
to be recorded. So what we need is a way to do the same for Under Time.
Ok, I'll think about how to do this.

NB: You say "the second program wouldn't get recorded", is that true, or
would it just start late? If the former, wouldn't it be better to let
mythtv record whatever is left of the program?

-Tako

Isaac Richards wrote:

>On Friday 27 June 2003 07:30 pm, Tako Schotanus wrote:
>
>
>>Ok, it seemed to work here. So can you tell me what I should be doing so
>>I can fix it?
>>
>>
>
>If you've got a program to record from 8-9 pm, and one from 9-10 pm, the
>second wouldn't get recorded if you had a non-zero under-record time.
>
>Isaac
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>


quintesse at palacio-cristal

Jun 28, 2003, 3:33 AM

Post #13 of 20 (2191 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

Exactly my idea, shouldn't be too hard (I hope ;-)

Isaac Richards wrote:

>On Friday 27 June 2003 10:46 pm, Joseph H. Fry wrote:
>
>
>>So now we need to have it detect this conflict and either finish the
>>recording show or end recording early... maybe a "under time priority"
>>option. Set to low, it is overridden by current recordings, high, it
>>overrides.
>>
>>
>
>I don't see why you'd ever want to cut a recording short, especially if you're
>starting even a minute early. It should be just like the over-record setting
>-- it only comes into affect only if there's nothing recording at that time.
>
>Basically, all that patch needs is to check if the recorder object is busy
>recording before applying the pre-record offset, and then it should work
>properly.
>
>Isaac
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>


quintesse at palacio-cristal

Jun 28, 2003, 3:51 AM

Post #14 of 20 (2207 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable tostart recordings early [In reply to]

How about an extra option like this:

Consider Over Time as important
Under Time
Both Over and Under Time
Neither Over nor Under Time

Although I'm not much of a fan of adding more and more options (I like
to KISS) I can appreciate the need.

I had been thinking of list of scheduled recordings which you could
edit. So let's say you selected a program from the guide, you could
still go into that list and edit whatever you wanted about the program,
including the start and end time. Those times being the "official" times
it would never get cut short. The problem is that I don't know if this
will work, because I can imagine that MythTV does (or could) at times
check if the times in the progam guide have changed so manually editing
the times would just reset them the next time it gets compared against
the program guide.

Up to know I jsut fired up mysql and edited the times manually but it
never worked for some reason (thereby missing the last epidode of my
girlfriend's favorite soap, oops =)

So what sayeth ye, sir Isaac? Any ideas?

Joseph H. Fry wrote:

>
>
>>-----Original Message-----
>>From: mythtv-users-bounces [at] snowman [mailto:mythtv-users-
>>bounces [at] snowman] On Behalf Of Isaac Richards
>>Sent: Friday, June 27, 2003 11:21 PM
>>To: Discussion about mythtv
>>Subject: Re: [mythtv-users] [PATCH] Added Recording "Under" Time to
>>
>>
>enable
>
>
>>tostart recordings early
>>
>>On Friday 27 June 2003 10:46 pm, Joseph H. Fry wrote:
>>
>>
>>>So now we need to have it detect this conflict and either finish the
>>>recording show or end recording early... maybe a "under time
>>>
>>>
>priority"
>
>
>>>option. Set to low, it is overridden by current recordings, high,
>>>
>>>
>it
>
>
>>>overrides.
>>>
>>>
>>I don't see why you'd ever want to cut a recording short, especially
>>
>>
>if
>
>
>>you're
>>starting even a minute early. It should be just like the over-record
>>setting
>>-- it only comes into affect only if there's nothing recording at that
>>time.
>>
>>Basically, all that patch needs is to check if the recorder object is
>>
>>
>busy
>
>
>>recording before applying the pre-record offset, and then it should
>>
>>
>work
>
>
>>properly.
>>
>>Isaac
>>_______________________________________________
>>mythtv-users mailing list
>>mythtv-users [at] snowman
>>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>>
>>
>
>
>What about situations where users experience shows starting early more
>often than running until their allotted end time.
>
>For example, where I live I rarely see shows that run past their
>scheduled end time, but I frequently see them start early. (my clocks
>are synced to world time daily) I think if given the choice, I would
>rather record the beginning of the show in my recordings, rather than
>the commercials at the end of the previous one.
>
>Maybe the solution is a "show offset" as a positive or negative value...
>rarely will a 1/2 hour show run more than 30 minutes... but some places
>they start a minute early, some a minute late... how about just a value
>to define how different your clocks are than the broadcasters.
>
>So if I set my offset to -1 minute, than all my scheduled times (start
>and end) are reduced by 1 minute, if I set it to +1 they are increased
>by 1 minute... I think you can see what I mean. Therefore there is no
>overlap of recordings.
>
>Hell, this offset could even be set on a per channel basis (of course
>this will cause conflicts).
>
>Joe
>
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>


quintesse at palacio-cristal

Jun 28, 2003, 8:14 AM

Post #15 of 20 (2224 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

Ok this is the new patch which looks if the designated card is in use
and won't substract any pre-roll seconds if it is.

NB: The patch is now made from the root of mythtv instead of seperately
for each file.

Cheers,
-Tako


Tako Schotanus wrote:

> Yes, that's because I thought it didn't take Over Time into account
> either, but now that I take another look at the code I see that a
> recording that is in Over Time can be cancelled if another program
> needs to be recorded. So what we need is a way to do the same for
> Under Time. Ok, I'll think about how to do this.
>
> NB: You say "the second program wouldn't get recorded", is that true,
> or would it just start late? If the former, wouldn't it be better to
> let mythtv record whatever is left of the program?
>
> -Tako
>
> Isaac Richards wrote:
>
>>On Friday 27 June 2003 07:30 pm, Tako Schotanus wrote:
>>
>>
>>>Ok, it seemed to work here. So can you tell me what I should be doing so
>>>I can fix it?
>>>
>>>
>>
>>If you've got a program to record from 8-9 pm, and one from 9-10 pm, the
>>second wouldn't get recorded if you had a non-zero under-record time.
>>
>>Isaac
>>_______________________________________________
>>mythtv-users mailing list
>>mythtv-users [at] snowman
>>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>>
>>
>------------------------------------------------------------------------
>
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>
Attachments: preroll.patch (2.62 KB)


ijr at po

Jun 28, 2003, 8:32 AM

Post #16 of 20 (2191 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Saturday 28 June 2003 11:14 am, Tako Schotanus wrote:
> Ok this is the new patch which looks if the designated card is in use
> and won't substract any pre-roll seconds if it is.
>
> NB: The patch is now made from the root of mythtv instead of seperately
> for each file.

Need to 'diff -u' again.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


quintesse at palacio-cristal

Jun 28, 2003, 8:51 AM

Post #17 of 20 (2201 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

Sorry, it seems that "cvs -bu2 diff" is not the same as "cvs diff -bu2".
I'm not yet used to this patch stuff or I would have recognized that the
structure of a -u diff is different.

Hope this will be The One.

Cheers,
-Tako

Isaac Richards wrote:

>On Saturday 28 June 2003 11:14 am, Tako Schotanus wrote:
>
>
>>Ok this is the new patch which looks if the designated card is in use
>>and won't substract any pre-roll seconds if it is.
>>
>>NB: The patch is now made from the root of mythtv instead of seperately
>>for each file.
>>
>>
>
>Need to 'diff -u' again.
>
>Isaac
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>
Attachments: preroll.patch (2.62 KB)


ijr at po

Jun 28, 2003, 6:50 PM

Post #18 of 20 (2200 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Saturday 28 June 2003 11:51 am, Tako Schotanus wrote:
> Sorry, it seems that "cvs -bu2 diff" is not the same as "cvs diff -bu2".
> I'm not yet used to this patch stuff or I would have recognized that the
> structure of a -u diff is different.
>
> Hope this will be The One.

Did you attach the wrong one? It's the exact same as the previous one you
sent.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users


quintesse at palacio-cristal

Jun 29, 2003, 7:31 AM

Post #19 of 20 (2215 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

That's weird, I'll try again. The file I included now is the one with
all those @@ -1068,6 +1086,8 @@ lines which is what you get when you use
the -u options don't you?

If this isn't the one better just shoot me and put me out of my misery

Isaac Richards wrote:

>On Saturday 28 June 2003 11:51 am, Tako Schotanus wrote:
>
>
>>Sorry, it seems that "cvs -bu2 diff" is not the same as "cvs diff -bu2".
>>I'm not yet used to this patch stuff or I would have recognized that the
>>structure of a -u diff is different.
>>
>>Hope this will be The One.
>>
>>
>
>Did you attach the wrong one? It's the exact same as the previous one you
>sent.
>
>Isaac
>_______________________________________________
>mythtv-users mailing list
>mythtv-users [at] snowman
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users
>
>
Attachments: preroll.patch (4.45 KB)


ijr at po

Jun 30, 2003, 8:45 AM

Post #20 of 20 (2214 views)
Permalink
Re: [PATCH] Added Recording "Under" Time to enable to start recordings early [In reply to]

On Sunday 29 June 2003 10:31 am, Tako Schotanus wrote:
> That's weird, I'll try again. The file I included now is the one with
> all those @@ -1068,6 +1086,8 @@ lines which is what you get when you use
> the -u options don't you?

Yes, this is the proper format. I'll get it applied today sometime.

Isaac
_______________________________________________
mythtv-users mailing list
mythtv-users [at] snowman
http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-users

MythTV users RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.