Mailing List Archive: MythTV: Dev

[PATCH] Mac OS X patch 32

Index | Next | Previous | View Threaded

nigel at ind

Sep 7, 2004, 10:50 PM

Post #1 of 5 (1366 views)
Permalink

[PATCH] Mac OS X patch 32

Have abandoned the SWAP_ENDIAN define, added swap_dbl in bswap.h,
added big-endian swapping in NuppelVideoRecorder, and added the
missing yuv2rgb.cpp fixes.

This really should be the last endianness patch. Honest.
(unless it doesn't meet with the committer's approval :-)

cvs diff -u settings.pro libs/libavcodec/bswap.h
libs/libmythtv/NuppelVideoRecorder.* libs/libmythtv/nuppeldecoder.*
libs/libmythtv/yuv2rgb.cpp >../patch.macosx.32

Attachments:

patch.macosx.32 (18.7 KB)

jm at whpress

Sep 8, 2004, 1:44 PM

Post #2 of 5 (1349 views)
Permalink

Re: [PATCH] Mac OS X patch 32 [In reply to]

On 8 Sep 2004, at 1:50 AM, Nigel Pearson wrote:

> Have abandoned the SWAP_ENDIAN define, added swap_dbl in bswap.h,
> added big-endian swapping in NuppelVideoRecorder, and added the
> missing yuv2rgb.cpp fixes.

Thanks, Nigel; the yuv2rgb patch fixed the problems I was having with
the OSD. Everything else checks out, too. Great work!

- Jeremiah

ijr at po

Sep 10, 2004, 11:25 PM

Post #3 of 5 (1317 views)
Permalink

Re: [PATCH] Mac OS X patch 32 [In reply to]

On Wednesday 08 September 2004 01:50 am, Nigel Pearson wrote:
> Have abandoned the SWAP_ENDIAN define, added swap_dbl in bswap.h,
> added big-endian swapping in NuppelVideoRecorder, and added the
> missing yuv2rgb.cpp fixes.
>
> This really should be the last endianness patch. Honest.
> (unless it doesn't meet with the committer's approval :-)

Almost. =)

Just glancing it over, but I think two changes in nuppeldecoder.cpp are
backwards (assigning to foundit, changes at lines 426/447).

Is WriteFrameheader in NVR.cpp being used for anything?

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

nigel at ind

Sep 12, 2004, 9:49 PM

Post #4 of 5 (1314 views)
Permalink

Re: [PATCH] Mac OS X patch 32 [In reply to]

> Just glancing it over, but I think two changes in nuppeldecoder.cpp
> are backwards (assigning to foundit, changes at lines 426/447).

Do'h. Well spotted. That could have been nasty.

> Is WriteFrameheader in NVR.cpp being used for anything?

All over the place, but I must have made _that_ change
in invisible ink :-( ... This time for sure!

cvs diff -u settings.pro libs/libavcodec/bswap.h
libs/libmythtv/NuppelVideoRecorder.* libs/libmythtv/nuppeldecoder.*
libs/libmythtv/yuv2rgb.cpp >../patch.macosx.35

Attachments:

patch.macosx.35 (25.0 KB)

jm at whpress

Oct 15, 2004, 11:21 AM

Post #5 of 5 (1281 views)
Permalink

Re: [PATCH] Mac OS X patch 32 [In reply to]

After much discussion, Nigel had produced OS X patch #35 for fixing
endian issues with Nuppel video. He seemed to have worked out all the
problems that others mentioned, and there's been no response to the
Sept. 12 email. I've been using the patch for a while with great
success. Can this patch get the go-ahead for inclusion into CVS?

Thanks (and sorry to nag),
Jeremiah

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads