Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV

Index | Next | Previous | View Threaded

lvr at softsystem

Jul 24, 2012, 1:28 PM

Post #1 of 5 (360 views)
Permalink

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV

On Tue, 2012-07-24 at 18:33 +0000, MythTV wrote:
> #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV
> ----------------------------------+-----------------------------
> Reporter: kenni | Owner: danielk
> Type: Bug Report - General | Status: new
> Priority: minor | Milestone: unknown
> Component: MythTV - Recording | Version: Master Head
> Severity: medium | Resolution:
> Keywords: | Ticket locked: 0
> ----------------------------------+-----------------------------
>
> Comment (by Daniel Thor Kristjansson <danielk@…>):
>
> In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
> {{{
> #!CommitTicketReference repository="mythtv"
> revision="483e06f6b8a9066f66cef3fcf0a5f844519f51f9"
> Refs #10428. Fix off-by-1000 error in RingBuffer.
>
> The estimated bit rate is in kilobits not bits...

Hooray, at last reason prevails. This was submitted as a bug and patch
in ticket #9824 over 14 months ago. Mark Kendall wriggled and protested
and refused to see this.

Can this be backported to 0.2[45] so that listeners to DVB-S radio can
benefit?

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

stuart at tase

Jul 24, 2012, 1:51 PM

Post #2 of 5 (359 views)
Permalink

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV [In reply to]

On Tuesday 24 Jul 2012 22:28:40 Lawrence Rust wrote:
> > Comment (by Daniel Thor Kristjansson <danielk@…>):
> > In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
> > {{{
> > #!CommitTicketReference repository="mythtv"
> > revision="483e06f6b8a9066f66cef3fcf0a5f844519f51f9"
> > Refs #10428. Fix off-by-1000 error in RingBuffer.
> >
> > The estimated bit rate is in kilobits not bits...
>
> Hooray, at last reason prevails. This was submitted as a bug and patch
> in ticket #9824 over 14 months ago. Mark Kendall wriggled and protested
> and refused to see this.
>
> Can this be backported to 0.2[45] so that listeners to DVB-S radio can
> benefit?

It doesnt' actually seem to help DVB-S radio here, it still stutters and
struggles.

I've yet to test some of the changes in your low bitrate fixes patch.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

danielk at cuymedia

Jul 24, 2012, 5:15 PM

Post #3 of 5 (348 views)
Permalink

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV [In reply to]

On 07/24/2012 04:28 PM, Lawrence Rust wrote:
> On Tue, 2012-07-24 at 18:33 +0000, MythTV wrote:
>> #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV
>> Comment (by Daniel Thor Kristjansson <danielk@…>):
>> In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
>> The estimated bit rate is in kilobits not bits...
>
> Hooray, at last reason prevails. This was submitted as a bug and patch
> in ticket #9824 over 14 months ago. Mark Kendall wriggled and protested
> and refused to see this.
>
> Can this be backported to 0.2[45] so that listeners to DVB-S radio can
> benefit?

It was pretty obviously broken. If this doesn't cause any regressions
I am open to backporting it. I just noticed this when I was looking at
#10658 which should make the ringbuffer a bit more responsive; although
that is still a work in progress.

I just looked at #9824, and Mark's defense there are a lot of things
in that patch and I'm sure if you had submitted a separate patch for
just this he would have applied that pretty quickly.

-- Daniel
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

lvr at softsystem

Jul 25, 2012, 12:02 AM

Post #4 of 5 (346 views)
Permalink

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV [In reply to]

On Tue, 2012-07-24 at 21:51 +0100, Stuart Morgan wrote:
> On Tuesday 24 Jul 2012 22:28:40 Lawrence Rust wrote:
> > > Comment (by Daniel Thor Kristjansson <danielk@…>):
> > > In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
> > > {{{
> > > #!CommitTicketReference repository="mythtv"
> > > revision="483e06f6b8a9066f66cef3fcf0a5f844519f51f9"
> > > Refs #10428. Fix off-by-1000 error in RingBuffer.
> > >
> > > The estimated bit rate is in kilobits not bits...
> >
> > Hooray, at last reason prevails. This was submitted as a bug and patch
> > in ticket #9824 over 14 months ago. Mark Kendall wriggled and protested
> > and refused to see this.
> >
> > Can this be backported to 0.2[45] so that listeners to DVB-S radio can
> > benefit?
>
> It doesnt' actually seem to help DVB-S radio here, it still stutters and
> struggles.

Unfortunately, as you have found this is but part of the solution.

> I've yet to test some of the changes in your low bitrate fixes patch.

The patch for fixes/0.24 makes even the lowest bitrate DVB-S radio quite
listenable. The patch for 0.25/master hasn't had as many hours testing.

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

lvr at softsystem

Jul 25, 2012, 12:29 AM

Post #5 of 5 (343 views)
Permalink

Re: [mythtv-commits] Ticket #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV [In reply to]

On Tue, 2012-07-24 at 20:15 -0400, Daniel Thor Kristjansson wrote:
> On 07/24/2012 04:28 PM, Lawrence Rust wrote:
> > On Tue, 2012-07-24 at 18:33 +0000, MythTV wrote:
> >> #10428: mythbackend logs RingBuf-messages every few seconds while playing LiveTV
> >> Comment (by Daniel Thor Kristjansson <danielk@…>):
> >> In [changeset:483e06f6b8a9066f66cef3fcf0a5f844519f51f9/mythtv]:
> >> The estimated bit rate is in kilobits not bits...
> >
> > Hooray, at last reason prevails. This was submitted as a bug and patch
> > in ticket #9824 over 14 months ago. Mark Kendall wriggled and protested
> > and refused to see this.
> >
> > Can this be backported to 0.2[45] so that listeners to DVB-S radio can
> > benefit?
>
> It was pretty obviously broken. If this doesn't cause any regressions
> I am open to backporting it. I just noticed this when I was looking at
> #10658 which should make the ringbuffer a bit more responsive; although
> that is still a work in progress.

Ticket #9824 also included a change to RingBuffer::WaitForAvail which
effectively implements what is proposed in #10658. I have been using
this patch for over 14 months now with good effect on radio, SD and HDTV
streams played both locally and over 100Mbps Ethernet, 56Mbps WiFi and
200Mbps PowerLAN (20Mbs in practice) links. I haven't seen any problems
with ffmpeg/avformatdecoder.

> I just looked at #9824, and Mark's defense there are a lot of things
> in that patch and I'm sure if you had submitted a separate patch for
> just this he would have applied that pretty quickly.

I see what Mark was getting at - he wanted a series of small patches
that he could easier understand. But some things don't work that way.
To get low bitrate DVB-S radio working needs all of those changes.
Applying a number of the changes on their own would have been
detrimental so that's why I posted the changes 'en masse'

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads