Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692

Index | Next | Previous | View Threaded

gnassas at mac

Jul 20, 2012, 10:50 AM

Post #1 of 11 (597 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692

On 2012-07-20, at 2:57 AM, Git Repo Owner wrote:

> - Log -----------------------------------------------------------------
> commit 6fb8692d2e29f1f8f431442ad41d88b261678bff
> Author: Chris Pinkham <cpinkham [at] mythtv> at Thu, 19 Jul 2012 23:55:28 -0700
> Committer: Chris Pinkham <cpinkham [at] mythtv> at Thu, 19 Jul 2012 23:55:28 -0700
> URL: http://code.mythtv.org/cgit/mythtv/commit/?id=6fb8692d2e29f1f8f431442ad41d88b261678bff
>
> Switch HLS audio encoding back to AAC by default.
> AAC audio seems to work fine everywhere I test except for
> my iPhone 3GS running iOS 4.1, so this may be a bug that
> has been fixed elsewhere. MP3 audio can still be enabled
> if you know what you're doing by looking at the patch/code.

I built and tried this today but I'm still having the same problem at stream create time:

http://files.nassas.com/mythtranscode.20120720163617.10738.log

it's trying to stream that same one minute file I uploaded the other day:

http://files.nassas.com/6021_20120713130343.mpg

did you give at a try during your testing? I'm curious if this is specific to my machine or a real bug. Here's my build log in case you're curious about what's active:

http://files.nassas.com/myth.v0.26-pre-938-g4a04b1f.log

I did break out the debugger but the various thread/process creation kept bouncing me off on tangents and I lost the plot. If you have any tips or pointers for narrowing this down I'm all ears.

- George
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

jyavenard at gmail

Jul 20, 2012, 12:08 PM

Post #2 of 11 (582 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

On 21 July 2012 03:50, George Nassas <gnassas [at] mac> wrote:
> http://files.nassas.com/mythtranscode.20120720163617.10738.log

why are you using libfaac ?

don't enable it..
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

gnassas at mac

Jul 20, 2012, 1:06 PM

Post #3 of 11 (577 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

On 2012-07-20, at 3:08 PM, Jean-Yves Avenard wrote:

> On 21 July 2012 03:50, George Nassas <gnassas [at] mac> wrote:
>> http://files.nassas.com/mythtranscode.20120720163617.10738.log
>
> why are you using libfaac ?
>
> don't enable it..

Well, that got me farther as now transcodes actually run to completion so yay for progress.

I find that the audio has a warbling quality as if the person speaking was gargling while talking. Same for music, there's a warble underneath. I'm pressed for time so I'll have to figure out how to revert to mp3 audio later and try that.

I ask again: has either you or Chris tried streaming the sample video I uploaded? It's what I imagine is a typical broadcast from one of the US majors so pretty likely the sort of thing to be streamed by other people.

Also, how did you know about libfaac being problematic? I didn't see anything about that in the commits or maybe I missed it. I enable everything I can in the hope that it will bring me the most number of available features and depend on configure to warn me about conflicts.

In case it's not obvious I'm grateful for the debugging efforts and also for making streaming available even though it might not be 100% perfect in all cases.

- George

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

gnassas at mac

Jul 20, 2012, 1:21 PM

Post #4 of 11 (578 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

On 2012-07-20, at 4:06 PM, George Nassas wrote:

> I find that the audio has a warbling quality as if the person speaking was gargling while talking. Same for music, there's a warble underneath.

Whoop, forgot to write that I can cure the warbling by jumping back maybe 5 seconds in the video. Like the previous problem with clipped sound, moving around the stream seems to make it go away. I haven't played a long enough stream to know if the warble will come back later.

And, a final question for Chris: do you want these running bug reports? With the release near I'm not sure if you're shooting for good enough or perfect in all cases. Should mp3 audio turn out to be usable then that's good enough for me until you have time and inclination to poke at this some more.

- George

cpinkham at bc2va

Jul 20, 2012, 2:30 PM

Post #5 of 11 (574 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

* On Fri Jul 20, 2012 at 01:50:11PM -0400 (and 2 other times), George Nassas wrote:

I'm merging 3 emails here together to reply to them all at once..

> http://files.nassas.com/6021_20120713130343.mpg
>
> did you give at a try during your testing? I'm curious if this is specific
> to my machine or a real bug.

I did use your test file. I can play it fine using AAC or MP3 audio
on my iPhone 4 running iOS 5.1.1, but not on my 3GS running iOS 4.1.
The same holds true for other samples I've tried. If I enable MP3
audio for HLS, I can play both your sample and mine correctly on my
iPhone 3GS. I'm not sure if this is a hardware, decoder, or encoder
issue, but am looking into it. For now, you can create a setting
called HLSAACAUDIO set to '0' to disable AAC and use MP3 audio in HLS.

It's not your setup specifically, but I would like to know what you're
using to test, is this iOS, Android, or what?

> ========

> Also, how did you know about libfaac being problematic? I didn't see
> anything about that in the commits or maybe I missed it. I enable
> everything I can in the hope that it will bring me the most number of
> available features and depend on configure to warn me about conflicts.

The code needs a little tweaking to work with libfaac, but even when I
did that and enabled libfaac instead of the built-in AAC encoder, I
still had the same audio issues, so I don't believe it's an issue of
which AAC encoder is being used. That also seems to rule out anything
to do with the integer to floating point audio conversion since libfaac
uses the integer data.

> ========
>
> Whoop, forgot to write that I can cure the warbling by jumping back
> maybe 5 seconds in the video. Like the previous problem with clipped
> sound, moving around the stream seems to make it go away. I haven't
> played a long enough stream to know if the warble will come back later.

I can't seem to get rid of the warbling on my iPhone 3GS, I tried
skipping around, changing the bitrate, etc.. If there's a workaround,
I'd be happy to find it rather than telling some users they need to
(re)enable MP3 audio for their devices.

> And, a final question for Chris: do you want these running bug
> reports? With the release near I'm not sure if you're shooting for good
> enough or perfect in all cases.

I think we're in a pretty good place right now, the main two things
bugging me are the AAC vs MP3 audio on some devices, and the blockiness
at startup. I'm looking into something with the blockiness, so
hopefully I find that soon enough. If you find other bugs, feel free
to post a message and we can discuss. I'd like to get it more usable
and as stable as possible for 0.26.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Jul 20, 2012, 3:04 PM

Post #6 of 11 (579 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

* On Fri Jul 20, 2012 at 02:30:43PM -0700, Chris Pinkham wrote:
> I think we're in a pretty good place right now, the main two things
> bugging me are the AAC vs MP3 audio on some devices, and the blockiness
> at startup. I'm looking into something with the blockiness, so

And the blockiness should be fixed now, so now I can take a look back
at the warbly AAC issue.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

jyavenard at gmail

Jul 20, 2012, 5:32 PM

Post #7 of 11 (569 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

On 21 July 2012 06:06, George Nassas <gnassas [at] mac> wrote:
> Also, how did you know about libfaac being problematic? I didn't see anything about that in the commits or maybe I missed it. I enable everything I can in the hope that it will bring me the most number of available features and depend on configure to warn me about conflicts.

Because the log shows that it's using libfaac.

You don't need libfaac anymore, instead use the built-in ffmpeg AAC encoder
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Jul 20, 2012, 6:26 PM

Post #8 of 11 (564 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

* On Fri Jul 20, 2012 at 02:30:43PM -0700, Chris Pinkham wrote:
> I did use your test file. I can play it fine using AAC or MP3 audio
> on my iPhone 4 running iOS 5.1.1, but not on my 3GS running iOS 4.1.

And I just got home and retested and found that I do get the bad audio
with AAC even on my iPhone 4 if I let the video continue, it starts out
good and then goes bad, so I'll take a look at that tonight if I can to
try to track that down.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Jul 20, 2012, 6:27 PM

Post #9 of 11 (567 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

* On Sat Jul 21, 2012 at 10:32:55AM +1000, Jean-Yves Avenard wrote:
> On 21 July 2012 06:06, George Nassas <gnassas [at] mac> wrote:
> > Also, how did you know about libfaac being problematic? I didn't see anything about that in the commits or maybe I missed it. I enable everything I can in the hope that it will bring me the most number of available features and depend on configure to warn me about conflicts.
>
> Because the log shows that it's using libfaac.
>
> You don't need libfaac anymore, instead use the built-in ffmpeg AAC encoder

libfaac won't get used even if compiled in. To use libfaac, you
select the "libfaac" codec and to use the built-in AAC encoder,
you select "aac". mythtranscode's HLS code uses "aac".

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

jyavenard at gmail

Jul 20, 2012, 8:23 PM

Post #10 of 11 (564 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

On 21 July 2012 11:27, Chris Pinkham <cpinkham [at] bc2va> wrote:
> libfaac won't get used even if compiled in. To use libfaac, you
> select the "libfaac" codec and to use the built-in AAC encoder,
> you select "aac". mythtranscode's HLS code uses "aac".

Did you see in the log:
CoreContext avformatdecoder.cpp:216 (myth_av_log) - [libfaac @
0x7ff89aee34a0] Specified sample_fmt is not supported.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Jul 20, 2012, 9:57 PM

Post #11 of 11 (565 views)
Permalink

Re: [mythtv-commits] mythtv branch master updated by cpinkham. v0.26-alpha-9-g6fb8692 [In reply to]

* On Sat Jul 21, 2012 at 01:23:43PM +1000, Jean-Yves Avenard wrote:
> On 21 July 2012 11:27, Chris Pinkham <cpinkham [at] bc2va> wrote:
> > libfaac won't get used even if compiled in. To use libfaac, you
> > select the "libfaac" codec and to use the built-in AAC encoder,
> > you select "aac". mythtranscode's HLS code uses "aac".
>
> Did you see in the log:
> CoreContext avformatdecoder.cpp:216 (myth_av_log) - [libfaac @
> 0x7ff89aee34a0] Specified sample_fmt is not supported.

Yeah, but I fixed that on my checkout but never committed it.
Rather than hard-coding the sample format like I do, I need to
use the sample format used by the selected codec. People
shouldn't need to use libfaac over the internal encoder, so I
didn't see a need for a fix yet. If --avf mode is extended
to allow specifying the codec, then the hard-coding I have
now of float for aac vs int for mp3 will have to change.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads