Mailing List Archive: MythTV: Dev

How do I submit a fix?

Index | Next | Previous | View Threaded

simon.sinister at sbcglobal

May 23, 2012, 7:40 PM

Post #1 of 4 (362 views)
Permalink

How do I submit a fix?

Hi,

I'm a potential first time contributor, but I need some help.

I have a solution for a ticket which already exists.

http://code.mythtv.org/trac/ticket/10712

I've read and followed the instructions at

http://www.mythtv.org/wiki/Submitting_Bug_Fixes
http://code.mythtv.org/trac/
http://code.mythtv.org/trac/wiki/TicketHowTo
http://code.mythtv.org/trac/wiki/UsingGit

I've registered an account at github.com, and I've cloned the MythTV
project.

This is the first time I've used Git, so I found a very helpful book to
provide some instructions.

http://git-scm.com/book

I've implemented the fix in my view. I've run 'git add' and 'git commit
-v', but
now the Myth development documentation has left me hanging. What exactly
is the next step?

The git-scm book talks about "pushing". The only reference I've found on
the Myth wiki pages says "git push -n should always verified before real
pushing".
So I tried that, and it just fails saying "Permission to
MythTV/mythtv.git denied".

Elsewhere I've found some vague instructions to "attach a patch to a
ticket",
but there is no explanation of the format of "a patch". Is this supposed
to be
a diff listing on each file? Is this supposed to identify a git branch
which is
publicly readable? How do I create that?

Please provide me some guidance on how to proceed.

Thanks,

- Steve E

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

May 23, 2012, 8:30 PM

Post #2 of 4 (342 views)
Permalink

Re: How do I submit a fix? [In reply to]

On 05/23/2012 10:40 PM, Steve E wrote:
> Hi,
>
> I'm a potential first time contributor, but I need some help.
>
> I have a solution for a ticket which already exists.
>
> http://code.mythtv.org/trac/ticket/10712
>
> I've read and followed the instructions at
>
> http://www.mythtv.org/wiki/Submitting_Bug_Fixes
> http://code.mythtv.org/trac/
> http://code.mythtv.org/trac/wiki/TicketHowTo
> http://code.mythtv.org/trac/wiki/UsingGit
>
> I've registered an account at github.com, and I've cloned the MythTV
> project.
>
> This is the first time I've used Git, so I found a very helpful book to
> provide some instructions.
>
> http://git-scm.com/book
>
> I've implemented the fix in my view. I've run 'git add' and 'git
> commit -v', but
> now the Myth development documentation has left me hanging. What exactly
> is the next step?
>
> The git-scm book talks about "pushing". The only reference I've
> found on
> the Myth wiki pages says "git push -n should always verified before
> real pushing".
> So I tried that, and it just fails saying "Permission to
> MythTV/mythtv.git denied".
>
> Elsewhere I've found some vague instructions to "attach a patch to a
> ticket",
> but there is no explanation of the format of "a patch". Is this
> supposed to be
> a diff listing on each file? Is this supposed to identify a git branch
> which is
> publicly readable? How do I create that?
>
> Please provide me some guidance on how to proceed.

You can use:

git diff origin/master HEAD >
$HOME/mythtv-10712-use_OCUR_only_with_CableCARD.patch

to create a patch, which you can attach to the ticket. (Assuming you
made the changes in the master branch.)

Alternatively, you can create a pull request (
http://help.github.com/send-pull-requests/ ), and then add a comment to
the ticket that references the pull request you've submitted.

Thanks,
Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

dekarl at spaetfruehstuecken

May 27, 2012, 2:11 AM

Post #3 of 4 (318 views)
Permalink

Re: How do I submit a fix? [In reply to]

Hi Steve,

On 24.05.2012 05:30, Michael T. Dean wrote:
> On 05/23/2012 10:40 PM, Steve E wrote:
>>
>> I have a solution for a ticket which already exists.
>>
...
>>
>> I've implemented the fix in my view. I've run 'git add' and 'git
>> commit -v', but
>> now the Myth development documentation has left me hanging. What exactly
>> is the next step?
>>
...
>>
>> Please provide me some guidance on how to proceed.
>
> You can use:
>
> git diff origin/master HEAD >
> $HOME/mythtv-10712-use_OCUR_only_with_CableCARD.patch
>
> to create a patch, which you can attach to the ticket. (Assuming you
> made the changes in the master branch.)
>
> Alternatively, you can create a pull request (
> http://help.github.com/send-pull-requests/ ), and then add a comment to
> the ticket that references the pull request you've submitted.

I do it like this.
I "git pull" master, then move my changes forward to the latest master
with "git rebase origin" and create patches with "git format-patch
origin"

that allows me to shuffle around my patches with "git rebase -i origin"
and recreate a set of all my patches

Regards,
Karl
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

simon.sinister at sbcglobal

May 27, 2012, 2:42 PM

Post #4 of 4 (304 views)
Permalink

Re: How do I submit a fix? [In reply to]

Thank you Mike, for providing the 'git diff origin/master HEAD >
patchFile' syntax
example (which I used to submit my patch), and thank you Karl for the
'git format-patch'
example. I'll try that next time.

- Steve

On 05/27/2012 04:11 AM, Karl Dietz wrote:
> Hi Steve,
>
> On 24.05.2012 05:30, Michael T. Dean wrote:
>> On 05/23/2012 10:40 PM, Steve E wrote:
>>>
>>> I have a solution for a ticket which already exists.
>>>
> ...
>>>
>>> I've implemented the fix in my view. I've run 'git add' and 'git
>>> commit -v', but
>>> now the Myth development documentation has left me hanging. What
>>> exactly
>>> is the next step?
>>>
> ...
>>>
>>> Please provide me some guidance on how to proceed.
>>
>> You can use:
>>
>> git diff origin/master HEAD >
>> $HOME/mythtv-10712-use_OCUR_only_with_CableCARD.patch
>>
>> to create a patch, which you can attach to the ticket. (Assuming you
>> made the changes in the master branch.)
>>
>> Alternatively, you can create a pull request (
>> http://help.github.com/send-pull-requests/ ), and then add a comment to
>> the ticket that references the pull request you've submitted.
>
> I do it like this.
> I "git pull" master, then move my changes forward to the latest master
> with "git rebase origin" and create patches with "git format-patch
> origin"
>
> that allows me to shuffle around my patches with "git rebase -i origin"
> and recreate a set of all my patches
>
> Regards,
> Karl
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev [at] mythtv
> http://www.mythtv.org/mailman/listinfo/mythtv-dev
>

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads