Mailing List Archive: MythTV: Dev

MediaMonitor - Scan for devices if Monitor Drives is disabled?

Index | Next | Previous | View Threaded

mtdean at thirdcontact

Feb 6, 2012, 6:19 PM

Post #1 of 3 (267 views)
Permalink

MediaMonitor - Scan for devices if Monitor Drives is disabled?

Nigel,

Ever since the D-Bus busy loop that waits 5s for UDisks service to start
for those users who start mythfrontend before starting prerequisite
services was added in
https://github.com/MythTV/mythtv/commit/cfcf7d640e3 , mythfrontend UI
creation is blocked for those 5s for those of us who don't have UDisks
installed. Ignoring the fact that we should probably move that busy
loop out of the UI creation thread/background D-Bus wait, I'm wondering
why we're even scanning for devices on my system.

I disabled the setting:

Monitor CD/DVD (and other removable devices)
This enables support for monitoring your CD/DVD drives for new disks and
launching the proper plugin to handle them.

but MediaMonitor still calls CheckFileSystemTable() and
CheckMountable(). Is there any benefit to building these lists if
MonitorDrives is disabled? I was wondering if it would be possible to
work around the busy loop issue by only calling CheckFileSystemTable()
and/or CheckMountable() for those who have enabled the MonitorDrives
setting?

Thanks,
Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

nigel at ind

Feb 6, 2012, 6:26 PM

Post #2 of 3 (256 views)
Permalink

Re: MediaMonitor - Scan for devices if Monitor Drives is disabled? [In reply to]

> Is there any benefit to building these lists if
> MonitorDrives is disabled?

It might have been so that the user could eject or
unmount drives that other system processes had mounted?
(By name)

i.e. Minimal benefit.

> I was wondering if it would be possible to
> work around the busy loop issue by only calling CheckFileSystemTable()
> and/or CheckMountable() for those who have enabled the MonitorDrives
> setting?

Sounds OK, but I haven't looked at, or tested on Unix,
that code for years :-(

--
Nigel Pearson, nigel [at] ind| "I am one in
Telstra Net. Eng., Sydney, Australia | a krillion!"
Office: 9202 3900 Fax: 9212 6348 | Will the Krill.
Mobile: 0408 664435 Home: 9792 6998 | Happy Feet 2.

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

Feb 6, 2012, 8:45 PM

Post #3 of 3 (254 views)
Permalink

Re: MediaMonitor - Scan for devices if Monitor Drives is disabled? [In reply to]

On 02/06/2012 09:26 PM, Nigel Pearson wrote:
>> Is there any benefit to building these lists if
>> MonitorDrives is disabled?
> It might have been so that the user could eject or
> unmount drives that other system processes had mounted?
> (By name)
>
> i.e. Minimal benefit.
>
>> I was wondering if it would be possible to
>> work around the busy loop issue by only calling CheckFileSystemTable()
>> and/or CheckMountable() for those who have enabled the MonitorDrives
>> setting?
> Sounds OK, but I haven't looked at, or tested on Unix,
> that code for years :-(

Thanks. I knew it had changed quite a bit since you'd last done
anything with it, but figured you'd have some ideas.

And, it sounds like skipping the static-list creation may be more of a
problem than it's worth. I'm guessing that most people who disable
monitoring drives still use the eject functionality (and that I'm the
only person who uses neither). I suppose if I have to live with waiting
on the D-Bus poll loop to time out, it may actually help to motivate me
to fix it properly.

Thanks,
Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads