Mailing List Archive: MythTV: Dev

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts

Index | Next | Previous | View Threaded

lists at glidos

Jan 30, 2012, 2:06 AM

Post #1 of 6 (382 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts

On 30/01/2012 06:27, MythTV wrote:
> #10008: mythtranscode: picture corruption and momentary stalling after cuts
> ----------------------------------+-----------------------------
> Reporter: mythtv@… | Owner: beirdo
> Type: Bug Report - General | Status: closed
> Priority: minor | Milestone: 0.25
> Component: MythTV - General | Version: Unspecified
> Severity: medium | Resolution: fixed
> Keywords: | Ticket locked: 0
> ----------------------------------+-----------------------------
> Changes (by Github):
>
> * status: assigned => closed
> * resolution: => fixed
> * milestone: unknown => 0.25
>
>
> Comment:
>
> Merge branch 'glidos-master'
>
> Adds --cleancut parameter to mythtranscode.
>
> Closes #10008
>
> Merged in changes from git://github.com/Glidos/mythtv.git master branch.
> Branch: master
> Changeset: 2eb5723426ed1cd6f3856f33bb8ebef98e385200

Great. Thanks Beirdo.

Cheers,
Paul.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

lists at glidos

Jan 30, 2012, 4:27 AM

Post #2 of 6 (362 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts [In reply to]

On 30/01/2012 12:10, MythTV wrote:
> #10008: mythtranscode: picture corruption and momentary stalling after cuts
> ----------------------------------+-----------------------------
> Reporter: mythtv@… | Owner: beirdo
> Type: Bug Report - General | Status: new
> Priority: minor | Milestone: 0.25
> Component: MythTV - General | Version: Unspecified
> Severity: medium | Resolution:
> Keywords: | Ticket locked: 0
> ----------------------------------+-----------------------------
> Changes (by danielk):
>
> * status: closed => new
> * resolution: fixed =>
>
>
> Comment:
>
> This appears to have introduced two new complaints in the cppcheck report.
>

That will be my fault. I'm afraid I don't know what cppcheck is, but if
someone could give a brief explanation, I could try to fix the problems.
Or, if someone else fixes them, please say what they were, so that I
can endeavour to avoid the same problems in future patches.

Cheers,
Paul.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

danielk at cuymedia

Jan 30, 2012, 4:34 AM

Post #3 of 6 (366 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts [In reply to]

On Mon, 2012-01-30 at 12:27 +0000, Paul Gardiner wrote:
> On 30/01/2012 12:10, MythTV wrote:
> > #10008: mythtranscode: picture corruption and momentary stalling after cuts
> > ----------------------------------+-----------------------------
> > This appears to have introduced two new complaints in the cppcheck report.
> That will be my fault. I'm afraid I don't know what cppcheck is, but if
> someone could give a brief explanation, I could try to fix the problems.
> Or, if someone else fixes them, please say what they were, so that I
> can endeavour to avoid the same problems in future patches.

cppcheck is a static analysis tool we run on the code.

You can see the latest results here:
http://code.mythtv.org/cppcheck/

Search for transcode.cpp in the report to find both.

In this case there appears to be an uninitialized variable
in the constructor and a non-const method that doesn't modify
the instance; that one should probably have a
"GetAdjustedCutList(void) const" signature.

-- Daniel

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

stuart at tase

Jan 30, 2012, 4:37 AM

Post #4 of 6 (365 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts [In reply to]

On Monday 30 Jan 2012 12:27:36 Paul Gardiner wrote:
> On 30/01/2012 12:10, DanielK wrote:
> > This appears to have introduced two new complaints in the cppcheck
> > report.
>
> That will be my fault. I'm afraid I don't know what cppcheck is, but if
> someone could give a brief explanation, I could try to fix the problems.
> Or, if someone else fixes them, please say what they were, so that I
> can endeavour to avoid the same problems in future patches.

Cppcheck is a static analysis tool that we run against the source twice a day
to produce this report: http://code.mythtv.org/cppcheck/index.html

It's linked to from the main page http://code.mythtv.org/ under the section
headed 'Status Pages'
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

lists at glidos

Jan 30, 2012, 4:41 AM

Post #5 of 6 (365 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts [In reply to]

On 30/01/2012 12:34, Daniel Kristjansson wrote:
> On Mon, 2012-01-30 at 12:27 +0000, Paul Gardiner wrote:
>> On 30/01/2012 12:10, MythTV wrote:
>>> #10008: mythtranscode: picture corruption and momentary stalling after cuts
>>> ----------------------------------+-----------------------------
>>> This appears to have introduced two new complaints in the cppcheck report.
>> That will be my fault. I'm afraid I don't know what cppcheck is, but if
>> someone could give a brief explanation, I could try to fix the problems.
>> Or, if someone else fixes them, please say what they were, so that I
>> can endeavour to avoid the same problems in future patches.
>
> cppcheck is a static analysis tool we run on the code.
>
> You can see the latest results here:
> http://code.mythtv.org/cppcheck/
>
> Search for transcode.cpp in the report to find both.
>
> In this case there appears to be an uninitialized variable
> in the constructor and a non-const method that doesn't modify
> the instance; that one should probably have a
> "GetAdjustedCutList(void) const" signature.

Oh nice tool! Thanks for the explanation.

Cheers,
Paul.

And thanks to Struart Morgan too.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

lists at glidos

Jan 30, 2012, 6:49 AM

Post #6 of 6 (361 views)
Permalink

Re: Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts [In reply to]

On 30/01/2012 14:01, MythTV wrote:
> #10008: mythtranscode: picture corruption and momentary stalling after cuts
> ----------------------------------+-----------------------------
> Reporter: mythtv@… | Owner: beirdo
> Type: Bug Report - General | Status: new
> Priority: minor | Milestone: 0.25
> Component: MythTV - General | Version: Unspecified
> Severity: medium | Resolution:
> Keywords: | Ticket locked: 0
> ----------------------------------+-----------------------------
>
> Comment (by lihamakaroonilaatikko@…):
>
> Hopefully someone will backport this to 0.24-fixes since the problem
> exists also in 0.24.2.
>

My fork here: git://github.com/Glidos/mythtv.git already has versions on
0.24-fixes and jyavenard/backports/fixes/0.24. I've been using the
latter because that include --passthrough.

Paul.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads