Mailing List Archive: MythTV: Dev

Quick Jack fix for 0.23

Index | Next | Previous | View Threaded

lists at wildgooses

Apr 3, 2010, 10:11 AM

Post #1 of 4 (619 views)
Permalink

Quick Jack fix for 0.23

Hi, I just checked out the latest git
(git://git.jannau.net/mythtv.complete) on the 0.23 branch and noticed
that the Jack code was accidently broken by commit:
454d47c184cf55460f9e7a89f6373a274b0e13f3 (git-svn-id:
http://svn.mythtv.org/svn/trunk [at] 2243 7dbf422c-18fa-0310-86e9-fd20926502f2)

The patch attached should fix things. Essentially there is a double
free because you should only call the JACK_Close call if the open succeeded.

Grateful if someone could slip this in before the 0.23 release since
it's otherwise a show stopper for myself and the other jack user...

Thanks

Ed W

Attachments:

jack_22_fix.diff (0.77 KB)

robert.mcnamara at gmail

Apr 3, 2010, 3:43 PM

Post #2 of 4 (593 views)
Permalink

Re: Quick Jack fix for 0.23 [In reply to]

On Sat, Apr 3, 2010 at 10:11 AM, Ed W <lists [at] wildgooses> wrote:
> Hi, I just checked out the latest git (git://git.jannau.net/mythtv.complete)
> on the 0.23 branch and noticed that the Jack code was accidently broken by
> commit: 454d47c184cf55460f9e7a89f6373a274b0e13f3 (git-svn-id:
> http://svn.mythtv.org/svn/trunk [at] 2243 7dbf422c-18fa-0310-86e9-fd20926502f2)
>
> The patch attached should fix things. Essentially there is a double free
> because you should only call the JACK_Close call if the open succeeded.
>
> Grateful if someone could slip this in before the 0.23 release since it's
> otherwise a show stopper for myself and the other jack user...
>
> Thanks
>
> Ed W
>

Ed,

Go ahead and open a ticket on the topic, including the patch, if you
haven't already.

Robert
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

jyavenard at gmail

Apr 3, 2010, 4:22 PM

Post #3 of 4 (588 views)
Permalink

Re: Quick Jack fix for 0.23 [In reply to]

Hi

On 4 April 2010 03:11, Ed W <lists [at] wildgooses> wrote:
> Grateful if someone could slip this in before the 0.23 release since it's
> otherwise a show stopper for myself and the other jack user...

That patch is wrong ...

if (err = ERR_SUCCESS)

That will always resolve as TRUE if ERR_SUCCESS is non-null; so will
always call JACK_Close(audioid);
just like what the code does now...
If not, you never close the Jack port

I'm sure you intended to write err == ERR_SUCCESS
but I'm puzzled why your patch works for you
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

lists at wildgooses

Apr 3, 2010, 4:38 PM

Post #4 of 4 (591 views)
Permalink

Re: Quick Jack fix for 0.23 [In reply to]

On 04/04/2010 00:22, Jean-Yves Avenard wrote:
> Hi
>
> On 4 April 2010 03:11, Ed W<lists [at] wildgooses> wrote:
>
>> Grateful if someone could slip this in before the 0.23 release since it's
>> otherwise a show stopper for myself and the other jack user...
>>
> That patch is wrong ...
>
> if (err = ERR_SUCCESS)
>
> That will always resolve as TRUE if ERR_SUCCESS is non-null; so will
> always call JACK_Close(audioid);
> just like what the code does now...
> If not, you never close the Jack port
>
> I'm sure you intended to write err == ERR_SUCCESS
> but I'm puzzled why your patch works for you
> _______________________________________________
>

Good catch - thanks!

Actually I'm debugging a whole heap of other junk that is cropping up
apparently due to thread timing, etc and that bio2jack layer. I've kind
of got bored with that and it's my intention to remove the bio2jack code
and implement a direct output to jack. It's going to depend if I get
some time tomorrow/monday to finish this. It's been on my Todo list for
about 5 years now...

Thanks

Ed W
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads