Mailing List Archive: MythTV: Dev

Re: mythtv commit: r23016 - in trunk by stuartm

Index | Next | Previous | View Threaded

david at istwok

Dec 28, 2009, 9:13 AM

Post #1 of 10 (1907 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm

On Mon, Dec 28, 2009 at 12:05:21PM +0000, mythtv [at] cvs wrote:
> Author: stuartm
> Date: 2009-12-28 12:05:21 +0000 (Mon, 28 Dec 2009)
> New Revision: 23016
> Changeset: http://svn.mythtv.org/trac/changeset/23016
>
> Modified:
>
> trunk/myththemes/Mythbuntu/htmls/progdetails_page1.html
> trunk/myththemes/Mythbuntu/htmls/progdetails_page2.html
> trunk/mythtv/themes/MythCenter/htmls/progdetails_page1.html
> trunk/mythtv/themes/MythCenter/htmls/progdetails_page2.html
> trunk/mythtv/themes/Terra/htmls/progdetails_page1.html
> trunk/mythtv/themes/Terra/htmls/progdetails_page2.html
>
> Log:
>
> Declare the correct charset in the Program Details html. Fixes #7813

Should this be applied to 0.22+fixes as well? This is probably the
reason Kerry Bishe's name is meesed up on new episodes of "Scrubs".

David
--
David Engel
david [at] istwok
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ylee at pobox

Dec 31, 2009, 2:08 AM

Post #2 of 10 (1765 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

David Engel <david [at] istwok> says:
> Should this be applied to 0.22+fixes as well? This is probably the
> reason Kerry Bishe's name is meesed up on new episodes of "Scrubs".

Yes, please! It's clearly a bug (one that didn't exist in 0.21), and
had the fix existed earlier I wouldn't have ended up blowing away four
years' worth of recorded programs' credits data in a futile effort to
fix what I believed was an artifact of the 0.21->0.22 UTF8
bungling.[*]

(I want to be clear here. The loss of historical credits is 100% my
fault. Nothing in MythTV today actually uses the data for anything
besides being able to show actors' names when DETAILS is pushed in
MythFrontend.

Still, it'd have been nice to have the data for the day when the PBB
offers some sort of search feature by actor's name. More to the point,
I wouldn't have ever ventured down the road of foolishness had this
bug (and its proximity to the 0.22 upgrade, which caused me to think
that the UTF8 mess was affecting my setup despite it not actually ever
doing so) not arrived with 0.22.)

--
Frontend/backend: P4 3.0GHz, 1.5TB software RAID 5 array
Backend: Quad-core Xeon 1.6GHz, 6.6TB sw RAID 6
Video inputs: Four high-definition over FireWire/OTA
Accessories: 47" 1080p LCD, 5.1 digital, and MX-600
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

david at istwok

Dec 31, 2009, 10:09 AM

Post #3 of 10 (1761 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On Thu, Dec 31, 2009 at 02:08:55AM -0800, Yeechang Lee wrote:
> David Engel <david [at] istwok> says:
> > Should this be applied to 0.22+fixes as well? This is probably the
> > reason Kerry Bishe's name is meesed up on new episodes of "Scrubs".
>
> Yes, please! It's clearly a bug (one that didn't exist in 0.21), and
> had the fix existed earlier I wouldn't have ended up blowing away four
> years' worth of recorded programs' credits data in a futile effort to
> fix what I believed was an artifact of the 0.21->0.22 UTF8
> bungling.[*]

Yeechang, do you have a specific actor's name that shows the problem
in 0.22 and is fixed with this change? I actually started to apply
the changes to 0.22 yesterday. It didn't appear to fix the problem I
saw with Kerry Bishe, so I didn't commit it.

David
--
David Engel
david [at] istwok
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

Dec 31, 2009, 7:40 PM

Post #4 of 10 (1744 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On 12/31/2009 01:09 PM, David Engel wrote:
> On Thu, Dec 31, 2009 at 02:08:55AM -0800, Yeechang Lee wrote:
>
>> David Engel says:
>>
>>> Should this be applied to 0.22+fixes as well? This is probably the
>>> reason Kerry Bishe's name is meesed up on new episodes of "Scrubs".
>>>
>> Yes, please! It's clearly a bug (one that didn't exist in 0.21), and
>> had the fix existed earlier I wouldn't have ended up blowing away four
>> years' worth of recorded programs' credits data in a futile effort to
>> fix what I believed was an artifact of the 0.21->0.22 UTF8
>> bungling.[*]
> Yeechang, do you have a specific actor's name that shows the problem
> in 0.22 and is fixed with this change? I actually started to apply
> the changes to 0.22 yesterday. It didn't appear to fix the problem I
> saw with Kerry Bishe, so I didn't commit it.

FWIW, a large number of people have corrupt names in their people table
because they corrupted their database back when we used latin1 storage
and they followed the old instructions on the HOWTO for doing a "new
hardware/partial restore". The procedure given always corrupts.

So, if either of you had ever done a partial restore with the database
you're using now, you have broken names.

Of course, for new names, the data should be correct.

Out of curiosity, what do you get from:

SELECT person, name, HEX(name) FROM people WHERE name LIKE 'Kerry B%';

I'm considering eventually fixing people.name in a DB update, but it's
extremely low on my priority list.

Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

bc-mythtv at comcast

Jan 1, 2010, 3:16 AM

Post #5 of 10 (1739 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On 12/31/2009 10:40 PM, Michael T. Dean wrote:
> FWIW, a large number of people have corrupt names in their people table
> because they corrupted their database back when we used latin1 storage
> and they followed the old instructions on the HOWTO for doing a "new
> hardware/partial restore". The procedure given always corrupts.

Even less FWIW, I had corrupted entries in the people table even though
I had never done a partial restore and I had never mucked with character
encodings at all (and I never used Gentoo :-). To get past the 0.22
upgrade I had to fix these entries by hand. It was only a problem in the
people table.

Bolek
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ylee at pobox

Jan 1, 2010, 4:22 AM

Post #6 of 10 (1727 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

David Engel <david [at] istwok> says:
> Yeechang, do you have a specific actor's name that shows the problem
> in 0.22 and is fixed with this change? I actually started to apply
> the changes to 0.22 yesterday. It didn't appear to fix the problem
> I saw with Kerry Bishe, so I didn't commit it.

Darn! I've actually not had the chance to use the patch--traveling for
the holidays--so hearing that it may not work is dismaying.

The two examples I used to test my setup were John le Carr� and Dul�
Hill.

(Note that the names show up properly in MythWeb.)

--
Frontend/backend: P4 3.0GHz, 1.5TB software RAID 5 array
Backend: Quad-core Xeon 1.6GHz, 6.6TB sw RAID 6
Video inputs: Four high-definition over FireWire/OTA
Accessories: 47" 1080p LCD, 5.1 digital, and MX-600
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ylee at pobox

Jan 1, 2010, 4:32 AM

Post #7 of 10 (1728 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

Michael T. Dean <mtdean [at] thirdcontact> says:
> SELECT person, name, HEX(name) FROM people WHERE name LIKE 'Kerry B%';

The hex code I get is 4B657272792042697368C3A9; I gather C3A9 is
Unicode for �.

But, as I said, I blew away my historical credits data during the
ultimately fatal wild-goose chase so my current credits data should be
clean. As mentioned in my reply to David one of the names I used for
checking to see whether Mythfrontend 0.22 displayed accented
characters correctly was John le Carr�. I remember seeing the
following entries in the database:

John le Carr� (correct)
John le Carré (latin1 rendition of Unicode)
John le Carréé (or something like that)

--
Frontend/backend: P4 3.0GHz, 1.5TB software RAID 5 array
Backend: Quad-core Xeon 1.6GHz, 6.6TB sw RAID 6
Video inputs: Four high-definition over FireWire/OTA
Accessories: 47" 1080p LCD, 5.1 digital, and MX-600
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

david at istwok

Jan 1, 2010, 3:16 PM

Post #8 of 10 (1696 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On Thu, Dec 31, 2009 at 10:40:13PM -0500, Michael T. Dean wrote:
> FWIW, a large number of people have corrupt names in their people
> table because they corrupted their database back when we used latin1
> storage and they followed the old instructions on the HOWTO for
> doing a "new hardware/partial restore". The procedure given always
> corrupts.

I don't recall running any such instructions. I restored oldrecorded
some time ago by using mysqldump --> edit --> mysql, but I don't
believe I did so for the entire database. It's been long enough, that
I'm not entirely sure though. Is there any way to tell after the
fact?

> Out of curiosity, what do you get from:
>
> SELECT person, name, HEX(name) FROM people WHERE name LIKE 'Kerry B%';

Here is what I get:

mysql> SELECT person, name, HEX(name) FROM people WHERE name LIKE 'Kerry B%';
+--------+--------------+--------------------------+
| person | name | HEX(name) |
+--------+--------------+--------------------------+
| 50757 | Kerry Barden | 4B657272792042617264656E |
| 22382 | Kerry Beyer | 4B65727279204265796572 |
| 88818 | Kerry Bishe | 4B65727279204269736865 |
| 99652 | Kerry Bish� | 4B657272792042697368C3A9 |
| 16082 | Kerry Butler | 4B65727279204275746C6572 |
+--------+--------------+--------------------------+
5 rows in set (0.00 sec)

I'm not sure how it displays on your end, but the second instance of
"Kerry Bish?" is correct in konsole on my end with the accent over the
'e'. When I view it in the program details screens using MythCenter
and Terra, the accent-'e' is replaced with tilde-'A' and the copyright
symbol.

David
--
David Engel
david [at] istwok

stuart at tase

Jan 1, 2010, 3:41 PM

Post #9 of 10 (1698 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On Friday 01 Jan 2010 23:16:29 David Engel wrote:
> I'm not sure how it displays on your end, but the second instance of
> "Kerry Bish?" is correct in konsole on my end with the accent over the
> 'e'. When I view it in the program details screens using MythCenter
> and Terra, the accent-'e' is replaced with tilde-'A' and the copyright
> symbol.

David, could you try dropping in a .toUtf8() in the key replace of
programdetails.cpp?
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

david at istwok

Jan 1, 2010, 7:56 PM

Post #10 of 10 (1677 views)
Permalink

Re: mythtv commit: r23016 - in trunk by stuartm [In reply to]

On Fri, Jan 01, 2010 at 11:41:22PM +0000, Stuart Morgan wrote:
> On Friday 01 Jan 2010 23:16:29 David Engel wrote:
> > I'm not sure how it displays on your end, but the second instance of
> > "Kerry Bish?" is correct in konsole on my end with the accent over the
> > 'e'. When I view it in the program details screens using MythCenter
> > and Terra, the accent-'e' is replaced with tilde-'A' and the copyright
> > symbol.
>
> David, could you try dropping in a .toUtf8() in the key replace of
> programdetails.cpp?

Can you be more specific in exactly where you want the .toUtf8() added?
I tried in a couple of places the effect was to change

B i s h tilde-A copyright

to

B i s h tilde-A caret-A copyright

David
--
David Engel
david [at] istwok
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads