Mailing List Archive: MythTV: Dev

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic

Index | Next | Previous | View Threaded

warpme at o2

Nov 14, 2009, 8:39 AM

Post #1 of 5 (1078 views)
Permalink

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic

Well,

Let me point out that from my perspective, message passed by my report
is no "me too" but rather info that it is regression.

Maybe I wrongly interpreting comments of jyavenard (as for me it suggest
that issue is result of limitations of mythtv/spdif).
Also nature of proposed solution is more workaround than RCA with final
solution not decreasing myth functional level.

As in past all was OK, if I would be developer - my msg will be key for
me, as it change interpretation of issue from "it is design limitation"
to "it is regression"

By above I disagree with Your kind remark about useless nature of my
report....

If You can't/don't have willingness/time/whatever to help resolve it -
fine. I really appreciate Your work on myth.
But if if You want to do something with this issue - I'm trying to help
- just by such reports.

br

MythTV wrote:
> #7426: Static noise from 96kHz/24bit audio files in MythMusic
> ---------------------------------------------------+------------------------
> Reporter: Paul Hooper <paul.a.hooper@…> | Owner: jyavenard
> Type: defect | Status: infoneeded
> Priority: minor | Milestone: unknown
> Component: MythTV - Audio Output | Version: 0.22rc1
> Severity: medium | Mlocked: 0
> ---------------------------------------------------+------------------------
> Changes (by stuartm):
>
> * status: assigned => infoneeded
> * milestone: 0.22 => unknown
>
>
> Comment:
>
> Warpme, instead of a useless 'me too' you could have tested jyavenard's
> patch.
>
>

Attachments:

warpme.vcf (90 B)

warpme at o2

Nov 14, 2009, 9:52 AM

Post #2 of 5 (1026 views)
Permalink

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic [In reply to]

Daniel,

Thx for this.

Indeed not testing jyavenard patch and complaining wasn't fair.
Reason why I not tested patch was, it require some effort (I'm using
myth as diskless appliance so it is little more complicated than simple
make make install). Also patch description suggests that solution
workaround type of solution (downsampling to 16bit).
Even if it works OK - IMHO it is not acceptable as it leads to loose
24/96 quality.

If there will be patch resolving this issue without quality degradation
- I'll be more than happy to help i.e. via testing it.

thx

MythTV wrote:
> #7426: Static noise from 96kHz/24bit audio files in MythMusic
> ---------------------------------------------------+------------------------
> Reporter: Paul Hooper <paul.a.hooper@…> | Owner: jyavenard
> Type: defect | Status: assigned
> Priority: minor | Milestone: unknown
> Component: MythTV - Audio Output | Version: 0.22rc1
> Severity: medium | Mlocked: 0
> ---------------------------------------------------+------------------------
>
> Comment(by danielk):
>
> Everyone calm down.
>
> Warpme, if the patch does not resolve your problem, please open a new
> ticket with a clear description of your problem. Posts to tickets send an
> e-mail to all MythTV developers and all those on the svn mailing list it
> is a very poor place to argue the merits of a bug report.
>
> Robert, the post most certainly belongs in the mailing list. Clearing up
> any confusion as to what is helpful information is something that should
> be done in a conversational forum. In this case there was a patch so
> telling jyavenard there was a regression without testing his solution was
> not terribly helpful, but as a general rule it is helpful to know whether
> a problem is a regression or not; regressions can be considerably easier
> to fix. As a non-developer Warpme could not be expected to understand this
> nuance without it being explained to him first.
>
> Now please continue any discussion on the mailing list. Tickets should be
> "just the facts".
>
>

Attachments:

warpme.vcf (90 B)

jyavenard at gmail

Nov 14, 2009, 10:01 AM

Post #3 of 5 (1028 views)
Permalink

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic [In reply to]

Hi

2009/11/15 Warpme <warpme [at] o2>:
> Well,
>
> Let me point out that from my perspective, message passed by my report is no
> "me too" but rather info that it is regression.

MythMusic doesn't handle any non-16 bits audio and never did...

The patch in the ticket adds automatic conversion of any non-16 bits
audio to 16-bits audio. It was deemed that performing the 24/32 -> 16
bits conversion in mythmusic itself wasn't the way to do it, and
instead the audio class should either natively support those audio
format, or perform the conversion.

Those changes will be committed when I'm done ; in the mean time, use
the patch if you need this functionality now.

>
> Maybe I wrongly interpreting comments of jyavenard (as for me it suggest
> that issue is result of limitations of mythtv/spdif).

it isn't an issue with spdif, it's an issue with mymusic.

It assumes that all content is 16 bits and initialise the audio class
to receive 16 bits audio.
It's always been that way.

> Also nature of proposed solution is more workaround than RCA with final
> solution not decreasing myth functional level.

If you want to provide a patch that implements native 24/32 bits audio
support ; feel free to open a new ticket and submit it...

>
> As in past all was OK, if I would be developer �- my msg will be key for me,
> as it change interpretation of issue from "it is design limitation" to "it
> is regression"

If it ever worked, it would have been a pure coincidence.(FFmpeg has
added 24/32 bits audio support across most codec, so where it would
have done down-conversion now it passes it through which myth doesn't
handle)

>
> By above I disagree with Your kind remark about useless nature of my
> report....

You have to admit it wasn't the most useful report to start with.
I certainly disagree with Robert that this discussion has no place in
the list. Where else would be a write place if it's not on the list??

>
> If You can't/don't have willingness/time/whatever to help resolve it - fine.
> I really appreciate Your work on myth.

native 24/32 bits audio support is on the way...
But it's no simple task because there are so many audio systems out
there (alsa, oss, oss3, mac, win, dx, you name it)..

So the solution I'm implementing will expande the audio class to
support > 16 bits audio , starting with alsa ; with other sound system
it will be by default down-converted to 16 bits audio.

Jean-Yves
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

jyavenard at gmail

Nov 14, 2009, 10:04 AM

Post #4 of 5 (1026 views)
Permalink

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic [In reply to]

2009/11/15 Warpme <warpme [at] o2>:
> Daniel,
>
> Thx for this.
>
> Indeed not testing jyavenard patch and complaining wasn't fair.
> Reason why I not tested patch was, it require some effort (I'm using myth as
> diskless appliance so it is little more complicated than simple �make make
> install). Also patch description suggests that solution workaround type of
> solution (downsampling to 16bit).
> Even if it works OK - IMHO it is not �acceptable as �it leads to loose 24/96
> quality.

Anything above 16 bits audio either would have never worked ; or would
have be down-converted to 16 bits anyway...

if it's not acceptable to you, again, feel free to submit a patch if
you don't like the (temporary) solution I've provided.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

warpme at o2

Nov 15, 2009, 1:32 AM

Post #5 of 5 (992 views)
Permalink

Re: Ticket #7426: Static noise from 96kHz/24bit audio files in MythMusic [In reply to]

Jean-Yves,

Thanx for replay.

I applied patch. It works OK.

I have to admit I'm not sure, was my few months ago tests with trunk,
had 24bit feed to AV or 16bit (as my Sony receiver is not reporting
sample length - it reports only samplerate - which is of course 96kHz).

I think patch should go to fixes branch as it works OK and without it
ppl are immediately complying about defect.

Thx for Your contribution.

Attachments:

warpme.vcf (83 B)

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads