myth at robinhill
Nov 20, 2009, 6:51 AM
Post #2 of 2
(471 views)
Permalink
|
|
Re: Ticket #7484: MythVideo image retrieval creating incorrectly named files for series containing '?'
[In reply to]
|
|
On Thu Nov 12, 2009 at 12:08:02PM +0000, Robin Hill wrote:
> On Wed Nov 11, 2009 at 08:54:03PM +0000, Robin Hill wrote:
>
> > On Wed Nov 11, 2009 at 06:23:42PM -0000, MythTV wrote:
> >
> > > #7484: MythVideo image retrieval creating incorrectly named files for series
> > > containing '?'
> > > -----------------------------------------------+----------------------------
> > > Reporter: Robin Hill <myth@…> | Owner: awithers
> > > Type: defect | Status: closed
> > > Priority: minor | Milestone: unknown
> > > Component: Plugin - MythVideo | Version: 0.22rc1
> > > Severity: medium | Resolution: fixed
> > > Mlocked: 0 |
> > > -----------------------------------------------+----------------------------
> > >
> > > Comment(by robertm):
> > >
> > > (In [22795]) Refs #7484, #7485. Backport rest of image redownload fixes,
> > > and replace a couple illegal characters in titles.
> > >
> >
> > Thanks for this - do similar changes need making in JAMU to ensure it
> > creates compatible filenames?
> >
> Also, shouldn't the illegal character removal code also be done in
> GetLocalVideoImage, otherwise it'll be redownloading the images every
> time.
>
> It might also be better if this illegal character stripping was done
> prior to deciding whether a directory name matches a series name (for
> showing covers/screenshots).
>
The attached patch (against 0.22 r22866) moves the illegal character
stripping from videodlg.cpp to the metadata class, as a new GetSafeTitle
method.
This is then used throughout videodlg.cpp to retrieve/store the metadata
in a safe format. Both the original and stripped title are used for
retrieving images, meaning existing images will still get retrieved.
The stripped title is also used for checking directory names against
series names, allowing coverart to be shown for series containing
invalid characters.
The only change I made to the character stripping was to instead replace
the ':' with ' -', as I feel that's the logical way to name series
directories where the series contains a ':' (e.g. "Terminator - The
Sarah Connor Chronicles").
Cheers,
Robin
--
___
( ' } | Robin Hill <myth [at] robinhill> |
/ / ) | Little Jim says .... |
// !! | "He fallen in de water !!" |
|
mythvideo_safetitle.diff
