Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] Ticket #7475: [PATCH] Trivial, Ok->OK nit in mythfrontend

Index | Next | Previous | View Threaded

knight at teksavvy

Nov 1, 2009, 12:18 PM

Post #1 of 4 (689 views)
Permalink

Re: [mythtv-commits] Ticket #7475: [PATCH] Trivial, Ok->OK nit in mythfrontend

robertm wrote:
> Translations needing updates is not a valid reason to keep incorrect
> language/terminology. Discussion belongs on lists.
>

If we submit a patch that breaks the translation files for something as trivial as a
case change (or a typo) should we submit a patch for the translation files as well
(personally I would be tempted to do so).

I'm asking that question because I noticed when I worked on the patch I submitted in
ticket 7473 (http://svn.mythtv.org/trac/ticket/7473) that there are places where
British English (favourites) is used instead of American English (favorites) AFAIK**
when the rest of the application seems to use American English. There are also a few
places where I or friends noticed typos...

I did not submit a patch to the translation files in ticket 7473 because the string
was not initially translatable but I know there are other places where favourites is
used (and there are also place when favorites is used...).

Thank you,

Nick

** English is not my mother tongue so I could be wrong
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

robert.mcnamara at gmail

Nov 1, 2009, 12:25 PM

Post #2 of 4 (649 views)
Permalink

Re: [mythtv-commits] Ticket #7475: [PATCH] Trivial, Ok->OK nit in mythfrontend [In reply to]

On Sun, Nov 1, 2009 at 1:18 PM, Nicolas Riendeau <knight [at] teksavvy> wrote:
> robertm wrote:
>>
>> Translations needing updates is not a valid reason to keep incorrect
>> language/terminology. Discussion belongs on lists.
>>
>
> If we submit a patch that breaks the translation files for something as
> trivial as a case change (or a typo) should we submit a patch for the
> translation files as well (personally I would be tempted to do so).
>
> I'm asking that question because I noticed when I worked on the patch I
> submitted in ticket 7473 (http://svn.mythtv.org/trac/ticket/7473) that there
> are places where British English (favourites) is used instead of American
> English (favorites) AFAIK** when the rest of the application seems to use
> American English. There are also a few places where I or friends noticed
> typos...
>
> I did not submit a patch to the translation files in ticket 7473 because the
> string was not initially translatable but I know there are other places
> where favourites is used (and there are also place when favorites is
> used...).
>
> Thank you,
>
> Nick
>
>
> ** English is not my mother tongue so I could be wrong

Well, Reynaldo is working on many aspects of our translation stuff,
including imrpoving the method by which we generate translation
files-- there are always going to be numerous strings that get
changed/added/removed. If I was forced to write numerous
translations/etc. every time I fixed a string/changed a string/wrote a
new string, I would never get anything done. IMO the change doesn't
"break" translations, it just renders the current ones out of date.

And that's why we have translators/why we send out a call for
translations a month or two before release. :)

Robert

PS-- I think your mythgame patch is right-- we tend to err on the side
of American english, but the string should definitely be translatable.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

knight at teksavvy

Nov 1, 2009, 12:54 PM

Post #3 of 4 (647 views)
Permalink

Re: [mythtv-commits] Ticket #7475: [PATCH] Trivial, Ok->OK nit in mythfrontend [In reply to]

Hi Robert!

Robert McNamara wrote:
> If I was forced to write numerous
> translations/etc. every time I fixed a string/changed a string/wrote a
> new string, I would never get anything done.

Unless you fixed something very trivial (like case or a typo) you would not know what
to change in the translation files anyway... (-;

I guess the question should be: "Would a patch that fixed a case problem or a typo in
both the application and all the translation files as well be accepted?".

> IMO the change doesn't "break" translations, it just renders the current ones out of date.

Yep, you are right, "break" is too strong a word here...

> And that's why we have translators/why we send out a call for
> translations a month or two before release. :)

(-;

I am one of those translators... I am no longer working alone though, we are now a
team of four (all working on the same translation...). Some of the tickets I
submitted were actually fixes for problems reported by Gilles Choteau who works on
our team).

> Robert
>
> PS-- I think your mythgame patch is right--

Thanks!

> we tend to err on the side
> of American english, but the string should definitely be translatable.

We should prefer to use one over the other though if only for consistency sake... If
we take for example the word "favourite/favorite" using the correct syntax for both
the US and GB would require modifying both translation files currently...

Thank you very mich and have a nice day!

PS: Now if I can only get mtd/MythVideo to work correctly (it extracts but doesn't
insert the appropriate entries in the db) on my PC to test another one of my patches...
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

robert.mcnamara at gmail

Nov 1, 2009, 12:58 PM

Post #4 of 4 (654 views)
Permalink

Re: [mythtv-commits] Ticket #7475: [PATCH] Trivial, Ok->OK nit in mythfrontend [In reply to]

On Sun, Nov 1, 2009 at 1:54 PM, Nicolas Riendeau <knight [at] teksavvy> wrote:
> I guess the question should be: "Would a patch that fixed a case problem or
> a typo in both the application and all the translation files as well be
> accepted?".

When it's a patch that is mine to review? Absolutely! However, I
would also likely accept a change that fixes a spelling or case error
in the default string, knowing that the change would get picked up the
next time translators looked at it.

Robert
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads