Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] mythtv commit: r22134 by stuartm

Index | Next | Previous | View Threaded

simon at koala

Oct 1, 2009, 12:42 AM

Post #1 of 5 (808 views)
Permalink

Re: [mythtv-commits] mythtv commit: r22134 by stuartm

mythtv [at] cvs wrote:
> Author: stuartm
> Date: 2009-09-30 20:49:40 +0000 (Wed, 30 Sep 2009)
> New Revision: 22134
> Changeset: http://cvs.mythtv.org/trac/changeset/22134
>
> Modified:
>
> trunk/mythtv/libs/libmythui/mythfontproperties.cpp
>
> Log:
>
> Support specifying font size in pixels (height) alongside the traditional point system. This has some advantages: Themes are laid out using pixels to a fixed base size so it's easier to tell whether text is going to fit in the given area; Pixels are a finer unit of measure and allow for better fine tuning, plus when internally rescaling the units for a higher or lower resolution we lose less to rounding so text is less likely to be cut off.
>
did you just remove size:small and size:big?
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

robert.mcnamara at gmail

Oct 1, 2009, 12:48 AM

Post #2 of 5 (760 views)
Permalink

Re: [mythtv-commits] mythtv commit: r22134 by stuartm [In reply to]

On Thu, Oct 1, 2009 at 12:42 AM, Simon Kenyon <simon [at] koala> wrote:
> did you just remove size:small and size:big?

Yes, it was intentional. They weren't used in any themes, and were
deprecated artifacts of the old theming style, and they were difficult
to predict in terms of placing and size. The new <pixelsize> tag is
far more easy for themers to work withand it's much easier to tell
what size font will fit in what size textarea.

Robert
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

simon at koala

Oct 1, 2009, 12:53 AM

Post #3 of 5 (752 views)
Permalink

Re: [mythtv-commits] mythtv commit: r22134 by stuartm [In reply to]

Robert McNamara wrote:
> On Thu, Oct 1, 2009 at 12:42 AM, Simon Kenyon <simon [at] koala> wrote:
>
>> did you just remove size:small and size:big?
>>
>
> Yes, it was intentional. They weren't used in any themes, and were
> deprecated artifacts of the old theming style, and they were difficult
> to predict in terms of placing and size. The new <pixelsize> tag is
> far more easy for themers to work withand it's much easier to tell
> what size font will fit in what size textarea.
>
> Robert
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev [at] mythtv
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
>
maybe they are not used by the "core" themes - but there are others out
there which do use them

furthermore, you can change the font in the UI

i would ask that you consider adding them back
--
simon
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

Oct 1, 2009, 8:56 AM

Post #4 of 5 (738 views)
Permalink

Re: [mythtv-commits] mythtv commit: r22134 by stuartm [In reply to]

On 10/01/2009 03:53 AM, Simon Kenyon wrote:
> Robert McNamara wrote:
>> On Thu, Oct 1, 2009 at 12:42 AM, Simon Kenyon wrote:
>>> did you just remove size:small and size:big?
>> Yes, it was intentional. They weren't used in any themes, and were
>> deprecated artifacts of the old theming style, and they were difficult
>> to predict in terms of placing and size. The new <pixelsize> tag is
>> far more easy for themers to work withand it's much easier to tell
>> what size font will fit in what size textarea.
> maybe they are not used by the "core" themes - but there are others
> out there which do use them
>
> furthermore, you can change the font in the UI
>
> i would ask that you consider adding them back

Over the years with Myth, we've gotten a huge number of complaints/bug
reports from users that "Changing the font size has no effect." The
reason it had no effect is because the user chose a theme that did not
provide different values for default/big/small font sizes (meaning there
was only a default size). Also, to make it even more confusing, some
themes provided only default and small or default and big. Therefore,
unless we force all themes to contain default/small/big font definitions,

However, from a themer's perspective, properly supporting the
default/big/small font sizes means designing /and testing/ 3 screens for
every screen. Though this may sound like "only tripling" a themer's
work on a single theme, it's actually /much/ more than triple the work,
as the themer has to reload the theme for each font size change and then
verify the font/text placement/boundaries. Then, if anything needs
changed, it needs to be tested again in the other sizes. Also, because
of these issues, the small/big font layout is likely to get much less
attention than the default font and is likely to have many more issues.

IMHO, this is a waste of time for the themer. Designing a different
theme is a better approach--and likely to yield /significantly/ better
results overall, as the entire theme was designed specifically for the
text size used.

Mike

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

simon at koala

Oct 1, 2009, 11:43 AM

Post #5 of 5 (724 views)
Permalink

Re: [mythtv-commits] mythtv commit: r22134 by stuartm [In reply to]

Michael T. Dean wrote:
> On 10/01/2009 03:53 AM, Simon Kenyon wrote:
>> Robert McNamara wrote:
>>> On Thu, Oct 1, 2009 at 12:42 AM, Simon Kenyon wrote:
>>>> did you just remove size:small and size:big?
>>> Yes, it was intentional. They weren't used in any themes, and were
>>> deprecated artifacts of the old theming style, and they were difficult
>>> to predict in terms of placing and size. The new <pixelsize> tag is
>>> far more easy for themers to work withand it's much easier to tell
>>> what size font will fit in what size textarea.
>> maybe they are not used by the "core" themes - but there are others
>> out there which do use them
>>
>> furthermore, you can change the font in the UI
>>
>> i would ask that you consider adding them back
>
> Over the years with Myth, we've gotten a huge number of complaints/bug
> reports from users that "Changing the font size has no effect." The
> reason it had no effect is because the user chose a theme that did not
> provide different values for default/big/small font sizes (meaning
> there was only a default size). Also, to make it even more confusing,
> some themes provided only default and small or default and big.
> Therefore, unless we force all themes to contain default/small/big
> font definitions,
>
> However, from a themer's perspective, properly supporting the
> default/big/small font sizes means designing /and testing/ 3 screens
> for every screen. Though this may sound like "only tripling" a
> themer's work on a single theme, it's actually /much/ more than triple
> the work, as the themer has to reload the theme for each font size
> change and then verify the font/text placement/boundaries. Then, if
> anything needs changed, it needs to be tested again in the other
> sizes. Also, because of these issues, the small/big font layout is
> likely to get much less attention than the default font and is likely
> to have many more issues.
>
> IMHO, this is a waste of time for the themer. Designing a different
> theme is a better approach--and likely to yield /significantly/ better
> results overall, as the entire theme was designed specifically for the
> text size used.
the point really was that this was an incompatible change during a code
freeze
furthermore it was not announced as such

i can change my tiny little osd theme - so no big deal
--
simon
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads