Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] Ticket #7167: Check the return value of function calls inside of mythfrontend

 

 

MythTV dev RSS feed   Index | Next | Previous | View Threaded


mark at digivation

Sep 25, 2009, 4:33 PM

Post #1 of 2 (513 views)
Permalink
Re: [mythtv-commits] Ticket #7167: Check the return value of function calls inside of mythfrontend

> I'd sooner remove the return value of BuildFocusList() than add all those
> checks. The only time we return false would is when we're missing
> focusable widgets and that's perfectly valid if the screen works without
> them. If the screen doesn't work without them then it's a code error, the
> author has failed to check that the required widgets exist in the theme.
> So altogether it's redundant for BuildFocusList() to return any value at
> all.

can you put in a pragma or something so that it is flagged as catered for by
the scanning/check tool?

mark

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev


erik at hovland

Sep 25, 2009, 4:46 PM

Post #2 of 2 (460 views)
Permalink
Re: [mythtv-commits] Ticket #7167: Check the return value of function calls inside of mythfrontend [In reply to]

>> I'd sooner remove the return value of BuildFocusList() than add all those
>> checks. The only time we return false would is when we're missing
>> focusable widgets and that's perfectly valid if the screen works without
>> them. If the screen doesn't work without them then it's a code error, the
>> author has failed to check that the required widgets exist in the theme.
>> So altogether it's redundant for BuildFocusList() to return any value at
>> all.
>
> can you put in a pragma or something so that it is flagged as catered for by
> the scanning/check tool?

Don't do that. I can add annotations for the checker into my tree.

E

--
Erik Hovland
erik [at] hovland
http://hovland.org/
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

MythTV dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.