Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh

Index | Next | Previous | View Threaded

stuart at tase

Dec 9, 2007, 5:41 AM

Post #1 of 8 (1129 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh

On Sunday 09 December 2007 12:11:58 mythtv [at] cvs wrote:
> Like other part of Myth the miniplayer is fully themeable.

I've not tried theming it yet, but I noticed an issue with the default theme.
The x,y coords of the player container are 0,0 but the mini player is
appearing centred on screen, which suggests it's not honouring the theme
values?
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mythtv at dsl

Dec 9, 2007, 6:18 AM

Post #2 of 8 (1060 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

Stuart Morgan wrote:
> On Sunday 09 December 2007 12:11:58 mythtv [at] cvs wrote:
>
>> Like other part of Myth the miniplayer is fully themeable.
>>
>
> I've not tried theming it yet, but I noticed an issue with the default theme.
> The x,y coords of the player container are 0,0 but the mini player is
> appearing centred on screen, which suggests it's not honouring the theme
> values?
>

The player_container's area is just used to determine the size of the
popup window. The position of the popup is currently hardcoded to the
top center of the screen. There is already some code in there to change
the position to the bottom center or middle of the screen but since non
of the testers even queried the position of the popup I just left it
where it was (top center).

I could add a new value to the PlayerPosition enum MP_POSDESIGNED that
would place the popup player where the themer says but if I did that I
would insist on there being a new setting that allows the *user* to
chose where to put it =)

Paul H.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

stuart at tase

Dec 9, 2007, 6:44 AM

Post #3 of 8 (1057 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

On Sunday 09 December 2007 14:18:57 Paul Harrison wrote:
> The player_container's area is just used to determine the size of the
> popup window. The position of the popup is currently hardcoded to the
> top center of the screen. There is already some code in there to change
> the position to the bottom center or middle of the screen but since non
> of the testers even queried the position of the popup I just left it
> where it was (top center).

First, great work, really appreciate the time you've taken on this, it's a
frequently requested addition and should be very popular.

IMHO it should be themable (just as everything should). Using the container
area to determine the size of the dialog is fine, but it should honour the
x,y position too. I don't see the point in hardcoding any positioning options
in addition to having them in the theme.

> I could add a new value to the PlayerPosition enum MP_POSDESIGNED that
> would place the popup player where the themer says but if I did that I
> would insist on there being a new setting that allows the *user* to
> chose where to put it =)

Heh. I want to place it where I chose as a themer, that way it can be
integrated into the design. I don't really want the user overriding that and
why should they? They don't get the power to override the OSD and other
popups. If the themer wants the popup to appear into a particular bit of
empty space in their theme, or in a position where it matches other
theme-able popups (see mythvideo) then they should be able to do that. My
initial idea was to use a background image which gave the impression that the
player slid out from the side of the screen, that background wouldn't work in
the middle or on the wrong side.

There is at least one addition I'd like to see to the widgets available, the
progress slider. There may be others, but that's the one I'd particularly
want for my theme. I can add this one though, if you don't want the work.

I'd _like_ to display the volume, but I don't want to waste space on the track
bitrate etc. If a separate volume textarea were available as an alternative
to the info area, that would be great but I can live without displaying the
volume.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

stuart at tase

Dec 9, 2007, 7:05 AM

Post #4 of 8 (1059 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

Well I've messed about with a couple of theme ideas and this is the one I'm
probably going to stick with, it's just missing the progress bar which would
be above the times.

http://www.miffteevee.co.uk/imagebin/mythmusic_miniplayer.png

It echos the OSD theme -
http://www.miffteevee.co.uk/themes/metallurgy.html#OSD

It works OK at the top of the screen, but that's not the point.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

stuart at tase

Dec 9, 2007, 7:44 AM

Post #5 of 8 (1068 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

On Sunday 09 December 2007 15:05:02 Stuart Morgan wrote:
> Well I've messed about with a couple of theme ideas and this is the one I'm
> probably going to stick with, it's just missing the progress bar which
> would be above the times.
>
> http://www.miffteevee.co.uk/imagebin/mythmusic_miniplayer.png
>
> It echos the OSD theme -
> http://www.miffteevee.co.uk/themes/metallurgy.html#OSD
>
> It works OK at the top of the screen, but that's not the point.

This is quick mockup of my original idea and is more in keeping with the rest
of the UI. It illustrates the potential problem with users picking where they
want the miniplayer.

http://www.miffteevee.co.uk/imagebin/mythmusic_miniplayer2.png
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mythtv at dsl

Dec 9, 2007, 7:57 AM

Post #6 of 8 (1060 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

Stuart Morgan wrote:
> On Sunday 09 December 2007 14:18:57 Paul Harrison wrote:
>
>> I could add a new value to the PlayerPosition enum MP_POSDESIGNED that
>> would place the popup player where the themer says but if I did that I
>> would insist on there being a new setting that allows the *user* to
>> chose where to put it =)
>>
>
> Heh. I want to place it where I chose as a themer, that way it can be
> integrated into the design. I don't really want the user overriding that and
> why should they? They don't get the power to override the OSD and other
> popups. If the themer wants the popup to appear into a particular bit of
> empty space in their theme, or in a position where it matches other
> theme-able popups (see mythvideo) then they should be able to do that. My
> initial idea was to use a background image which gave the impression that the
> player slid out from the side of the screen, that background wouldn't work in
> the middle or on the wrong side.
>
>
Which side are you on now the devs or the themers? I think you are
slowly turning over to the dark side ;-)

What the hell I'll just change it to use the themed position. If the
user doesn't like it it's only a matter of editing the theme file.

> There is at least one addition I'd like to see to the widgets available, the
> progress slider. There may be others, but that's the one I'd particularly
> want for my theme. I can add this one though, if you don't want the work.
>
>
I'll take a look at adding this - need to find a theme that uses the
progress slider stuff first.

> I'd _like_ to display the volume, but I don't want to waste space on the track
> bitrate etc. If a separate volume textarea were available as an alternative
> to the info area, that would be great but I can live without displaying the
> volume.
>

The info area does switch to show the volume for a few seconds when it's
changed but you want a text area that shows the volume all the time is
that correct? If it's an optional item then I have no problems with that.

Paul H.

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mythtv at dsl

Dec 9, 2007, 8:02 AM

Post #7 of 8 (1065 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

Stuart Morgan wrote:
> On Sunday 09 December 2007 15:05:02 Stuart Morgan wrote:
>
>> Well I've messed about with a couple of theme ideas and this is the one I'm
>> probably going to stick with, it's just missing the progress bar which
>> would be above the times.
>>
>> http://www.miffteevee.co.uk/imagebin/mythmusic_miniplayer.png
>>
>> It echos the OSD theme -
>> http://www.miffteevee.co.uk/themes/metallurgy.html#OSD
>>
>> It works OK at the top of the screen, but that's not the point.
>>
>
> This is quick mockup of my original idea and is more in keeping with the rest
> of the UI. It illustrates the potential problem with users picking where they
> want the miniplayer.
>
> http://www.miffteevee.co.uk/imagebin/mythmusic_miniplayer2.png
>

Yep looks good - I'll change it so the position is theme-able :-)

BTW your theme is looking really smart. Best I've seen yet I would say.

Paul H.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

stuart at tase

Dec 9, 2007, 8:45 AM

Post #8 of 8 (1051 views)
Permalink

Re: [mythtv-commits] mythtv commit: r15091 - in trunk/mythplugins/mythmusic/mythmusic by paulh [In reply to]

On Sunday 09 December 2007 15:57:29 Paul Harrison wrote:
> Which side are you on now the devs or the themers? I think you are
> slowly turning over to the dark side ;-)

Lets just say that I've gained an insight into the problems that themers face.
Turning a vision into reality with some of the current idiosyncrasies of the
code can be very hard. It's no wonder that most of the themes in existence
look identical to each other except for their colour schemes.

It's something that a general UI code cleanup and mythui should make easier
for everyone, both themers and developers.

> What the hell I'll just change it to use the themed position. If the
> user doesn't like it it's only a matter of editing the theme file.

Thanks.

> > There is at least one addition I'd like to see to the widgets available,
> > the progress slider. There may be others, but that's the one I'd
> > particularly want for my theme. I can add this one though, if you don't
> > want the work.
>
> I'll take a look at adding this - need to find a theme that uses the
> progress slider stuff first.

Justin's themes, at least blootube-wide and I think neon use it. The one I'm
working on now does as well -
http://www.miffteevee.co.uk/themes/metallurgy.html

> > I'd _like_ to display the volume, but I don't want to waste space on the
> > track bitrate etc. If a separate volume textarea were available as an
> > alternative to the info area, that would be great but I can live without
> > displaying the volume.
>
> The info area does switch to show the volume for a few seconds when it's
> changed but you want a text area that shows the volume all the time is
> that correct? If it's an optional item then I have no problems with that.

That's what I had in mind. It isn't that important but having options is
always nice. Speaking personally, I don't think the bitrate is important
information when you are just playing music. I've left it out of my mythmusic
theme so I can give space to other things. I was eventually going to make
that information accessible as part of the metadata editor, similar to the
playcount and last modified date.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads