Mailing List Archive: MythTV: Dev

Re: Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset()

Index | Next | Previous | View Threaded

danielk at cuymedia

Sep 18, 2007, 12:25 PM

Post #1 of 4 (336 views)
Permalink

Re: Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset()

On Tue, 2007-09-18 at 12:11 -0400, Shane wrote:
> On 9/17/07, MythTV <mythtv[at]cvs.mythtv.org> wrote:
> > #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset()
> > ------------------------------------------------+---------------------------
> > Reporter: Shane Shrybman <gnome42[at]gmail.com> | Owner: danielk
> > Type: defect | Status: new
> > Priority: minor | Milestone: unknown
> > Component: mythtv | Version: head
> > Severity: medium | Resolution:
> > Mlocked: 0 |
> > ------------------------------------------------+---------------------------
>
> NVR/mpeg recorders:
>
> ResetForNewFile() ->
> reset some variables
> positionMap.clear()
> positionMapDelta.clear()

This is what we should be doing.

> So, is the better solution to try and make the Reset/ResetForNewFile()
> more consistent across recorders? or My first patch for this problem
> was to move the call to ResetForNewFile() in
> RecorderBase::CheckForRingBufferSwitch(void) until after the
> curRecording is changed to the new one so that we don't blow away the
> position map for the last file.

I think the reason we don't do the reset this way in the DVB recorder
is because it doesn't have a functional Pause()/Unpause() like the NVR
does. But we I believe I fixed this in the multirec branch, so the
NVR ResetForNewFile() method would be safe with the DVB recorder in
the multirec branch.

-- Daniel

_______________________________________________
mythtv-dev mailing list
mythtv-dev[at]mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

gnome42 at gmail

Sep 19, 2007, 8:19 AM

Post #2 of 4 (306 views)
Permalink

Re: Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset() [In reply to]

On 9/18/07, Daniel Kristjansson <danielk[at]cuymedia.net> wrote:
...
> > NVR/mpeg recorders:
> >
> > ResetForNewFile() ->
> > reset some variables
> > positionMap.clear()
> > positionMapDelta.clear()
>
> This is what we should be doing.

Ok

> I think the reason we don't do the reset this way in the DVB recorder
> is because it doesn't have a functional Pause()/Unpause() like the NVR
> does. But we I believe I fixed this in the multirec branch, so the
> NVR ResetForNewFile() method would be safe with the DVB recorder in
> the multirec branch.

Ok, cool. Here is a patch for multirec that implements
ResetForNewFile() for dvbrecorders. Attempts to be like NVR. :)

Seems to behave pretty well here in quick testing.

Shane

Attachments:

mythtv_multirec_dvbrec_ResetForNewFile.diff (1.10 KB)

danielk at cuymedia

Sep 19, 2007, 8:53 AM

Post #3 of 4 (307 views)
Permalink

Re: Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset() [In reply to]

On Wed, 2007-09-19 at 11:19 -0400, Shane wrote:
> On 9/18/07, Daniel Kristjansson <danielk[at]cuymedia.net> wrote:
> ...
> > > NVR/mpeg recorders:
> > >
> > > ResetForNewFile() ->
> > > reset some variables
> > > positionMap.clear()
> > > positionMapDelta.clear()
> >
> > This is what we should be doing.
>
> Ok
>
> > I think the reason we don't do the reset this way in the DVB recorder
> > is because it doesn't have a functional Pause()/Unpause() like the NVR
> > does. But we I believe I fixed this in the multirec branch, so the
> > NVR ResetForNewFile() method would be safe with the DVB recorder in
> > the multirec branch.
>
> Ok, cool. Here is a patch for multirec that implements
> ResetForNewFile() for dvbrecorders. Attempts to be like NVR. :)
>
> Seems to behave pretty well here in quick testing.

I made a little change to this and attached the patch to the ticket.
I want to address all the DTVRecorder based recorders, not just
DVBRecorder in the fix. It's not tested, but in theory should work.

-- Daniel

_______________________________________________
mythtv-dev mailing list
mythtv-dev[at]mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

gnome42 at gmail

Sep 19, 2007, 10:02 AM

Post #4 of 4 (305 views)
Permalink

Re: Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset() [In reply to]

On 9/19/07, Daniel Kristjansson <danielk[at]cuymedia.net> wrote:
...
> I made a little change to this and attached the patch to the ticket.
> I want to address all the DTVRecorder based recorders, not just
> DVBRecorder in the fix. It's not tested, but in theory should work.

Great, thanks! I'm trying it out now and it seems to be good so far.

Shane
_______________________________________________
mythtv-dev mailing list
mythtv-dev[at]mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com