Mailing List Archive: MythTV: Dev

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's

Index | Next | Previous | View Threaded

stuart at tase

Jun 7, 2007, 2:25 AM

Post #1 of 9 (1055 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's

On Wednesday 06 June 2007 22:08:25 MythTV wrote:
> #3363: TranslateKeyPress: prefer local action over jump point's
> -----------------------+---------------------------------------------------
>- Reporter: anonymous | Owner: stuartm
> Type: patch | Status: new
> Priority: minor | Milestone: unknown
> Component: mythtv | Version: unknown
> Severity: medium | Resolution:
> -----------------------+---------------------------------------------------
>
> The attached patch changes MythMainWindow::TranslateKeyPress? to prefer the
> local context's action for a keypress over the global "jump points" action.
>

I'd personally benefit from this change. Like others I want the guide button
on my remote to bring up the livetv guide when in livetv, and the scheduling
guide everywhere else.

Are there any objections to this change?

The one problem I know that it will cause is breaking a minority of people's
remote setups. That might be avoided by a adding a database update which
deletes keys which have also been defined as jumppoints from the contextual
keybindings, but this is probably more effort than it's worth.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ylee at pobox

Jun 8, 2007, 1:04 AM

Post #2 of 9 (1002 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

Stuart Morgan <stuart [at] tase> says:
> I'd personally benefit from this change. Like others I want the guide button
> on my remote to bring up the livetv guide when in livetv, and the scheduling
> guide everywhere else.
>
> Are there any objections to this change?

On the contrary, this is a long-overdue and very welcome commit which
moves MythTV one more step toward the "works the way one would figure
it should work" stage. Thanks to John Poet for filing the ticket and
to you for reviewing and preparing to commit it.

--
Yeechang Lee <ylee [at] pobox> | +1 650 776 7763 | San Francisco CA US
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

roo.watt at gmail

Jun 9, 2007, 10:28 PM

Post #3 of 9 (1003 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

On 09/06/07, MythTV <mythtv [at] cvs> wrote:
> #3363: TranslateKeyPress: prefer local action over jump point's
> -----------------------+----------------------------------------------------
> Reporter: anonymous | Owner: stuartm
> Type: patch | Status: closed
> Priority: minor | Milestone: unknown
> Component: mythtv | Version: unknown
> Severity: medium | Resolution: fixed
> -----------------------+----------------------------------------------------
>
> Comment(by stuartm):
>
> (In [13615]) Reverts [13614] refs #3363 (Reverse order in which jumppoints
> and keybindings are handled)
>
> Specific fixes to handle the situations where a jumppoint should be
> context sensitive. E.g. The Guide jumppoint in livetv would be preferred.
>
> Please keep any discussion in the mailing list and don't re-open #3363

I have resync to trunk and I am seeing unexpected behaviour in
relation to the "Live TV Guide" local context and jumpoint "Program
Guide".

If I have the program guide jumpoint bound to "S" and the program
guide in live tv bound to "S" as well things don't work as expected.

* If I am in a context other than Live TV (Tv Playback) the "S" does
jump to the expected scheduler program guide.

* If I am watching live tv and hit the "S" I see a quick flash of the
Live TV guide (I can see the video box show in the top right corner)
then it jumps to the scheduler program guide instead.

I understood the original patch to reorder the keybindings to the following:

High Priority: Local Bindings ->
Medium Prority: Global Bindings ->
Low Priority: Jump Points

Upon re-reading Stuart's comment about specific fixes, does he mean
that he has backed out the changes?

Is he waiting on patches to fix the specific issues of global
jumpoints colliding with local contexts? Instead of the general "local
overrides global" fix?

Cheers,

Roo.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

Jun 10, 2007, 5:30 AM

Post #4 of 9 (987 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

On 06/10/2007 01:28 AM, Roo wrote:
> On 09/06/07, MythTV <mythtv [at] cvs> wrote:
>
>> #3363: TranslateKeyPress: prefer local action over jump point's
>>
>> Comment(by stuartm):
>>
>> (In [13615]) Reverts [13614] refs #3363 (Reverse order in which jumppoints
>> and keybindings are handled)
>>
>> Specific fixes to handle the situations where a jumppoint should be
>> context sensitive. E.g. The Guide jumppoint in livetv would be preferred.
>>
>> Please keep any discussion in the mailing list and don't re-open #3363
>>
>
> I have resync to trunk and I am seeing unexpected behaviour in
> relation to the "Live TV Guide" local context and jumpoint "Program
> Guide".
>
> If I have the program guide jumpoint bound to "S" and the program
> guide in live tv bound to "S" as well things don't work as expected.
>
> * If I am in a context other than Live TV (Tv Playback) the "S" does
> jump to the expected scheduler program guide.
>
> * If I am watching live tv and hit the "S" I see a quick flash of the
> Live TV guide (I can see the video box show in the top right corner)
> then it jumps to the scheduler program guide instead.
>
> I understood the original patch to reorder the keybindings to the following:
>
> High Priority: Local Bindings ->
> Medium Prority: Global Bindings ->
> Low Priority: Jump Points
>
> Upon re-reading Stuart's comment about specific fixes, does he mean
> that he has backed out the changes?
>

Yes. The program guide jump point should be fixed directly by writing
code to handle the jump point more reasonably in LiveTV (i.e. by going
to the LiveTV program guide if the user is in LiveTV. So, feel free to
write up a patch for the jumppoint.

> Is he waiting on patches to fix the specific issues of global
> jumpoints colliding with local contexts? Instead of the general "local
> overrides global" fix?

See http://www.gossamer-threads.com/lists/mythtv/dev/266483#266483 .

AIUI, JumpPoints will--by design--always take precedence over
keybindings. In the event that a jumppoint does something "unexpected"
in some context, the jumppoint should be fixed. This will ensure that
no matter where you're at, certain keys (those bound to jumppoints)
always result in the same behavior without forcing the user to verify
that no keybinding collides with a jumppoint binding.

Also, using the subcontext patch that John (and David) are working on,
you will have the ability to do the types of things most users want when
they bind the same key for use in multiple places. So, basically, the
patch that's described in the post to which I linked will likely be
committed rather than the "prefer local keybindings" patch.

Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

roo.watt at gmail

Jun 10, 2007, 6:09 AM

Post #5 of 9 (991 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

On 10/06/07, Michael T. Dean <mtdean [at] thirdcontact> wrote:
> Yes. The program guide jump point should be fixed directly by writing
> code to handle the jump point more reasonably in LiveTV (i.e. by going
> to the LiveTV program guide if the user is in LiveTV. So, feel free to
> write up a patch for the jumppoint.

Mike, thanks for the reply, I will have a look at writing the patch as
this is a feature that I want.

Is there more Jump points that need to be fixed in addition to the LiveTV/Guide?

>
> > Is he waiting on patches to fix the specific issues of global
> > jumpoints colliding with local contexts? Instead of the general "local
> > overrides global" fix?
>
> See http://www.gossamer-threads.com/lists/mythtv/dev/266483#266483 .
>
> AIUI, JumpPoints will--by design--always take precedence over
> keybindings. In the event that a jumppoint does something "unexpected"
> in some context, the jumppoint should be fixed. This will ensure that
> no matter where you're at, certain keys (those bound to jumppoints)
> always result in the same behavior without forcing the user to verify
> that no keybinding collides with a jumppoint binding.

I guess I should have realised that as I did contribute in that thread

:)

Roo.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mtdean at thirdcontact

Jun 10, 2007, 10:01 AM

Post #6 of 9 (996 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

On 06/10/2007 09:09 AM, Roo wrote:
> On 10/06/07, Michael T. Dean <mtdean [at] thirdcontact> wrote:
>
>> Yes. The program guide jump point should be fixed directly by writing
>> code to handle the jump point more reasonably in LiveTV (i.e. by going
>> to the LiveTV program guide if the user is in LiveTV. So, feel free to
>> write up a patch for the jumppoint.
>>
> Mike, thanks for the reply, I will have a look at writing the patch as
> this is a feature that I want.
>
> Is there more Jump points that need to be fixed in addition to the LiveTV/Guide?
>

That's a very good question. No one volunteered any other examples when
discussing it on IRC (which I took to mean no one could think of any
other examples). That's part of the reason that fixing the jump point
was determined to be the proper way of fixing the issue.

If anyone else can think of places where a jumppoint seems to do the
wrong thing in certain contexts, now would be a great time to mention
it. Mentioning it now may mean someone (like Roo ;) may write the patch
for you. Waiting to mention it may mean the person who mentions it will
need to write the patch.

Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Jun 10, 2007, 11:24 AM

Post #7 of 9 (1008 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

* On Sun Jun 10, 2007 at 01:01:05PM -0400, Michael T. Dean wrote:
> That's a very good question. No one volunteered any other examples when
> discussing it on IRC (which I took to mean no one could think of any
> other examples). That's part of the reason that fixing the jump point
> was determined to be the proper way of fixing the issue.

It is possible to bring up the Program Guide and Program Finder during
playback of a normal recording as well, so these should take precendence
over the normal jumppoints during any playback, not just LiveTV.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ylee at pobox

Jun 11, 2007, 9:39 AM

Post #8 of 9 (997 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

Michael T. Dean <mtdean [at] thirdcontact> says:
> If anyone else can think of places where a jumppoint seems to do the
> wrong thing in certain contexts, now would be a great time to
> mention it.

I'd still prefer the generic prefer-local-to-global patch to a
specific approach, but since that isn't in the cards at the moment
(Why was that reverted, anyway?), as Chris mentioned, the Jumppoints
for Program Guide and Program Finder should call the special
put-playback-on-pause-and-permit-return-to-playback versions of these
screens when in any playback mode, not just Live TV. I've been using
John Poet's patch
(<URL:http://www.gossamer-threads.com/lists/mythtv/users/232375#232375>),
which does work this way, for so long that I didn't realize the
current approach didn't already act this way.

Other than that, though, I can't think of anything, in part because
the above are the only two such special versions of mythfrontend
screens that currently exist. (I'd love Upcoming Recordings and System
Status to also be able to act in this way, by the way.)

Once the jumppoint rewiring is done, shouldn't the "M" and "#" keys be
deleted? I can't think of any situation that one would, while watching
Live TV or a recording, want to be able to bring up both the
non-special and special versions of Program Guide or Program Finder,
so one Jumppoint key for each should suffice in all circumstances.

--
Yeechang Lee <ylee [at] pobox> | +1 650 776 7763 | San Francisco CA US
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

roo.watt at gmail

Jun 23, 2007, 8:09 AM

Post #9 of 9 (941 views)
Permalink

Re: [mythtv-commits] Ticket #3363: TranslateKeyPress: prefer local action over jump point's [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads