Mailing List Archive: MythTV: Dev

Re: [13168] and [13170] Reducing reschedules

Index | Next | Previous | View Threaded

gnome42 at gmail

Apr 3, 2007, 8:52 AM

Post #1 of 6 (698 views)
Permalink

Re: [13168] and [13170] Reducing reschedules

Hi,

I encounter the bug this changeset is trying to fix so it is great to
see a solution but, IMVHO it would also be nice to minimize the
reschedules, especially right around record start/end time since it is
already a very busy time.

Might it be possible to only cause this reschedule to occur if
!livetv and maxepisodes is in use? And possibly a delay before the
schedule so that it doesn't happen right at start/end time?

I noticed the UsesMaxEpisodes() function that seems like it could be
handy here. eg.

if (recgroup != "LiveTV" && UsesMaxEpisodes())
ScheduledRecording::signalChange(0);

And 'maxnewest' could be incorporated into UsesMaxEpisodes() as well if needed.

Regards,

Shane
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Apr 3, 2007, 12:28 PM

Post #2 of 6 (668 views)
Permalink

Re: [13168] and [13170] Reducing reschedules [In reply to]

* On Tue Apr 03, 2007 at 11:52:47AM -0400, Gnome42 wrote:
> I encounter the bug this changeset is trying to fix so it is great to
> see a solution but, IMVHO it would also be nice to minimize the
> reschedules, especially right around record start/end time since it is
> already a very busy time.

This is probably going to get moved into the scheduler anyway. David
emailed me off-list about this after my commit and mentioned that if
we put this check in the scheduler we won't have to do the LiveTV check.

I can probably agree about the maxepisodes check if this is the only
reason we are doing the reschedule.

My scheduler experience is also a little rusty, but I think we only need
to reschedule for the specific recordid also, instead of everything.

David is looking at it though, so hopefully he'll see this thread.

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

bjm at lvcm

Apr 3, 2007, 2:21 PM

Post #3 of 6 (656 views)
Permalink

Re: [13168] and [13170] Reducing reschedules [In reply to]

Chris Pinkham wrote:
...
> My scheduler experience is also a little rusty, but I think we only need
> to reschedule for the specific recordid also, instead of everything.

No worries. It's set to signalChange(0). "0" means that no
rules need to rematch for showings in the program table. If
there is a recordid then rematch that rule only and -1 means
to rematch everything. This event doesn't change the rule or
the listings so 0 is correct.

-- bjm

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

gnome42 at gmail

Apr 3, 2007, 4:55 PM

Post #4 of 6 (664 views)
Permalink

Re: [13168] and [13170] Reducing reschedules [In reply to]

> This is probably going to get moved into the scheduler anyway. David
> emailed me off-list about this after my commit and mentioned that if
> we put this check in the scheduler we won't have to do the LiveTV check.

Ok, that sounds even better. Thanks Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

cpinkham at bc2va

Apr 3, 2007, 6:46 PM

Post #5 of 6 (663 views)
Permalink

Re: [13168] and [13170] Reducing reschedules [In reply to]

* On Tue Apr 03, 2007 at 07:55:55PM -0400, Gnome42 wrote:
> > This is probably going to get moved into the scheduler anyway. David
> > emailed me off-list about this after my commit and mentioned that if
> > we put this check in the scheduler we won't have to do the LiveTV check.
>
> Ok, that sounds even better. Thanks Chris

Actually I misunderstood him about the exact location, but we're still
discussing it off-list. :( then :)

--
Chris
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

david at istwok

Apr 3, 2007, 7:40 PM

Post #6 of 6 (647 views)
Permalink

Re: [13168] and [13170] Reducing reschedules [In reply to]

On Tue, Apr 03, 2007 at 09:46:20PM -0400, Chris Pinkham wrote:
> Actually I misunderstood him about the exact location, but we're still
> discussing it off-list. :( then :)

Yes, Chris pointed out to me the reschedule request could be done from
within the scheduler itself instead of round about through the
recorder. The main thing is the reschedule must occur *after* the new
recorded table entry is created, so I put it immediately after to be
sure.

That still leaves the case where reschedules will occur more often
than strictly necessasy. For the particular bug I was fixing, the
reschedule only needs to be done if maxepisodes > 0 and maxnewest ==
0. Unfortunatly, that information is not readily available when a
recording is actually started. I'll see what it would take to make it
available.

A completely different approach I've briefly considered in the past is
to have the scheduler count recordings as things are placed in the
schedule. The scheduler would then stop setting programs for a maxxed
out recordid to rsWillRecord in mid-run. That leads to other
problems, though, so I've always discarded this approach.

David
--
David Engel
david [at] istwok
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads