Mailing List Archive: MythTV: Dev

Change 8403 breaks the build

Index | Next | Previous | View Threaded

bolek-mythtv at curl

Dec 27, 2005, 7:38 PM

Post #1 of 6 (691 views)
Permalink

Change 8403 breaks the build

exitcodes.h is missing and checksetup.cpp is not being built (this is on
0.18.x branch).

Bolek

_______________________________________________
mythtv-dev mailing list
mythtv-dev[at]mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

jarod at wilsonet

Dec 27, 2005, 8:02 PM

Post #2 of 6 (683 views)
Permalink

Re: Change 8403 breaks the build [In reply to]

On Tuesday 27 December 2005 19:38, Boleslaw Ciesielski wrote:
> exitcodes.h is missing and checksetup.cpp is not being built (this is on
> 0.18.x branch).

Should be okay now.

--
Jarod Wilson
jarod[at]wilsonet.com

nigel at ind

Dec 27, 2005, 9:03 PM

Post #3 of 6 (680 views)
Permalink

Re: Change 8403 breaks the build [In reply to]

> On Tuesday 27 December 2005 19:38, Boleslaw Ciesielski wrote:
>> exitcodes.h is missing and checksetup.cpp is not being built (this is
>> on
>> 0.18.x branch).
>
> Should be okay now.

Not quite, checksetup still isn't in the makefile.

It looks like this won't be simple to add, after all.
checksetup.cpp needs an updated util.cpp and util.h,
which needs mythconfig.h, which probably needs an updated
configure, which is all getting too hard.

These:

/trunk/mythtv/libs/libmyth/util.cpp?rev=6966
/trunk/mythtv/libs/libmyth/util.h?rev=6482
/trunk/mythtv/setup/setup.pro?rev=6798

with a minor patch to util.cpp:

// Myth headers
- #include "mythconfig.h"
+ #include "../../config.h"

should do the trick, but a hack just for this
feature probably isn't the way forward.
Sorry for this extra hassle -
I thought this would be a simple fix to add in!

--
Nigel Pearson, nigel[at]ind.tansu.com.au | "Reality is that which,
Telstra Dev. Lab, Sydney, Australia | when you stop believing
Office: 9814 4803 Fax: 9814 4897 | in it, doesn't go away."
Mobile: 0408 664435 Home: 9792 6998 | Philip K. Dick - 'Valis'

jarod at wilsonet

Dec 27, 2005, 9:36 PM

Post #4 of 6 (674 views)
Permalink

Re: Change 8403 breaks the build [In reply to]

On Tuesday 27 December 2005 21:03, Nigel Pearson wrote:
> > On Tuesday 27 December 2005 19:38, Boleslaw Ciesielski wrote:
> >> exitcodes.h is missing and checksetup.cpp is not being built (this is
> >> on
> >> 0.18.x branch).
> >
> > Should be okay now.
>
> Not quite, checksetup still isn't in the makefile.
>
> It looks like this won't be simple to add, after all.
> checksetup.cpp needs an updated util.cpp and util.h,
> which needs mythconfig.h, which probably needs an updated
> configure, which is all getting too hard.
>
>
> These:
>
> /trunk/mythtv/libs/libmyth/util.cpp?rev=6966
> /trunk/mythtv/libs/libmyth/util.h?rev=6482
> /trunk/mythtv/setup/setup.pro?rev=6798
>
> with a minor patch to util.cpp:
>
> // Myth headers
> - #include "mythconfig.h"
> + #include "../../config.h"
>
> should do the trick, but a hack just for this
> feature probably isn't the way forward.
> Sorry for this extra hassle -
> I thought this would be a simple fix to add in!

All patched up, but building locally this time _before_ I check in. :)

If we run into too much more, might be time to roll back to pre-8403 versions
and can this feature, but where's the fun in that? ;)

--
Jarod Wilson
jarod[at]wilsonet.com

jarod at wilsonet

Dec 27, 2005, 9:59 PM

Post #5 of 6 (672 views)
Permalink

Re: Change 8403 breaks the build [In reply to]

On Tuesday 27 December 2005 21:36, Jarod Wilson wrote:
> On Tuesday 27 December 2005 21:03, Nigel Pearson wrote:
> > > On Tuesday 27 December 2005 19:38, Boleslaw Ciesielski wrote:
> > >> exitcodes.h is missing and checksetup.cpp is not being built (this is
> > >> on 0.18.x branch).
> > >
> > > Should be okay now.
> >
> > Not quite, checksetup still isn't in the makefile.
> >
> > It looks like this won't be simple to add, after all.
> > checksetup.cpp needs an updated util.cpp and util.h,
> > which needs mythconfig.h, which probably needs an updated
> > configure, which is all getting too hard.
> >
> >
> > These:
> >
> > /trunk/mythtv/libs/libmyth/util.cpp?rev=6966
> > /trunk/mythtv/libs/libmyth/util.h?rev=6482
> > /trunk/mythtv/setup/setup.pro?rev=6798
> >
> > with a minor patch to util.cpp:
> >
> > // Myth headers
> > - #include "mythconfig.h"
> > + #include "../../config.h"
> >
> > should do the trick, but a hack just for this
> > feature probably isn't the way forward.
> > Sorry for this extra hassle -
> > I thought this would be a simple fix to add in!
>
> All patched up, but building locally this time _before_ I check in. :)
>
> If we run into too much more, might be time to roll back to pre-8403
> versions and can this feature, but where's the fun in that? ;)

Well, this cascades into programs/mythfrontend/statusbox.cpp:

statusbox.cpp: In function 'const QString diskUsageStr(const char*)':
statusbox.cpp:932: error: 'diskUsage' was not declared in this scope
statusbox.cpp:936: warning: control reaches end of non-void function

Just brought over trunk rev 6834, we'll see what that does...

--
Jarod Wilson
jarod[at]wilsonet.com

jarod at wilsonet

Dec 27, 2005, 10:11 PM

Post #6 of 6 (677 views)
Permalink

Re: Change 8403 breaks the build [In reply to]

On Tuesday 27 December 2005 21:36, Jarod Wilson wrote:
> On Tuesday 27 December 2005 21:03, Nigel Pearson wrote:
> > > On Tuesday 27 December 2005 19:38, Boleslaw Ciesielski wrote:
> > >> exitcodes.h is missing and checksetup.cpp is not being built (this is
> > >> on
> > >> 0.18.x branch).
> > >
> > > Should be okay now.
> >
> > Not quite, checksetup still isn't in the makefile.
> >
> > It looks like this won't be simple to add, after all.
> > checksetup.cpp needs an updated util.cpp and util.h,
> > which needs mythconfig.h, which probably needs an updated
> > configure, which is all getting too hard.
> >
> >
> > These:
> >
> > /trunk/mythtv/libs/libmyth/util.cpp?rev=6966
> > /trunk/mythtv/libs/libmyth/util.h?rev=6482
> > /trunk/mythtv/setup/setup.pro?rev=6798
> >
> > with a minor patch to util.cpp:
> >
> > // Myth headers
> > - #include "mythconfig.h"
> > + #include "../../config.h"
> >
> > should do the trick, but a hack just for this
> > feature probably isn't the way forward.
> > Sorry for this extra hassle -
> > I thought this would be a simple fix to add in!
>
> All patched up, but building locally this time _before_ I check in. :)
>
> If we run into too much more, might be time to roll back to pre-8403
> versions and can this feature, but where's the fun in that? ;)

Okay, I surrender, way too many files getting touched, rolled back the
changes. Sorry for being a dumb-ass and checking in stuff before making sure
it still compiles and runs... :O

--
Jarod Wilson
jarod[at]wilsonet.com

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com