Mailing List Archive: MythTV: Dev

[PATCH] savesetting arse about fix

Index | Next | Previous | View Threaded

mark at dclabs

May 13, 2005, 10:17 PM

Post #1 of 4 (663 views)
Permalink

[PATCH] savesetting arse about fix

this patch corrects savesettings saving host in data field and data in host field
dont know how this could have come about as the function it uses is __right__ below.
I was wondering why my xv settings werent getting saved =)
cheers
mark

Attachments:

mythtv_savesettings.patch (0.64 KB)

ijr at case

May 13, 2005, 10:23 PM

Post #2 of 4 (655 views)
Permalink

Re: [PATCH] savesetting arse about fix [In reply to]

On Saturday 14 May 2005 01:17 am, Mark Spieth wrote:
> this patch corrects savesettings saving host in data field and data in host
> field dont know how this could have come about as the function it uses is
> __right__ below. I was wondering why my xv settings werent getting saved =)

Hah. Whoops. I'm going to fix it by flipping the SaveSettingOnHost values,
as that's really the wrong ordering.

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

mark at dclabs

May 13, 2005, 10:29 PM

Post #3 of 4 (640 views)
Permalink

Re: [PATCH] savesetting arse about fix [In reply to]

> Hah. Whoops. I'm going to fix it by flipping the SaveSettingOnHost
values,
> as that's really the wrong ordering.

only reason I used that order is due to the GetNumSettingsOnHost which has
key,host,defval order.
make them the same (roughly)
cheers
mark

_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ijr at case

May 13, 2005, 10:33 PM

Post #4 of 4 (648 views)
Permalink

Re: [PATCH] savesetting arse about fix [In reply to]

On Saturday 14 May 2005 01:29 am, Mark Spieth wrote:
> > Hah. Whoops. I'm going to fix it by flipping the SaveSettingOnHost
>
> values,
>
> > as that's really the wrong ordering.
>
> only reason I used that order is due to the GetNumSettingsOnHost which has
> key,host,defval order.
> make them the same (roughly)

Right, but, ah, too late. =)

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads