Mailing List Archive: MythTV: Dev

[PATCH] Change LoadTheme to fallback to default theme file ...

Index | Next | Previous | View Threaded

mythtv at dsl

Apr 5, 2005, 10:41 AM

Post #1 of 4 (1186 views)
Permalink

[PATCH] Change LoadTheme to fallback to default theme file ...

... if a window definition cannot be found in the current theme.

This patch gives XMLParse::LoadTheme() a second chance at finding
a window definition by looking in the default theme file if it can't be
found in the current theme file.

This is useful for devs because they only have to add a window definition to
the default theme file for a plugin and not have to worry about updating all
the theme files. If theme designers want to they can always override it by
adding a window definition to their own theme files. It also has the added
benefit of breaking less often themes that are not part of the myth
distribution.

It won't help in the case where new UI elements have been added to existing
window definitions though :-(

Paul

Attachments:

xmlparse.diff (2.64 KB)

ijr at case

Apr 9, 2005, 10:34 PM

Post #2 of 4 (1168 views)
Permalink

Re: [PATCH] Change LoadTheme to fallback to default theme file ... [In reply to]

On Tuesday 05 April 2005 01:41 pm, Paul wrote:
> ... if a window definition cannot be found in the current theme.
>
> This patch gives XMLParse::LoadTheme() a second chance at finding
> a window definition by looking in the default theme file if it can't be
> found in the current theme file.

Nice. Applied to CVS. =)

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Dibblahmythml0015 at pendor

Apr 10, 2005, 1:17 AM

Post #3 of 4 (1143 views)
Permalink

Re: [PATCH] Change LoadTheme to fallback to default theme file ... [In reply to]

Isaac Richards wrote:
> On Tuesday 05 April 2005 01:41 pm, Paul wrote:
>
>>... if a window definition cannot be found in the current theme.
>>
>>This patch gives XMLParse::LoadTheme() a second chance at finding
>>a window definition by looking in the default theme file if it can't be
>>found in the current theme file.
>
>
> Nice. Applied to CVS. =)
>
> Isaac

Is this possibly the cause of:

http://www.mythtv.org/bugs/show_bug.cgi?id=5

(If a theme references a graphic with the same name as graphic in the
Default theme the image from the Default theme will be loaded instead of
the one from the theme.)

Cheers,

Allan.
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

ijr at case

Apr 10, 2005, 1:46 AM

Post #4 of 4 (1164 views)
Permalink

Re: [PATCH] Change LoadTheme to fallback to default theme file ... [In reply to]

On Sunday 10 April 2005 04:17 am, Allan Stirling wrote:
> Is this possibly the cause of:
>
> http://www.mythtv.org/bugs/show_bug.cgi?id=5
>
> (If a theme references a graphic with the same name as graphic in the
> Default theme the image from the Default theme will be loaded instead of
> the one from the theme.)

Nope.

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads