Mailing List Archive: MythTV: Commits

Ticket #10721: Mythmusic FLAC import fails with large number of files

Index | Next | Previous | View Threaded

noreply at mythtv

May 13, 2012, 8:54 PM

Post #1 of 9 (145 views)
Permalink

Ticket #10721: Mythmusic FLAC import fails with large number of files

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------------+----------------------------------
Reporter: mayfields@… | Type: Patch - Bug Fix
Status: new | Priority: minor
Milestone: unknown | Component: MythTV - General
Version: 0.25-fixes | Severity: medium
Keywords: mythmusic flac metadata | Ticket locked: 0
-------------------------------------+----------------------------------
When scanning for new music (eg when first installing), mythfrontend
crashes when importing metadata for a large number of files. Error
indicates too many open files. Incorrect data is also populated as
metadata cannot be read for a number of files prior to crash.

In metaioflacvorbis.cpp, flacfile is not deleted after use in
MetaIOFLACVorbis::read as it is in the other functions that open the file.
This results in each file remaining opened after metadata is read.

Patch attached, tested against 0.25-fixes.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 24, 2012, 10:11 AM

Post #2 of 9 (118 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------------+----------------------------
Reporter: mayfields@… | Owner:
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution:
Keywords: mythmusic flac metadata | Ticket locked: 0
-------------------------------------+----------------------------

Comment (by Steven Adeff <adeffs.mythtv@…>):

this patch does not work for me, I still get the "Could not open file"
error

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 24, 2012, 10:36 AM

Post #3 of 9 (116 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------+-------------------------------------------
Reporter: mayfields@… | Owner: Stuart Morgan <smorgan@…>
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythmusic flac | Ticket locked: 0
metadata |
-------------------------------+-------------------------------------------

Comment (by Stuart Morgan <smorgan@…>):

In [changeset:18606c9ec38c1cf100113c9ed3b09f9234766ba5/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="18606c9ec38c1cf100113c9ed3b09f9234766ba5"
Fix memory leak when reading flac vorbis tags. Fixes #10721
(cherry picked from commit 7d4b2858a59e4a24f6939a4a7ee26faf997da65e)
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 24, 2012, 10:36 AM

Post #4 of 9 (116 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------+-------------------------------------------
Reporter: mayfields@… | Owner: Stuart Morgan <smorgan@…>
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythmusic flac | Ticket locked: 0
metadata |
-------------------------------+-------------------------------------------
Changes (by Stuart Morgan <smorgan@…>):

* owner: => Stuart Morgan <smorgan@…>
* status: new => closed
* resolution: => fixed

Comment:

In [changeset:7d4b2858a59e4a24f6939a4a7ee26faf997da65e/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="7d4b2858a59e4a24f6939a4a7ee26faf997da65e"
Fix memory leak when reading flac vorbis tags. Fixes #10721
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 24, 2012, 10:37 AM

Post #5 of 9 (116 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

noreply at mythtv

May 25, 2012, 7:14 AM

Post #6 of 9 (115 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

noreply at mythtv

May 25, 2012, 8:32 AM

Post #7 of 9 (106 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

noreply at mythtv

May 30, 2012, 4:52 AM

Post #8 of 9 (94 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------+-------------------------------------------
Reporter: mayfields@… | Owner: Stuart Morgan <smorgan@…>
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythmusic flac | Ticket locked: 0
metadata |
-------------------------------+-------------------------------------------

Comment (by Stuart Morgan <smorgan@…>):

In [changeset:f46b168a87a609b4cc6834f32d392ebf83dfe89e/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="f46b168a87a609b4cc6834f32d392ebf83dfe89e"
Fix file handle leaks in oggvorbis and wavpack tag readers. These, along
with one in the flac tag reader were caused when we stopped using an
instance of the Taglib::FileRef class to read the track length.
Taglib::FileRef would take ownership of the pointer and delete it when we
were done, now that we're not using Taglib::FileRef we're again
responsible for deleting the object which in turn closes the open file
handle. Refs #10721
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 30, 2012, 4:56 AM

Post #9 of 9 (96 views)
Permalink

Re: Ticket #10721: Mythmusic FLAC import fails with large number of files [In reply to]

#10721: Mythmusic FLAC import fails with large number of files
-------------------------------+-------------------------------------------
Reporter: mayfields@… | Owner: Stuart Morgan <smorgan@…>
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - General | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythmusic flac | Ticket locked: 0
metadata |
-------------------------------+-------------------------------------------

Comment (by Stuart Morgan <smorgan@…>):

In [changeset:6ce0af8ce480b7445ebbd198a008f6023d17d24e/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="6ce0af8ce480b7445ebbd198a008f6023d17d24e"
Fix file handle leaks in oggvorbis and wavpack tag readers. These, along
with one in the flac tag reader were caused when we stopped using an
instance of the Taglib::FileRef class to read the track length.
Taglib::FileRef would take ownership of the pointer and delete it when we
were done, now that we're not using Taglib::FileRef we're again
responsible for deleting the object which in turn closes the open file
handle. Refs #10721
(cherry picked from commit f46b168a87a609b4cc6834f32d392ebf83dfe89e)
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10721#comment:8>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads