Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #10668: mythtranscode segfault [patch]

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


noreply at mythtv

Apr 29, 2012, 11:20 AM

Post #1 of 4 (103 views)
Permalink
Ticket #10668: mythtranscode segfault [patch]

#10668: mythtranscode segfault [patch]
-------------------------------------+-------------------------------------
Reporter: adiemus <mythtv@…> | Type: Bug Report - Crash
Status: new | Priority: minor
Milestone: unknown | Component: MythTV -
Version: 0.25-fixes | Mythtranscode
Keywords: mythtranscode crash | Severity: medium
segfault | Ticket locked: 0
-------------------------------------+-------------------------------------
I recently upgraded my 0.21-fixed myth environment to 0.25-fixes. I'm
chasing down several problems, once of which is that my newly transcoded
content looks terrible (it's very blocky and seems to frequently corrupt a
bit on scene changes) and that mythtranscode refuses to respect the
sampling rate I set for audio transcode.

Anyway, in trying to troubleshoot these issues by running mythtranscode
manually, I ran into an immediate and easily reproducible segfault.
(Command, output and backtrace attached)

The source of the crash is ultimately at dtvrecorder.cpp:35 in the LOC
preprocessor macro which dereferences tvrec without verifying that it's
not NULL. (In the case of a transcode, it's explicitly NULL, leading to
the crash in DTVRecorder::ResetForNewFile())

I'm far too unfamiliar with myth's codebase to understand the proper way
to fix the problem, but a simple workaround is to validate tvrec first,
which seems to at least allow me to run mythtranscode manually so I can
get about finding the source of my other issues.

Very simple patch attached. (Hopefully in a useful format)

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10668>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Apr 29, 2012, 12:18 PM

Post #2 of 4 (103 views)
Permalink
Re: Ticket #10668: mythtranscode segfault [patch] [In reply to]

#10668: mythtranscode segfault [patch]
------------------------------------------+----------------------------
Reporter: adiemus <mythtv@…> | Owner: danielk
Type: Bug Report - Crash | Status: accepted
Priority: minor | Milestone: 0.25.1
Component: MythTV - Recording | Version: 0.25-fixes
Severity: medium | Resolution:
Keywords: mythtranscode crash segfault | Ticket locked: 0
------------------------------------------+----------------------------
Changes (by danielk):

* owner: => danielk
* status: new => accepted
* component: MythTV - Mythtranscode => MythTV - Recording
* milestone: unknown => 0.25.1


--
Ticket URL: <http://code.mythtv.org/trac/ticket/10668#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

May 1, 2012, 7:02 AM

Post #3 of 4 (85 views)
Permalink
Re: Ticket #10668: mythtranscode segfault [patch] [In reply to]

#10668: mythtranscode segfault [patch]
------------------------------------------+----------------------------
Reporter: adiemus <mythtv@…> | Owner: danielk
Type: Bug Report - Crash | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - Recording | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythtranscode crash segfault | Ticket locked: 0
------------------------------------------+----------------------------
Changes (by Daniel Thor Kristjansson <danielk@…>):

* status: accepted => closed
* resolution: => fixed


Comment:

In [changeset:ac36239755c1eb4e241e801c4c3b30f2f41b123d/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="ac36239755c1eb4e241e801c4c3b30f2f41b123d"
Fixes #10668. Fixes segfault in mythtranscode use of DTVRecorder.

This was discovered and diagnosed by Chris Tracy <mythtv [at] adiemus>.

The problem is a debugging macro that assumes the recorder is being
controlled by TVRec.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10668#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

May 1, 2012, 7:07 AM

Post #4 of 4 (98 views)
Permalink
Re: Ticket #10668: mythtranscode segfault [patch] [In reply to]

#10668: mythtranscode segfault [patch]
------------------------------------------+----------------------------
Reporter: adiemus <mythtv@…> | Owner: danielk
Type: Bug Report - Crash | Status: closed
Priority: minor | Milestone: 0.25.1
Component: MythTV - Recording | Version: 0.25-fixes
Severity: medium | Resolution: fixed
Keywords: mythtranscode crash segfault | Ticket locked: 0
------------------------------------------+----------------------------

Comment (by Daniel Thor Kristjansson <danielk@…>):

In [changeset:d06433833bd0411cd3ff82e3810f006f4529da81/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="d06433833bd0411cd3ff82e3810f006f4529da81"
Fixes #10668. Fixes segfault in mythtranscode use of DTVRecorder.

This was discovered and diagnosed by Chris Tracy <mythtv [at] adiemus>.

The problem is a debugging macro that assumes the recorder is being
controlled by TVRec.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10668#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.