Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #10522: Correct compiler warning about unsigned comparison

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


noreply at mythtv

Mar 28, 2012, 11:01 AM

Post #1 of 6 (73 views)
Permalink
Ticket #10522: Correct compiler warning about unsigned comparison

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster | Owner: robertm
<gary.buhrmaster@…> | Status: new
Type: Patch - Bug Fix | Milestone: unknown
Priority: minor | Version: Master Head
Component: MythTV - Blu-ray Playback | Keywords:
Severity: low |
Ticket locked: 0 |
-------------------------------------------------+-------------------------
Remove pendantic compiler warning about comparison of unsigned expression
in bdringbuffer.cpp


In bdringbuffer, the chapter variable is declared as a unsigned integer.
The tests for chapter<0 will always be false (and may be optimized out by
a good compiler). The supplied patch removes the code which results in
the (pendantic) warning message.

change: if (chapter < 0 || chapter >= GetNumChapters())
to: if (chapter >= GetNumChapters())

Patch attached.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Apr 10, 2012, 8:04 AM

Post #2 of 6 (56 views)
Permalink
Re: Ticket #10522: Correct compiler warning about unsigned comparison [In reply to]

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Owner:
Type: Patch - Bug Fix | Status:
Priority: minor | assigned
Component: MythTV - Blu-ray Playback | Milestone: unknown
Severity: low | Version: Master
Keywords: | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by robertm):

* owner: robertm =>
* status: new => assigned


--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522#comment:1>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Apr 10, 2012, 8:51 AM

Post #3 of 6 (57 views)
Permalink
Re: Ticket #10522: Correct compiler warning about unsigned comparison [In reply to]

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Owner:
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Blu-ray Playback | Version: Master
Severity: low | Head
Keywords: | Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by wagnerrp):

* status: assigned => new


--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Dec 12, 2012, 12:30 PM

Post #4 of 6 (22 views)
Permalink
Re: Ticket #10522: Correct compiler warning about unsigned comparison [In reply to]

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Owner:
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Blu-ray Playback | Version: Master
Severity: low | Head
Keywords: | Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by gary.buhrmaster@…):

It appears that Danielk, in commit
42e3b74b91d6de458773729f242e043e7f359b2a fixed this a couple of days ago
as part of code cleanup.

Please close this ticket.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Dec 12, 2012, 12:40 PM

Post #5 of 6 (22 views)
Permalink
Re: Ticket #10522: Correct compiler warning about unsigned comparison [In reply to]

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Owner:
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.27
Component: MythTV - Blu-ray Playback | Version: Master
Severity: low | Head
Keywords: | Resolution: Fixed
| Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by mdean):

* status: new => closed
* resolution: => Fixed
* milestone: unknown => 0.27


Comment:

Fixed in 42e3b74b9:

Address a couple sign change issues (gcc warnings).

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Dec 12, 2012, 12:40 PM

Post #6 of 6 (22 views)
Permalink
Re: Ticket #10522: Correct compiler warning about unsigned comparison [In reply to]

#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Owner: danielk
Type: Patch - Bug Fix | Status: closed
Priority: minor | Milestone: 0.27
Component: MythTV - Blu-ray Playback | Version: Master
Severity: low | Head
Keywords: | Resolution: Fixed
| Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by mdean):

* owner: => danielk


--
Ticket URL: <http://code.mythtv.org/trac/ticket/10522#comment:5>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.