Mailing List Archive: MythTV: Commits

Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)

1 2

View All

Index | Next | Previous | View Threaded

noreply at mythtv

Mar 24, 2012, 2:24 PM

Post #1 of 29 (998 views)
Permalink

Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------+-------------------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - | Status: new
General | Milestone: 0.25
Priority: major | Version: Master Head
Component: Plugin - MythWeb | Keywords: Call-time pass-by-
Severity: medium | reference PHP 5.4.0
Ticket locked: 0 |
-------------------------------------+-------------------------------------
mythweb doesn't work with PHP 5.4.0 and later because call time pass by
reference is removed in PHP 5.4.0

[Sat Mar 24 22:08:52 2012] [error] [client 10.0.0.2] PHP Warning:
Unknown: function '0' not found or invalid function name in Unknown on
line 0
[Sat Mar 24 22:08:53 2012] [error] [client 10.0.0.2] PHP Fatal error:
Call-time pass-by-reference has been removed in
/usr/local/share/mythtv/binding
s/php/MythBase.php on line 50

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 24, 2012, 3:41 PM

Post #2 of 29 (987 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Mar 26, 2012, 2:01 AM

Post #3 of 29 (969 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Mar 27, 2012, 3:49 AM

Post #4 of 29 (967 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by Dave Sp <davespmyth@…>):

This hit me, too. I patched three files to resolve this, which I will
attach. These patches have only been tested against PHP 5.4.0, and I do
not know if they introduce any memory leaks.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 27, 2012, 3:51 AM

Post #5 of 29 (967 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Mar 27, 2012, 2:19 PM

Post #6 of 29 (960 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by hodosiszabolcs@…):

Feedback:

Sir,
Your patches contains no changes, before and after code are identical.
Applying your patches of course did not solve the issue.

Szabi
hodosiszabolcs [at] gmail

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:5>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 27, 2012, 2:36 PM

Post #7 of 29 (971 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Mar 30, 2012, 8:20 PM

Post #8 of 29 (942 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by nelsonbt2001@…):

Manually applied the same changes to my debian-unstable setup.

I was able to get in and see the back-end status, upcoming recordings,
delete recordings, schedule new recordings, etc.

Thanks Dave Sp.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 31, 2012, 12:15 AM

Post #9 of 29 (941 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Mar 31, 2012, 7:00 AM

Post #10 of 29 (948 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Apr 8, 2012, 2:25 AM

Post #11 of 29 (882 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by tino@…):

Thank you for these patches. They make my MythWeb work again on Debian
Unstable.

I don't know if this is related, but I still get some error messages when
I view program details after searching:

Warning at /usr/share/mythtv/mythweb/modules/tv/detail.php, line 310:
!!NoTrans: Invalid argument supplied for foreach()!!

Warning at
/usr/share/mythtv/mythweb/modules/_shared/tmpl/default/header.php, line
16:
!!NoTrans: Cannot modify header information - headers already sent by
(output started at /usr/share/mythtv/mythweb/includes/errors.php:150)!!

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:10>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 17, 2012, 5:57 PM

Post #12 of 29 (853 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by paul@…):

The MythBase.php file no longer exists (or at least I don't see where it
is located). Patching the other two above, I still don't have a
functioning system. It looks like MythBase.php was just removed?

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:11>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 17, 2012, 6:08 PM

Post #13 of 29 (852 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Apr 19, 2012, 5:59 PM

Post #14 of 29 (854 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

May 13, 2012, 3:33 AM

Post #15 of 29 (795 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by Philipp Hahn <pmhahn@…>):

MythBase.php is now part of MythTV; you need to patch
mythtv/bindings/php/MythBase.php in the source tree or
/usr/local/share/mythtv/bindings/php/MythBase.php after installation to
/usr/local/

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:14>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 14, 2012, 5:39 AM

Post #16 of 29 (799 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by bnitkin@…):

In MythTV .25-3, just removing the ampersand from line 50 of
/usr/share/mythtv/bindings/php/MythBase.php fixed the white screen of
death.
I also disabled the JSON extention in php.ini - not sure if that's an Arch
Linux thing or a general issue.

{{{
Cache::setObject($this->cacheKey, &$this, $this->cacheLifetime);
}}}
becomes
{{{
Cache::setObject($this->cacheKey, $this, $this->cacheLifetime);
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:15>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 20, 2012, 4:33 AM

Post #17 of 29 (782 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by Dave Sp <davespmyth@…>):

Regarding the comments by tino and googalus, on 0.24-fixes I am not seeing
that particular issue; I get no error message when clicking for details on
a search result. If I ever get around to upgrading to 0.25, I'll check
again.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:16>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 25, 2012, 5:47 AM

Post #18 of 29 (743 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by pinballowen@…):

Replying to [comment:15 bnitkin@…]:
> In MythTV .25-3, just removing the ampersand from line 50 of
/usr/share/mythtv/bindings/php/MythBase.php fixed the white screen of
death.
> I also disabled the JSON extention in php.ini - not sure if that's an
Arch Linux thing or a general issue.
>
> {{{
> Cache::setObject($this->cacheKey, &$this, $this->cacheLifetime);
> }}}
> becomes
> {{{
> Cache::setObject($this->cacheKey, $this, $this->cacheLifetime);
> }}}
>
[[br]]
This also worked for me! Using MythTV 0.25-3 and MythWeb 0.25-3

THANKYOU!

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:17>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 25, 2012, 5:49 AM

Post #19 of 29 (735 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Jun 5, 2012, 12:10 AM

Post #20 of 29 (664 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by cooljavaj@…):

The patch in schedules.php.patch is only effective in the default template
of mythtv.
If you omit/reverse this patch and apply essentially the same patch to the
file /usr/share/mythweb/modules/tv/schedules.php, it will work on all
mythtv-templates instead of only the default one.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:19>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Jun 8, 2012, 11:59 AM

Post #21 of 29 (649 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Jun 13, 2012, 9:02 PM

Post #22 of 29 (620 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by Chris Petersen <cpetersen@…>):

In [changeset:cd670ec7bf5f04f1ba67b5a7cbc00374479eb9b0/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="cd670ec7bf5f04f1ba67b5a7cbc00374479eb9b0"
Partial support for PHP 5.4

Bindings portions of the patch re #10504
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:21>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Jun 13, 2012, 9:42 PM

Post #23 of 29 (623 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: closed
Priority: minor | Milestone:
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution: fixed
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by Chris Petersen <cpetersen@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:7232c54eec2fa1416ef8c0b3fbdad642aaf26b55/mythweb]:
{{{
#!CommitTicketReference repository="mythweb"
revision="7232c54eec2fa1416ef8c0b3fbdad642aaf26b55"
Suppress more PHP 5.4 warnings

Closes #10504
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:22>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Jun 26, 2012, 5:47 PM

Post #24 of 29 (546 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

noreply at mythtv

Jul 10, 2012, 9:37 AM

Post #25 of 29 (515 views)
Permalink

Re: Ticket #10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference) [In reply to]

#10504: mythweb incomatible with PHP 5.4.0 and later ( Call-time pass-by-reference)
-------------------------------------------------+-------------------------
Reporter: billyx@… | Owner: kormoc
Type: Bug Report - General | Status: new
Priority: minor | Milestone: 0.26
Component: Plugin - MythWeb | Version: Master
Severity: medium | Head
Keywords: Call-time pass-by-reference PHP | Resolution:
5.4.0 | Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by Anthony Messina <amessina@…>):

* status: closed => new
* resolution: fixed =>

Comment:

Even with the above fixes implemented on a fixes/0.25 build, the following
error still pollutes the httpd logs, though MythWeb ''seems'' to work
properly.
{{{
PHP Warning: Unknown: function '0' not found or invalid function name in
Unknown on line 0
}}}
What am I missing here?

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10504#comment:24>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

1 2

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads