Mailing List Archive: MythTV: Commits

Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom

Index | Next | Previous | View Threaded

noreply at mythtv

Mar 3, 2012, 4:55 PM

Post #1 of 6 (139 views)
Permalink

Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
---------------------------------+----------------------------------
Reporter: ggervasio@… | Type: Patch - Feature
Status: new | Priority: minor
Milestone: unknown | Component: MythTV - General
Version: Unspecified | Severity: medium
Keywords: | Ticket locked: 0
---------------------------------+----------------------------------
The way text font zoom is implemented for EIA-608 closed captions does not
work well when the zoom factor is < 100 (I use 60-70) -- there are big
gaps between lines and the subtitle region is mostly on the left side of
the screen (not good for captions in which the "speaker" is on the right
side).

The first patch attached is an alternative way of using the zoom factor in
which the entire subtitle region is scaled, centered, and anchored to the
top or bottom depending on position.

The second patch implements a similar scheme for DVD/BD subtitles.

Both changes are available in the "sub_zoom" branch at
git://github.com/ggervasio/mythtv.git

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10402>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 3, 2012, 5:10 PM

Post #2 of 6 (140 views)
Permalink

Re: Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom [In reply to]

noreply at mythtv

Mar 11, 2012, 8:19 AM

Post #3 of 6 (130 views)
Permalink

Re: Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom [In reply to]

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
---------------------------------+-----------------------------
Reporter: ggervasio@… | Owner: stichnot
Type: Patch - Feature | Status: accepted
Priority: minor | Milestone: 0.26
Component: MythTV - Captions | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
---------------------------------+-----------------------------

Comment (by Github):

Subtitles: Improve layout of zoomed CEA-608 captions.

Thanks to Gregorio for the patch that improves the CEA-608 layout, in
particular when the zoom factor is less than 100%, by horizontally
centering the caption region and vertically snapping lines to the top
or bottom of the safe area. One key difference from the original
patch is that horizontal centering is disabled when then zoom factor
is 100% or more. While horizontal centering might be more visually
appropriate, I'm not comfortable that it becomes markedly different
from the "equivalent" CEA-708 layout.

Refs #10402.

Signed-off-by: Jim Stichnoth <jstichnoth [at] mythtv>
Branch: master
Changeset: eac7f477dc5a5844c44f39e1b1d4daacf09cea0b

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10402#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 21, 2012, 10:30 AM

Post #4 of 6 (94 views)
Permalink

Re: Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom [In reply to]

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
-------------------------------+-----------------------------
Reporter: ggervasio@… | Owner: stichnot
Type: Patch - Feature | Status: accepted
Priority: minor | Milestone: 0.26
Component: MythTV - Captions | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-------------------------------+-----------------------------

Comment (by stichnot):

Gregorio,

I have a couple of questions about the AV subtitle patch. First, this
portion of the patch:

{{{
@@ -269,7 +272,8 @@ void SubtitleScreen::DisplayAVSubtitles(void)
int right = rect->x + rect->w;
int bottom = rect->y + rect->h;
if (subs->fixPosition || (currentFrame->height < bottom)
||
- (currentFrame->width < right))
+ (currentFrame->width < right) ||
+ !display.width() || !display.height())
{
int sd_height = 576;
if ((m_player->GetFrameRate() > 26.0f) && bottom <=
480)

}}}
doesn't seem to have anything to do with zooming, right? Do you have a
sample that displays incorrectly (irrespective of zooming) when width or
height are 0?

Second, comments in the patch indicate that if a subtitle spans the center
line, it gets split into the top half and the bottom half, and each half
is drawn separately. It seems that that would work reasonably for a zoom
greater than 100%, but that a zoom less than 100% would lead to a possibly
large gap between the two halves. Is this right? Do you have a sample
with a subtitle spanning the center line?

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10402#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 21, 2012, 11:54 AM

Post #5 of 6 (95 views)
Permalink

Re: Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom [In reply to]

#10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom
-------------------------------+-----------------------------
Reporter: ggervasio@… | Owner: stichnot
Type: Patch - Feature | Status: accepted
Priority: minor | Milestone: 0.26
Component: MythTV - Captions | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-------------------------------+-----------------------------

Comment (by ggervasio@…):

1. Sorry, I'm not exactly sure whether that check was only required with
the zooming changes. I do know that I had to add that check separately
after the other changes were in place. (I had been maintaining the other
changes locally for >5 years and that check was only added a few months
ago.) Let me see if I can find a clip which triggers that code. It might
be difficult because much of my testing has been on rentals.

2. Yes, the patch intentionally tries to keep the center of the display
clear when zoom is <100%. The case I've seen where DVD subtitles span the
center line is when there are subtitles at the top and bottom edges of the
display, so it works well in that case -- the subtitles stay at the top
and bottom instead of one side being "off". I will see if I can find an
example.

However, as you say, it won't look good if the subtitles are supposed
to be grouped in the center of the display. I've seen this with the CC608
patch (and I just live with it) but I don't think I've run into such a
case with DVDs. I think the bigger problem with subtitles in the center
is that if the zoom is >100%, I think the patch may cause the two halves
to overlap. To be honest, I didn't consider that anyone would want to use
zoom >100%.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10402#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 21, 2012, 6:26 PM

Post #6 of 6 (95 views)
Permalink

Re: Ticket #10402: Alternative implementation of CC608zoom; Implement DVD subtitle zoom [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads