Mailing List Archive: MythTV: Commits

Ticket #9294: SSA/ASS Subtitle support

Index | Next | Previous | View Threaded

mythtv at cvs

Nov 26, 2010, 2:40 PM

Post #1 of 17 (493 views)
Permalink

Ticket #9294: SSA/ASS Subtitle support

#9294: SSA/ASS Subtitle support
-----------------------------------------+----------------------------------
Reporter: anonymous | Owner: janne
Type: Patch - Feature | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: Trunk Head
Severity: medium | Keywords:
Ticket locked: 0 |
-----------------------------------------+----------------------------------
the attached patches should support basic SSA/ASS support

what isnt supported in this patch(might be more it should have similar
support as mplayer w/out using -ass in commandline)
* it ignores all SSA override codes
* it ignores underline and strike-through in the subtitle styles
* it ignores the text wrapping setting and wraps them anyway if needed
* the code only allows for hex colour codes but after rereading the specs
integer based colourcodes can be used too
* moving previous subtitles up for new ones and clearing subtitles when
layer is less then the one being displayed

using libass instead of these patch would probably support everything if
you want to do that intead

the 3rd patch is version 6 and hasn't been tested on my main machine
yet(adds scalex/y and i think deletes the styles when done previous
patches can be found on dev list) i recommend going over this patch
carefully for bugs since i am a self taught programmer and it is the first
time i have used the QT libary and the mythtv code

you can find a link to the specs + some more info here
[http://www.matroska.org/technical/specs/subtitles/ssa.html]

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9294>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Nov 27, 2010, 3:55 AM

Post #2 of 17 (475 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
----------------------------------------------------+-----------------------
Reporter: Shawn King <shawnking@…> | Owner: janne
Type: Patch - Feature | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------------------+-----------------------
Changes (by kenni):

* status: new => assigned
* reporter: anonymous => Shawn King <shawnking@…>

Comment:

See also mythtv-dev: http://www.gossamer-
threads.com/lists/mythtv/dev/460711

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9294#comment:1>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

noreply at mythtv

Dec 5, 2010, 3:14 PM

Post #3 of 17 (454 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
-------------------------------------------------+-------------------------
Reporter: Shawn King <shawnking@…> | Owner: janne
Type: Patch - Feature | Status:
Priority: minor | assigned
Component: MythTV - Video Playback | Milestone: unknown
Severity: medium | Version: Trunk
Keywords: | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by SlackerLinux85@…):

the ffmpeg patch shouldn't be needed nomore it should be fixed in ffmpeg
repos

attached is v7 of the 3rd patch it fixes detecting the style version and
attempts to support colourcodes other then hex

looking at the header these patches prob wont work with the SRT patch in
ffmpeg devel mailing list so there's prob a lil bit more work to be done
http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-December/101408.html

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9294#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

noreply at mythtv

Jan 11, 2011, 3:24 PM

Post #4 of 17 (426 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
-------------------------------------------------+-------------------------
Reporter: Shawn King <shawnking@…> | Owner: janne
Type: Patch - Feature | Status:
Priority: minor | assigned
Component: MythTV - Video Playback | Milestone: unknown
Severity: medium | Version: Trunk
Keywords: | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by slackerlinux85@…):

the 3 new patches replace the older ones they use libass to render the
subtitles which should support any SSA/ASS file and the new SRT to ASS
conversion code in FFMPEG(i haven't tested this though)

only issue i have found sofar is in the opengl renderer the subtitles are
displayed on the black bar xv-blit shows them at the correct spot also the
code links to the system libass(with no option to disable/enable in
configure) so the libass library still needs to be added to myth

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9294#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 8, 2011, 2:54 PM

Post #5 of 17 (398 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
-------------------------------------------------+-------------------------
Reporter: Shawn King <shawnking@…> | Owner: janne
Type: Patch - Feature | Status:
Priority: minor | assigned
Component: MythTV - Video Playback | Milestone: unknown
Severity: medium | Version: Trunk
Keywords: | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by slackerlinux85@…):

link to new version of the 0003-Add-SSA-ASS-subtitle-support-libass.patch
it doesn't change the code it adds libass into mythtv source tree and
compiles it as a dll(works for me someone who knows the build code should
give it a onceover) atleast on master on the ffmpeg sync branch
./configure wasn't working

you can also now compile without libass support
[http://www.mediafire.com/?6nb0arlh5jjk9j3]

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9294#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Mar 8, 2011, 3:02 PM

Post #6 of 17 (399 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

Apr 26, 2011, 11:25 AM

Post #7 of 17 (356 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

Apr 26, 2011, 5:08 PM

Post #8 of 17 (339 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
-------------------------------------------------+-------------------------
Reporter: Shawn King <shawnking@…> | Owner: janne
Type: Patch - Feature | Status:
Priority: minor | infoneeded
Component: MythTV - Video Playback | Milestone: unknown
Severity: medium | Version: Trunk
Keywords: | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------

Comment (by slackerlinux85@…):

all of it

* 1st patch allows the 3rd patch to access subtitle header code in ffmpeg
* 2nd patch allows access to ffmpegs font attachments for libass to render
* 3rd patch uses libass to render the SUBTITLE_ASS subtitle type and
removes the code that ignores SSA subtitles last version in the mediafire
link also includes libass in the mythtv source tree so no dependancy is
added

the patches seem to work i have been running them ever since i made them
and the only issue i can see atm is with the opengl renderer the subtitle
location is placed on the black bar when they should be on the video. XV
renderer is fine. should be a simple problem for someone more familiar
with the code i couldn't find the right QRect to use(atm its using
m_player->getVideoOutput()->GetOSDBounds())

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9294#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 27, 2011, 4:22 PM

Post #9 of 17 (336 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 2, 2011, 6:41 PM

Post #10 of 17 (321 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 2, 2011, 6:42 PM

Post #11 of 17 (321 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 2, 2011, 7:03 PM

Post #12 of 17 (321 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 2, 2011, 7:39 PM

Post #13 of 17 (321 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 2, 2011, 8:02 PM

Post #14 of 17 (321 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

May 3, 2011, 12:13 AM

Post #15 of 17 (316 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

#9294: SSA/ASS Subtitle support
-------------------------------------------------+-------------------------
Reporter: Shawn King <shawnking@…> | Owner: markk
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: Trunk
Severity: medium | Head
Keywords: | Resolution: fixed
| Ticket locked: 0
-------------------------------------------------+-------------------------
Changes (by Github):

* status: assigned => closed
* resolution: => fixed

Comment:

Add ASS/SSA subtitle support.

Based on the final patch from Shawn King (thank you) in #9294 with the
following changes:-

- fixed the display area to line up with the video rect.
- only initialise libass when required.
- various additional NULL pointer checks and minor refactors.
- use SubtitleScreen::m_safeArea in the ass code.

I chose to use a compile time dependency on libass rather than create
another internal library version (and avoid the maintenance that it
would need) or use dynamic linking (extra complexity). As noted in
configure, the libass version (although not actually checked) needs to
be at least 0.9.10 - which is probably still too new for the libass
version packaged with most distros.

Closes #9294
Changeset: bfeabeeb189950411abd09ace0f0d19f1a6e607a

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9294#comment:14>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Feb 5, 2012, 2:42 PM

Post #16 of 17 (94 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

noreply at mythtv

Feb 5, 2012, 4:15 PM

Post #17 of 17 (94 views)
Permalink

Re: Ticket #9294: SSA/ASS Subtitle support [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads