Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #9213: Skip backwards no longer skips "through" a cut list

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Nov 11, 2010, 7:09 PM

Post #1 of 10 (350 views)
Permalink
Ticket #9213: Skip backwards no longer skips "through" a cut list

#9213: Skip backwards no longer skips "through" a cut list
-----------------------------------------+----------------------------------
Reporter: mythtv@… | Owner: janne
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Keywords:
Ticket locked: 0 |
-----------------------------------------+----------------------------------
Minor regression from 0.23-fixes to 0.24-fixes.

In 0.23-fixes, if you have a cut list defined for a video, then you end up
at the end of a cut point (for example, after it skips the commercials),
if you try to skip backwards in the video, it will actually skip past the
previous cut list and play video shortly before the cut point (my guess
would be whatever you have set as the rewind amount, such as 5 seconds).

In 0.24-fixes, it will no longer skip past the cut point. It will only
skip back to the end of that cut point, thus making it impossible to "skip
backwards" through a cut point. If you do a large jump (such as a 10
minute jump), it will skip past it fine, but then you are really far away
from where you were trying to go.

My guess is that 0.24-fixes is now just performing a simple frame count
calculation to determine where to skip, ignoring the cut list. When you
skip backwards, it resumes play from inside a defined cut list, then skips
to the end of that cut point to resume.

It would be awesome to have the 0.23-fixes functionality back.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9213>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 12, 2010, 6:21 AM

Post #2 of 10 (341 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: janne
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+--------------------------------------

Comment (by Jim Stichnoth <stichnot@…>):

FWIW, part of the patch in #8631 fixes this.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9213#comment:1>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 19, 2010, 8:54 AM

Post #3 of 10 (334 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: markk
Type: defect | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+--------------------------------------
Changes (by robertm):

* owner: janne => markk
* status: new => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9213#comment:2>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


noreply at mythtv

Jan 31, 2011, 6:25 PM

Post #4 of 10 (269 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: mdean
Type: defect | Status: accepted
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------
Changes (by mdean):

* owner: markk => mdean
* status: assigned => accepted


--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


noreply at mythtv

Jul 25, 2011, 5:19 AM

Post #5 of 10 (232 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: mdean
Type: Bug Report - General | Status: infoneeded
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------
Changes (by stuartm):

* status: accepted => infoneeded
* type: defect => Bug Report - General
* milestone: unknown => 0.25


Comment:

Jim, can you break out the bit which fixes this bug and attach to this
ticket? Or was it what Taylor already committed?

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Jul 25, 2011, 1:19 PM

Post #6 of 10 (226 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: mdean
Type: Bug Report - General | Status: infoneeded
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------

Comment (by Jim Stichnoth <stichnot@…>):

I looked into this, and the problem still exists in Master. It would be
possible to remove the code in the #8631 patch that deals with alternate
keybindings, OSD, and jumping to an absolute time, leaving only the code
related to relative jumping, but the resulting user experience could be
inconsistent and confusing in places (I can give examples if requested).
Basically, #8631 needs to be applied all or nothing for a consistent user
experience.

Instead, I attached a patch that skips to 3 seconds before the start of
the cut region if you try to jump backward into a cut region.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:5>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Nov 12, 2011, 1:37 PM

Post #7 of 10 (212 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: mdean
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------
Changes (by robertm):

* status: infoneeded => assigned


--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:6>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Feb 23, 2012, 1:24 PM

Post #8 of 10 (186 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: stichnot
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------
Changes (by stichnot):

* owner: mdean => stichnot


--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Feb 23, 2012, 7:08 PM

Post #9 of 10 (176 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: stichnot
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution: fixed
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------
Changes (by Github):

* status: assigned => closed
* resolution: => fixed


Comment:

Fix seeking backwards into a cut region.

When skipping backwards and ending up in a cut region, move instead to
5 seconds before the beginning of the cut region. This isn't a perfect
solution, but it fixes 99.99% of the problem. A more robust solution
will be implemented post 0.25.

Fixes #9213.
Branch: master
Changeset: 89c34ef6b2e0e8688474ef546b799d54d8ec6242

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:8>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Apr 12, 2012, 8:14 PM

Post #10 of 10 (155 views)
Permalink
Re: Ticket #9213: Skip backwards no longer skips "through" a cut list [In reply to]

#9213: Skip backwards no longer skips "through" a cut list
-------------------------------------+----------------------------
Reporter: mythtv@… | Owner: stichnot
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 0.25
Component: MythTV - Video Playback | Version: 0.24-fixes
Severity: low | Resolution: fixed
Keywords: | Ticket locked: 0
-------------------------------------+----------------------------

Comment (by Jim Stichnoth <jstichnoth@…>):

In [changeset:ed316911fd32bf31def19705adc1057f6b0dc9d1/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="ed316911fd32bf31def19705adc1057f6b0dc9d1"
Revert "Fix seeking backwards into a cut region."

This reverts commit 89c34ef6b2e0e8688474ef546b799d54d8ec6242.

This is no longer needed after f0b202909eaeb963a6c3648f9eb45ab3e95ba159.

Refs #8631. Refs #9213.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/9213#comment:9>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.