Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Jul 24, 2010, 5:37 PM

Post #1 of 8 (274 views)
Permalink
Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+----------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version: 0.23-fixes
Severity: low | Mlocked: 0
-----------------------------------------------+----------------------------
The current UpdateFiltersFromStreamData() figures out what pids have
changed(added/removed) by comparing two maps.
This is a needlessly expensive way of doing it considering it is called
quite often by RunTS().

The managing of pid changes could be done better/cheaper by the
MPEGStreamData class since it is it already manages the pids, and know
when they change.

I have attached a PoC patch that reduces CPU usage of the backend by
20-30% - (active EIT and no frontend) this is on a Geode system.
On a faster system this may very well be insignificant.


The patch will change the functionality slightly if a pid is removed and
added again in MPEGStreamData.

Current behavior:
UpdateFiltersFromStreamData() will make no change

The PoC patch:
UpdateFiltersFromStreamData() will close the filter, and then reopen
it.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8695>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 25, 2010, 2:01 PM

Post #2 of 8 (244 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+----------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version: 0.23-fixes
Severity: low | Mlocked: 0
-----------------------------------------------+----------------------------

Comment(by Rune Petersen <rune@…>):

I just realized that my patch breaks multiple sinks(MPEGStreamData derived
classes) with overlapping pids - this can of cause be resolved using ref-
counting.

So the question is: will you accept a patch along the lines the PoC patch?
(not necessarily for 0.23-fixes)

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8695#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 25, 2010, 4:23 PM

Post #3 of 8 (244 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+----------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version: 0.23-fixes
Severity: low | Mlocked: 0
-----------------------------------------------+----------------------------
Changes (by stuarta):

* cc: stuarta (added)


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8695#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 31, 2010, 4:12 AM

Post #4 of 8 (223 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+----------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version: 0.23-fixes
Severity: low | Mlocked: 0
-----------------------------------------------+----------------------------

Comment(by Rune Petersen <rune@…>):

I have attached a new PoC patch that is fully functional on DVB.
(the patch also contains initial work of joining all the pidmaps into a
single pidmap)

Wen I look at the changes needed it is clear it will never get into
0.23-fixes, but what about trunk?

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8695#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 11, 2010, 9:27 PM

Post #5 of 8 (183 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+----------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version: 0.23-fixes
Severity: low | Resolution:
Keywords: | Ticket locked: 0
-----------------------------------------------+----------------------------
Changes (by robertm):

* status: new => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8695#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


noreply at mythtv

Jun 27, 2011, 9:48 AM

Post #6 of 8 (109 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+---------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status:
Priority: minor | infoneeded
Component: MythTV - DVB | Milestone: unknown
Severity: low | Version:
Keywords: | 0.23-fixes
| Resolution:
| Ticket locked: 0
-----------------------------------------------+---------------------------
Changes (by robertm):

* status: assigned => infoneeded


Comment:

Rune,

I don't see this ever being applied unless it is out of the proof of
concept stage. Are you willing to/able provide a patch which leaves all
recorders functional? If not, I don't think we can do anything with this
ticket without someone willing to do the work themselves.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8695#comment:5>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Jun 28, 2011, 11:43 AM

Post #7 of 8 (97 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+---------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status:
Priority: minor | infoneeded
Component: MythTV - DVB | Milestone: unknown
Severity: low | Version:
Keywords: | 0.23-fixes
| Resolution:
| Ticket locked: 0
-----------------------------------------------+---------------------------

Comment (by rune@…):

The description is badly worded (my specialty).

I do intend to do the work, I just don't like wasting time on a patch if
"you" aren't interested

From one of my comments:
"So the question is: will you accept a patch along the lines the PoC
patch? (not necessarily for 0.23-fixes)"


I will be rebasing my patches in the near future, so If "you" are
interested I'll see about cleaning it up when I rebase.

And if I could get some constructive critique on the PoC I would be
grateful

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8695#comment:6>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits


noreply at mythtv

Nov 12, 2011, 1:35 PM

Post #8 of 8 (77 views)
Permalink
Re: Ticket #8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData() [In reply to]

#8695: Optimize DVBStreamHandler::UpdateFiltersFromStreamData()
-----------------------------------------------+---------------------------
Reporter: Rune Petersen <rune@…> | Owner: janne
Type: enhancement | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - DVB | Version:
Severity: low | 0.23-fixes
Keywords: | Resolution: Won't Fix
| Ticket locked: 0
-----------------------------------------------+---------------------------
Changes (by robertm):

* status: infoneeded => closed
* resolution: => Won't Fix


Comment:

Closing this ticket, please feel free to open a new one if you decide to
do the work, I don't think anyone can answer whether a theoretical patch
will be accepted.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8695#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.