Mailing List Archive: MythTV: Commits

Ticket #8631: Treat cutlists like lossless transcoding

Index | Next | Previous | View Threaded

mythtv at cvs

Jul 1, 2010, 7:06 PM

Post #1 of 16 (668 views)
Permalink

Ticket #8631: Treat cutlists like lossless transcoding

mythtv at cvs

Aug 11, 2010, 9:46 PM

Post #2 of 16 (583 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

mythtv at cvs

Oct 4, 2010, 7:43 PM

Post #3 of 16 (577 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+---------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: mdean
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------------------------+---------------------------

Comment (by Jim Stichnoth <stichnot@…>):

Added v2 patch, which follows Mike Dean's suggestions to make both the
pre- and post-cutlist information available to the themer, and to
introduce additional keybindings to allow seeking with and without taking
the cutlist into account.

TV Playback keybindings added are ARBSEEKNOCUTLIST, INFONOCUTLIST,
JUMPFFWDNOCUTLIST, JUMPRWNDNOCUTLIST, SEEKFFWDNOCUTLIST, and
SEEKRWNDNOCUTLIST.

Theme fields added are rawposition, rawdescription, rawplayedtime,
rawtotaltime, rawremainingtime, and rawbehindtime. (The last one is
probably unnecessary.)

Network Control "PLAY SEEK" commands added are FORWARDNOCUTLIST,
BACKWARDNOCUTLIST, and POSITIONNOCUTLIST. (It might be cleaner to add an
optional NOCUTLIST argument to the existing FORWARD/BACKWARD/POSITION
arguments.)

Note that the patch makes the default behavior to seek and display taking
the cutlist into account. This is based on the assumption that if the
user went to the effort of creating a cutlist, then she probably wants to
see the effect in most parts of the user experience.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8631#comment:2>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Oct 8, 2010, 2:14 PM

Post #4 of 16 (558 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+---------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: mdean
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------------------------+---------------------------

Comment (by Jim Stichnoth <stichnot@…>):

Added v3 patch, which makes additional fields available in the
osd_program_editor theme context. "reltimedisplay" and "rellengthdisplay"
are the equivalent to "timedisplay" and "lengthdisplay" with the current
cutlist applied. "fulltimedisplay" has the pattern "timedisplay
(reltimedisplay of rellengthdisplay)", e.g.:

{{{
0:16:23.09 (12:35 of 42:34)
}}}

The nice thing here is that while editing, you can see a running summary
of how much of the recording is left over after the cutlist is applied.

The patch includes a sample usage in default-wide/osd.xml.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8631#comment:3>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Nov 23, 2010, 1:19 PM

Post #5 of 16 (520 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+---------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: mdean
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------------------------+---------------------------

Comment (by tralph):

(In [27326]) Several changes to fix the current position and duration of
the playback OSD
* Start using the currently displayed video timecode for the OSD position
instead of frame number and total frames which is inaccurate.
* Use FFmpeg duration for pre-recorded and video playback length. LiveTV
is already correct since it uses the actual recording times but in-
progress recordings still uses frames written and fps which is obviously
wrong for variable framerate and repeat frame material. The problem with
in-progress duration should be able to be fixed by using recording times
like livetv does. An update to mythplayer and the recorder class will be
necessary.
* Refactor and clean-up some timestamp/timecode handling.

Refs #8631.

Fixes #9109.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8631#comment:4>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Nov 25, 2010, 11:13 PM

Post #6 of 16 (515 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+---------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: mdean
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------------------------+---------------------------

Comment (by markk):

I'm going to go 'on record' and state that I don't think this patch should
be committed.

Firstly, I personally find it counterintuitive to display a different
program duration (or position) from the actual, known value. The potential
for confusion is huge.

Secondly, any confusion can only be mitigated by themers competently using
the extra information available. Given that this is only likely to be a
niche feature, I can see few themes actually doing that.

Finally, it adds a level of complexity to the playback code that we could
really do without. We are trying to make this code simpler and more
understandable and the 'cost' here does not outweigh the 'benefit' in my
opinion.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8631#comment:5>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Nov 27, 2010, 5:37 PM

Post #7 of 16 (514 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

noreply at mythtv

Feb 18, 2012, 11:44 PM

Post #8 of 16 (359 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+--------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - General | Version:
Severity: medium | Unspecified
Keywords: | Resolution:
| Ticket locked: 0
------------------------------------------------+--------------------------
Changes (by wagnerrp):

* owner: mdean => stichnot
* type: enhancement => Developer Task

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Feb 19, 2012, 10:37 AM

Post #9 of 16 (348 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
------------------------------------------------+--------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Video Playback | Version:
Severity: medium | Unspecified
Keywords: | Resolution:
| Ticket locked: 0
------------------------------------------------+--------------------------
Changes (by stichnot):

* component: MythTV - General => MythTV - Video Playback
* milestone: unknown => 0.26

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:8>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 12, 2012, 12:02 PM

Post #10 of 16 (325 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
----------------------------------------+-----------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Video Playback | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------+-----------------------------

Comment (by Jim Stichnoth <jstichnoth@…>):

In [changeset:769059b1f85af7963574cff0d14c74e387ab2422/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="769059b1f85af7963574cff0d14c74e387ab2422"
Add functions for converting between pre- and post-cutlist frame numbers.

Refs #8631. These functions are not actually used anywhere yet.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:9>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 12, 2012, 6:36 PM

Post #11 of 16 (328 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
----------------------------------------+-----------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Video Playback | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------+-----------------------------

Comment (by Jim Stichnoth <jstichnoth@…>):

In [changeset:990e579f724bb2d1af87be98028ad664a5795bc0/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="990e579f724bb2d1af87be98028ad664a5795bc0"
Add new OSD theme strings for cutlist-adjusted times and durations.

The following strings are added, related to the corresponding string
without the "rel" prefix: relsecondsdisplayed, reltotalseconds,
relposition, reldescription, relplayedtime, reltotaltime,
relremainingtime, relbehindtime.

In addition, a progress bar called "relposition" is added, which is
the cutlist-adjusted version of the "position" progress bar.

Note: MythPlayer::calcSliderPos() isn't indented properly so that the
diffs are more apparent. That will be fixed.

Refs #8631.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:10>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 12, 2012, 8:03 PM

Post #12 of 16 (323 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
----------------------------------------+-----------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Video Playback | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------+-----------------------------

Comment (by Jim Stichnoth <jstichnoth@…>):

In [changeset:f0b202909eaeb963a6c3648f9eb45ab3e95ba159/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="f0b202909eaeb963a6c3648f9eb45ab3e95ba159"
Take the cutlist into account when seeking during playback.

Cut regions are honored when calculating exactly where to jump.

Temporarily, the "INFOWITHCUTLIST" key binding is added for the
Arbitrary Seek functionality. By default, "INFO" will jump to an
absolute (non cutlist adjusted) point in the recording, whereas
"INFOWITHCUTLIST" with do a cutlist-adjusted jump. This can be
removed when we work out how to allow the playback progress bar to
convey cutlist information.

Refs #8631.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:11>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Apr 12, 2012, 8:14 PM

Post #13 of 16 (325 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

#8631: Treat cutlists like lossless transcoding
----------------------------------------+-----------------------------
Reporter: Jim Stichnoth <stichnot@…> | Owner: stichnot
Type: Developer Task | Status: assigned
Priority: minor | Milestone: 0.26
Component: MythTV - Video Playback | Version: Unspecified
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------------+-----------------------------

Comment (by Jim Stichnoth <jstichnoth@…>):

In [changeset:ed316911fd32bf31def19705adc1057f6b0dc9d1/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="ed316911fd32bf31def19705adc1057f6b0dc9d1"
Revert "Fix seeking backwards into a cut region."

This reverts commit 89c34ef6b2e0e8688474ef546b799d54d8ec6242.

This is no longer needed after f0b202909eaeb963a6c3648f9eb45ab3e95ba159.

Refs #8631. Refs #9213.
}}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/8631#comment:12>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

May 6, 2012, 7:01 AM

Post #14 of 16 (312 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

noreply at mythtv

Jul 28, 2012, 6:56 AM

Post #15 of 16 (232 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

noreply at mythtv

Mar 6, 2013, 1:14 PM

Post #16 of 16 (121 views)
Permalink

Re: Ticket #8631: Treat cutlists like lossless transcoding [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads