Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Jun 27, 2010, 7:29 PM

Post #1 of 7 (273 views)
Permalink
Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: greg
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Mlocked: 0
-------------------------------+--------------------------------------------
When scanning for new/missing ROMs, the GameHandler::buildFileList method
checks for handler->validextensions.count() > 0. However, when this field
is generated, it uses the QString::split() method which will always return
a single-element list if the source string has no separator. This means
that when the gameplayers.extensions field is blank, the count() will be 1
instead of zero.

This simple patch fixes it by passing QString::SkipEmptyParts

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 14, 2010, 7:01 PM

Post #2 of 7 (216 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: greg
Type: patch | Status: infoneeded_new
Priority: minor | Milestone: unknown
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Mlocked: 0
-------------------------------+--------------------------------------------
Changes (by robertm):

* status: new => infoneeded_new


Comment:

Can you please be more explicit about what you are attempting to fix? I
just ran a test and an emulator set up with no extensions properly finds
all files in the configured directory, as the tooltip indicates it should.
What is this patch meant to fix?

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 15, 2010, 9:06 AM

Post #3 of 7 (220 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: greg
Type: patch | Status: infoneeded_new
Priority: minor | Milestone: unknown
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Mlocked: 0
-------------------------------+--------------------------------------------

Comment(by mythtv@…):

In my database, the "extensions" column in the gameplayers table does not
have a value for any of the configured emulators. When the code calls the
QString::split() method on an empty string, it will always return a single
element list with the original string (according to the docs and to my
experience using MythTV). When a checked is later done for
handler->validextensions.count() > 0, it will always return that single
element list (which is blank). It then tries to find files with those
extensions (which it will find none), then skips processing that file
(thus never adding it to the m_GameMap list.

if (result.isEmpty())
continue;

The missing information might be related to scanning for new ROMs. When I
go scan for new games without the patch applied, it thinks that every
existing ROM is no longer found and wants to remove it. With the patch, it
correctly finds the existing ROMs and skips them.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 15, 2010, 9:18 AM

Post #4 of 7 (213 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: greg
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Mlocked: 0
-------------------------------+--------------------------------------------
Changes (by robertm):

* status: infoneeded_new => new


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jul 15, 2010, 9:18 AM

Post #5 of 7 (214 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: robertm
Type: patch | Status: assigned
Priority: minor | Milestone: unknown
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Mlocked: 0
-------------------------------+--------------------------------------------
Changes (by robertm):

* owner: greg => robertm
* status: new => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 11, 2010, 10:42 PM

Post #6 of 7 (167 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: robertm
Type: patch | Status: assigned
Priority: minor | Milestone: 0.24
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
-------------------------------+--------------------------------------------
Changes (by robertm):

* milestone: unknown => 0.24


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 20, 2010, 1:17 PM

Post #7 of 7 (155 views)
Permalink
Re: Ticket #8613: MythGame fails to find ROMs when "extensions" field is blank in DB [In reply to]

#8613: MythGame fails to find ROMs when "extensions" field is blank in DB
-------------------------------+--------------------------------------------
Reporter: mythtv@… | Owner: robertm
Type: patch | Status: closed
Priority: minor | Milestone: 0.24
Component: Plugin - MythGame | Version: 0.23-fixes
Severity: medium | Resolution: fixed
Keywords: | Ticket locked: 0
-------------------------------+--------------------------------------------
Changes (by robertm):

* status: assigned => closed
* resolution: => fixed


Comment:

Fixed in r25779.

MythGame: Fix scan when extensions field is left empty with a patch from
mythtv A T pasher. Thanks for the patch and sorry for the delay in
applying it.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8613#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.