Mailing List Archive: MythTV: Commits

Ticket #7525: Optimize Pulse handling in MythUI

Index | Next | Previous | View Threaded

mythtv at cvs

Nov 8, 2009, 8:58 AM

Post #1 of 10 (672 views)
Permalink

Ticket #7525: Optimize Pulse handling in MythUI

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+------------------------------
Reporter: danielk | Owner: danielk
Type: task | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: head
Severity: medium | Mlocked: 0
---------------------------------------------+------------------------------
There are three things wrong here:
* Both HandleMovementPulse and HandleAlphaPulse are dependent on
being called at a particular frequency to create a smooth animation.
Instead the alpha and movement should progress based on time elapsed.
* Both HandleMovementPulse and HandleAlphaPulse unconditionally request a
repaint, even if the alpha and/or position is unchanged.
* Pulse() is called for all children, whether they need a pulse or not.
Only children needing a pulse or containing children needing a pulse
should be called. If UI elements need a pulse the pulse time should be
shut-off.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7525>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Jan 24, 2010, 8:34 PM

Post #2 of 10 (560 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+------------------------------
Reporter: danielk | Owner: danielk
Type: task | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: head
Severity: medium | Mlocked: 0
---------------------------------------------+------------------------------

Comment(by Jim Stichnoth <stichnot@…>):

I implemented the third item -- only traverse children that need to pulse.
There are actually three independent pulse attributes: movement, alpha,
and custom. Each attribute is tracked as a boolean indicating whether a
pulse check is needed for the next "frame". Any time the pulse state
changes (e.g. start/stop movement/animation) or a child is added/deleted,
the state change is propagated up the tree. The top-level
MythUIType::Pulse() method always clears the custom pulse attribute, so
any overridden Pulse() method needs to explicitly set the custom pulse
attribute appropriately *after* calling MythUIType::Pulse().

I'm attaching the patch, but keep in mind that after applying the patch in
#7953, idle frontend CPU utilization on a lowly ION frontend is down to
about 1%, maybe as high as 2%, so there's not a whole lot of performance
left to be gained.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7525#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Mar 15, 2010, 6:37 AM

Post #3 of 10 (502 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

mythtv at cvs

May 19, 2010, 8:06 AM

Post #4 of 10 (407 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

mythtv at cvs

May 30, 2010, 5:55 AM

Post #5 of 10 (367 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

mythtv at cvs

Aug 17, 2010, 7:55 PM

Post #6 of 10 (271 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

mythtv at cvs

Aug 25, 2010, 7:00 AM

Post #7 of 10 (251 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+------------------------------
Reporter: danielk | Owner: danielk
Type: enhancement | Status: assigned
Priority: minor | Milestone: 0.24
Component: MythTV - User Interface Library | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
---------------------------------------------+------------------------------

Comment (by Jim Stichnoth <stichnot@…>):

Updated with v3 patch. The previous versions had a bug where Pulse() was
called on children only if some child has a custom pulse set. This e.g.
cause the "Recording..." text in the Arclight PBB not to be alphapulsed.

The patch still has a potential problem when m_Visible is changed from
false to true. In this case, the whole subtree should probably be
reexamined to see what needs to be pulsed. I haven't seen any actual
problems so far, though.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7525#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Sep 10, 2010, 6:17 PM

Post #8 of 10 (232 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+------------------------------
Reporter: danielk | Owner: danielk
Type: enhancement | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - User Interface Library | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
---------------------------------------------+------------------------------
Changes (by danielk):

* milestone: 0.24 => 0.25

Comment:

While this does provide a benefit, it is a bit invasive to be applying
during feature freeze.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7525#comment:7>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

noreply at mythtv

Feb 15, 2012, 9:08 AM

Post #9 of 10 (46 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+--------------------------
Reporter: danielk | Owner: stichnot
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
---------------------------------------------+--------------------------
Changes (by danielk):

* owner: danielk => stichnot
* milestone: 0.25 => unknown

Comment:

Jim, I'll leave it up to you whether to commit post 0.25 freeze or
abandon.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/7525#comment:9>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

noreply at mythtv

Feb 15, 2012, 5:02 PM

Post #10 of 10 (40 views)
Permalink

Re: Ticket #7525: Optimize Pulse handling in MythUI [In reply to]

#7525: Optimize Pulse handling in MythUI
---------------------------------------------+---------------------------
Reporter: danielk | Owner: stichnot
Type: enhancement | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: head
Severity: medium | Resolution: Won't Fix
Keywords: | Ticket locked: 0
---------------------------------------------+---------------------------
Changes (by stichnot):

* status: assigned => closed
* resolution: => Won't Fix

Comment:

To my recollection, this ticket was created as a result of the often-
reported complaint of 7% or 14% CPU usage when the frontend is "idle",
before the real reason was discovered in #7953.

Given that this is no longer a problem, the fix to issue 3 adds too much
complexity for too little performance gain. See the discussion in
http://www.gossamer-threads.com/lists/mythtv/dev/448052 for an idea of the
problems that came up.

Issues 1 and 2 (especially issue 1) may be interesting for a non
performance related result, but that can be in a new ticket.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/7525#comment:10>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads