Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #7659: Determine audio properties from recorded file instead of schedule data

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Nov 25, 2009, 6:40 AM

Post #1 of 12 (628 views)
Permalink
Ticket #7659: Determine audio properties from recorded file instead of schedule data

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - General | Version: head
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------
Hi All,

I found that the audio properties (e.g. Dolby, Stereo, etc) in my schedule
data were often different from the actual content of my recorded files.
This is a patch to update the audio properties after a recording finishes
with the values that are in the file as opposed to the ones passed from
the listings source.

The patch includes a new class called AudioPropsGenerator which works
similarly to PreviewGenerator. It takes a ProgramInfo and will then
determine the AudioProperties in the current thread or a new thread. I've
also updated tv_rec.cpp to call this Generator after a recording ends.
Finally, each decoder (avformatdecoder, nuppeldecoder, etc) is responsible
for doing the actual work of determining the audio properties. The
generator then takes the new value and updates the db.

There are a few open issues (mainly around my ignorance):[[BR]]

1. I don't know too much about audio processing, so I guessed that the
speaker layout is a good proxy for determining the audio props. This
seems to prove true for my test cases, but I don't know if this applies to
everyone.
[[BR]]

2. I don't know too much about the hard hearing properties so I guessed on
that too.
[[BR]]

3. I don't know what the visual impair property is so I ignored it
[[BR]]

4. I don't have any recorders that use the nuppledecoder so I wrote the
code, but I couldn't test it.
[[BR]]

Thanks! [[BR]]

Doug

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Apr 15, 2010, 10:42 AM

Post #2 of 12 (461 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------
Changes (by robertm):

* owner: ijr => danielk
* component: MythTV - General => MythTV - Recording


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

May 24, 2010, 7:44 AM

Post #3 of 12 (412 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------
Changes (by danielk):

* type: patch => enhancement


Comment:

Doug, this is an interesting enhancement. Can you update it to apply
against jya's http://svn.mythtv.org/trac/browser/branches/mythtv-hdaudio
branch (or trunk if you see this after the merge of that branch to trunk)
?

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

May 24, 2010, 3:36 PM

Post #4 of 12 (404 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------

Comment(by doug@…):

Hi, [[BR]]

I'm a little scared of moving to the hdaudio branch, but I've been keeping
this patch up to date locally so when the hdaudio branch is merged with
trunk I'll be sure to post here with my changes.
[[BR]]

Thanks! [[BR]]

D

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

May 26, 2010, 8:23 AM

Post #5 of 12 (402 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Mlocked: 0
----------------------------------+-----------------------------------------

Comment(by Doug Haber <doug@…>):

Hi, [[BR]]
[[BR]]
I attached a new patch that applies against 24875 (post hdaudio merge).
There's lots of room for improvement (e.g. I didn't improve on 1-4 above,
and the AudioGenerator is basically a copy of the PreviewGenerator - they
should probably share a common base class). But hopefully this can be a
start. [[BR]]

[[BR]]

Thanks! [[BR]]

D

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 11, 2010, 9:54 PM

Post #6 of 12 (315 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by robertm):

* status: new => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 12, 2010, 7:30 AM

Post #7 of 12 (314 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: jyavenard
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by danielk):

* owner: danielk => jyavenard


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 26, 2010, 3:37 PM

Post #8 of 12 (292 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by jyavenard):

* owner: jyavenard =>
* status: assigned => new


Comment:

I don't think I'm the best one to handle this one..

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:7>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Aug 26, 2010, 3:38 PM

Post #9 of 12 (291 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: stuartm
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Recording | Version: head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by robertm):

* owner: => stuartm
* status: new => assigned


Comment:

Hot Potato

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:8>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Sep 10, 2010, 12:09 PM

Post #10 of 12 (266 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: stuartm
Type: enhancement | Status: accepted
Priority: minor | Milestone: 0.25
Component: MythTV - Recording | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by stuartm):

* status: assigned => accepted
* version: head => Trunk Head
* milestone: unknown => 0.25


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:9>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 22, 2010, 1:21 PM

Post #11 of 12 (223 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+-----------------------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: assigned
Priority: minor | Milestone: 0.25
Component: MythTV - Recording | Version: Trunk Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
----------------------------------+-----------------------------------------
Changes (by stuartm):

* owner: stuartm => danielk
* status: accepted => assigned


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7659#comment:11>
MythTV <http://www.mythtv.org/>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


noreply at mythtv

Aug 15, 2011, 11:58 AM

Post #12 of 12 (117 views)
Permalink
Re: Ticket #7659: Determine audio properties from recorded file instead of schedule data [In reply to]

#7659: Determine audio properties from recorded file instead of schedule data
----------------------------------+----------------------------
Reporter: doug@… | Owner: danielk
Type: enhancement | Status: closed
Priority: minor | Milestone: 0.25
Component: MythTV - Recording | Version: Trunk Head
Severity: medium | Resolution: Won't Fix
Keywords: | Ticket locked: 0
----------------------------------+----------------------------
Changes (by danielk):

* status: assigned => closed
* resolution: => Won't Fix


Comment:

Doug, while interesting I don't think it makes sense as is. The audio
properties of a recording can change during the recording. To do this
properly I think we need to note the audio properties in the entire file
during something like the commflag run and then determine the static audio
properties based on those properties in effect through most of the
recording.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/7659#comment:12>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://www.mythtv.org/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.