Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing

  

 
MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Apr 19, 2009, 2:38 AM

Post #1 of 16 (2352 views)
Permalink
Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin [at] gmail | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: 0.22
Component: MythTV - General | Version: unknown
Severity: medium | Mlocked: 0
--------------------------------+-------------------------------------------
Keybindings for NEXT/PREV SOURCE and NEXT/PREV INPUT and NEXT/PREV CARD do
nothing. The functions work from the menu. It doesn't matter what key is
bound to the function. Started failing at rev '''19483.'''

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Apr 23, 2009, 10:01 AM

Post #2 of 16 (2246 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin [at] gmail | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: 0.22
Component: MythTV - General | Version: unknown
Severity: medium | Resolution:
Mlocked: 0 |
--------------------------------+-------------------------------------------

Comment(by restorin [at] gmail):

Oops! Rev 19297 is the last good rev. The next rev is 19417 which fails.
19417 was a huge changeset that seems to rework the PIP stuff among other
things.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Sep 25, 2009, 11:02 AM

Post #3 of 16 (2052 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin [at] gmail | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Resolution:
Mlocked: 0 |
--------------------------------+-------------------------------------------
Changes (by danielk):

* priority: major => trivial
* severity: medium => low
* milestone: 0.22 => unknown


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 10, 2009, 2:55 PM

Post #4 of 16 (2015 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by skd5aner <skd5aner@…>):

Was troubleshooting this today with the help of sphery on IRC. I can
confirm that this is still a problem in .22-fixes (as of revision r22760).
None of these bindings do anything within the frontend during TV playback.

Please let me know if there's anything I can provide to help
diagnose/troubleshoot the issue.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 13, 2009, 2:33 PM

Post #5 of 16 (1990 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by anonymous):

I have the same problem (0.22). I can still switch sources the long way
through the menu. Since I switch sources frequently, it's a pain to be
constantly doing it this way.

I get no error messages or indications in logs or anywhere else. Shouldn't
be too hard to fix, IMHO.

Why priority == trivial? It's not trivial to me and my wife! :)

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 13, 2009, 11:32 PM

Post #6 of 16 (1983 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by Dibblah):

Have you tried the (new in 0.22) option "Browse All Channels"?

http://mythtv.org/pipermail/mythtv-dev/2009-January/064286.html

Not saying that this is not a bug, just that the switch sources button is
(now) probably not the easiest way to do this.

If you have multiple backends, this may significantly slow down channel
changing.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 14, 2009, 2:09 PM

Post #7 of 16 (1970 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by anonymous):

Tried the browse all channels function - it works great. Now I'm using
that, thx.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 18, 2009, 10:03 AM

Post #8 of 16 (1899 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by skd5aner <skd5aner@…>):

Replying to [comment:5 Dibblah]:
> Have you tried the (new in 0.22) option "Browse All Channels"?
>
> http://mythtv.org/pipermail/mythtv-dev/2009-January/064286.html
>
> Not saying that this is not a bug, just that the switch sources button
is (now) probably not the easiest way to do this.
>
> If you have multiple backends, this may significantly slow down channel
changing.

Correct - for day to day use, that feature is all that is needed (and was
long overdue, thanks for including it!!!). But, being able to switch
inputs/cards/sources is extremely helpful when diagnosing/configuring
individual tuners.

Regardless, I'll keep further discussion off the ticket. Thanks!

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:7>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 1, 2009, 4:15 PM

Post #9 of 16 (1777 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by bam <mybigspam@…>):

This is a typo bug. Patch to fix NEXT/PREV CARD:
{{{
--- libs/libmythtv/tv_play.cpp (revision 22942)
+++ libs/libmythtv/tv_play.cpp (working copy)
@@ -4567,7 +4567,7 @@
}
else if (has_action("NEXTFAV", actions) && islivetv)
ChangeChannel(ctx, CHANNEL_DIRECTION_FAVORITE);
- else if (has_action("SWITCHARDS", actions) && islivetv)
+ else if (has_action("NEXTCARD", actions) && islivetv)
SwitchCards(ctx);
else if (has_action("GUIDE", actions))
EditSchedule(ctx, kScheduleProgramGuide);
}}}
Then bind the "NEXTCARD" action to somewhat key in "Edit Keys" frontend's
menu.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:8>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 9, 2009, 1:21 PM

Post #10 of 16 (1714 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by mdean):

Can someone test the attached patch, mythtv-6472-fix_nextcard_action.patch
, please. I'm lacking sources and inputs to fully test. It should fix
NEXTCARD, NEXTINPUT, PREVSOURCE and NEXTSOURCE . (There are/were no
PREVCARD and PREVINPUT bindings in MythTV.) Note that you may need to
bind keys to the specified actions. Thanks.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:9>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 23, 2009, 12:10 PM

Post #11 of 16 (1587 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by mdean):

(In [23004]) Refs #6472. Fix NEXTSOURCE, PREVSOURCE, NEXTINPUT, and
NEXTCARD key bindings. These seem to have been broken in the mythtv-pip
branch or when mythtv-pip was merged to mythtv-vid in [15601]. Then, the
breakage entered trunk when mythtv-vid was merged to trunk in [19417]
(prior to the 0.22 release).

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:10>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 26, 2009, 3:28 PM

Post #12 of 16 (1546 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by skd5aner <skd5aner@…>):

mdean - sorry for not reporting back earlier on the ticket, but I did test
the patch prior to your last commit. However - during testing I'm getting
complete loss of input/response from mythfrontend when I use the
"NEXTSOURCE" bindining while watching Live TV. All keyboard input works
fine, but when I hit "Y" (nextsource), from that point on, no matter what
I press, nothing happens within the frontend. I can succesfully alt-tab,
and input works outside of myth. The only way to restore functionality is
to kill mythfrontend and restart it.

As for the other bindings, I can say that NEXTCARD works and NEXTINPUT
appears to work (however I don't have any cards with multiple inputs). I
can tell you that NEXTINPUT doesn't cause any ill effects from my
(limited) testing, and appeared to responde to the binding post-patch.

I did report this in IRC a few weeks ago, but wanted to place it with this
ticket so it didn't get lost. If a separate ticket is warrented for the
lack of response after hitting NEXTSOURCE, please let me know - otherwise,
let me know if there's any more details you'd like me to place on this
ticket to troubleshoot that symptom.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:11>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 26, 2009, 4:35 PM

Post #13 of 16 (1540 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: new
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Mlocked: 0
--------------------------------+-------------------------------------------

Comment(by mdean):

Matt, thanks for the comment. I also meant to thank you for the testing
when I committed the fix to trunk, but was distracted by too many other
things I was working on.

Anyway, as far as the NEXTSOURCE issue, I'd need a good (with symbols)
backtrace to say for sure, but I'm almost positive the problem exists in
the TV::SwitchSource() function and is unrelated to the keybinding fix
(though the binding allows you to access that function). I plan to test
it eventually, but if you can get a backtrace of the hung mythfrontend
process, feel free to submit a separate ticket for the issue.

Probably should have mentioned some of that to you earlier, but it's been
a busy couple of weeks. I'll get the fix for this issue committed to
-fixes soon.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:12>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Dec 29, 2009, 9:28 PM

Post #14 of 16 (1484 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: closed
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Resolution: fixed
Mlocked: 0 |
--------------------------------+-------------------------------------------
Changes (by mdean):

* status: new => closed
* resolution: => fixed


Comment:

(In [23032]) Fixes #6472. Fix NEXTSOURCE, PREVSOURCE, NEXTINPUT, and
NEXTCARD key bindings. Backports [23004] from trunk.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:13>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Mar 9, 2010, 11:09 PM

Post #15 of 16 (1046 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: closed
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Resolution: fixed
Mlocked: 0 |
--------------------------------+-------------------------------------------

Comment(by mythtv@…):

I can confirm this. After hitting "Y" there is no other way out then to
kill mythfrontend. I'm running rev 23110 from 0.22-fixes.


Replying to [comment:11 skd5aner <skd5aner@…>]:
> mdean - sorry for not reporting back earlier on the ticket, but I did
test the patch prior to your last commit. However - during testing I'm
getting complete loss of input/response from mythfrontend when I use the
"NEXTSOURCE" bindining while watching Live TV. All keyboard input works
fine, but when I hit "Y" (nextsource), from that point on, no matter what
I press, nothing happens within the frontend. I can succesfully alt-tab,
and input works outside of myth. The only way to restore functionality is
to kill mythfrontend and restart it.
>

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:14>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Apr 27, 2010, 2:10 PM

Post #16 of 16 (738 views)
Permalink
Re: Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing [In reply to]
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: closed
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Resolution: fixed
Mlocked: 0 |
--------------------------------+-------------------------------------------

Comment(by mdean):

(In [24274]) Fix a deadlock in TV::SwitchSource() that occured when using
the NEXTSOURCE/PREVSOURCE key bindings to switch sources.

The code in TV::timerEvent() was holding a lock, causing a deadlock when
TV::SwitchSource() requested the PlayerContext. This changes
TV::SwitchSource() to work like the related TV::SwitchCards() and
TV::ToggleInputs functions by using the PlayerContext that
TV::timerEvent() passes through TV::ProcessKeypress() and, finally, to
TV::ActivePostQHandleAction(), which calls TV::SwitchSource().

This seems to have been broken in the mythtv-vid branch, but the code was
unreachable/untestable due to broken key bindings (which were fixed for
#6472).

Refs #6472. Fixes #8190. Thanks to jafa for finally getting a backtrace.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:15>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.