Mailing List Archive: MythTV: Commits

Ticket #8266: memory leaks in backend

1 2

View All

Index | Next | Previous | View Threaded

mythtv at cvs

Mar 31, 2010, 9:22 PM

Post #1 of 26 (1470 views)
Permalink

Ticket #8266: memory leaks in backend

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------
Some valgrind logs which could point to memory leaks in backend

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Mar 31, 2010, 11:35 PM

Post #2 of 26 (1451 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------
Changes (by Dibblah):

* status: new => infoneeded_new

Comment:

Nothing significant that I can see in this valgrind. Please try with
--leak-check=full --show-reachable=yes

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 3:41 AM

Post #3 of 26 (1442 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by anonymous):

It says memory was _definitely_ lost.
Those were the recommended settings from the mythtv-users list.
After the weekend I will be running 0.23-fixes if all goes well.
I can give it another try after that.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 3:46 AM

Post #4 of 26 (1443 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by anonymous):

It says 1.2Kb was definitely lost ... all leaks should and will be fixed,
but that's a ridiculously tiny amount.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 3:51 AM

Post #5 of 26 (1445 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by anonymous):

Heh, and it's wrong anyway. e.g. the loss in DVBCam::SetPMT(), the pointer
is assigned to PMTAddList or PMTList and deleted again when Stop() is
called from the destructor. No leak there.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 4:01 AM

Post #6 of 26 (1442 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

So now the leak is not worthy?
There were 2 logiles if I am right. Please confirm.
Over time (weeks) mythbackend grows to 100's of megs on my tiny Epia box.
This new x86_64 setup is slightly more powerfull so it enables me to do a
valgrind.
Part of the reason to invest was this research.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 4:03 AM

Post #7 of 26 (1444 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: infoneeded_new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by anonymous):

> Heh, and it's wrong anyway

So now valgrind is not trustworthy?
You puzzle me.
Comments about memory leaks, complete with graphs and ps aux dumps were
ignored because we needed valgrind.
Now we have valgrind and it is not reliable.
This in the light that valgrind make a dual core 2.7 Ghz box have it's dvb
buffers overflow because of valgrind. I.e.: still recordings are useless,
despite the upgrade.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:6>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 4:06 AM

Post #8 of 26 (1445 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 1
------------------------------+---------------------------------------------
Changes (by cpinkham):

* status: infoneeded_new => new
* mlocked: 0 => 1

Comment:

Trac is not a discussion list.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:7>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 9:57 AM

Post #9 of 26 (1427 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 1
------------------------------+---------------------------------------------

Comment(by stuartm):

(In [23893]) Backport [23892] to 0.22-fixes, fix a memory leak in
ChannelBase. Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:8>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 9:59 AM

Post #10 of 26 (1428 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 1
------------------------------+---------------------------------------------

Comment(by stuartm):

(In [23894]) Backport [23892] to 0.23-fixes, fix a memory leak in
ChannelBase. Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:9>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 1, 2010, 3:10 PM

Post #11 of 26 (1415 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

mythtv at cvs

Apr 3, 2010, 8:46 AM

Post #12 of 26 (1367 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

Decided not to upgrade to 0.23 yet as it has not reached -fixes status
yet.
Instead I will gater some more numbers with 0.22-fixes to see what the
impact of the recent leak fix is. I am using svn 23912.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:11>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 4, 2010, 4:49 PM

Post #13 of 26 (1347 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by janne):

(In [23991]) fix leaking streamdata in the DVBRecorder. Refs #8266

This leak is caused by special handling of virtual functions in the
destructor of the base class. Only functions of the base class are
called.
This seems to leak at least a couple of kBytes per recording.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:12>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 5, 2010, 4:17 AM

Post #14 of 26 (1341 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by janne):

(In [24000]) cosmetic: rename member _mpeg_stream_data to _stream_data in
firewirerecorder

prepares the move of stream_data handling to the base class DTVRecorder
to fix the leak of _stream_data in various recorders. Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:13>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 5, 2010, 4:17 AM

Post #15 of 26 (1344 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by janne):

(In [24001]) cosmetic: use _stream_data instead of data in various
SetStreamData methods

Preparation for basic stream_data handling in the base class
DTVRecorder. Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:14>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 5, 2010, 4:18 AM

Post #16 of 26 (1342 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by janne):

(In [24002]) move basic stream data handling to DTVRecorder

This fixes leaking stream data in various recorder on destruction.
The SetStreamData(NULL) call in ~DTVRecorder just calls its own
SetStreamData() which does nothing. Reverts the quick fix for the
DVBRecorder in [23991]. Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:15>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 5, 2010, 4:24 AM

Post #17 of 26 (1337 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

The first fix (using early figures) shows a slight decrease in RSS
growth/day.
In a few days we'll do a fresh build of 0.22-fixes to test this new leak
fix.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:16>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 5, 2010, 7:44 AM

Post #18 of 26 (1349 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by janne):

(In [24004]) backports [23991] from trunk and fix similar leaks in other
decoders

the full fix/cleanup in [24002] in trunk is too large
the change in mpegrecorder is probably not necessary but shouldn't harm
Refs #8266

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:17>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 13, 2010, 6:24 AM

Post #19 of 26 (1016 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

Runnign 0.22-fixes svn 24015.
After a few days I see no real difference in memory size growth versus the
previous build (pre-24000).
It grows 10Megs a day or so.
I'll try and do a valgrind run soon.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:18>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 13, 2010, 8:57 AM

Post #20 of 26 (1016 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by stuartm):

The recorder leak wasn't backported to 0.22-fixes, so I'm not surprised
that you see no difference.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:19>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 17, 2010, 8:16 AM

Post #21 of 26 (948 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

Replying to [comment:19 stuartm]:
> The recorder leak wasn't backported to 0.22-fixes, so I'm not surprised
that you see no difference.

OK, so I upgraded to 0.23-fixes svn.24175.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:20>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 21, 2010, 3:14 AM

Post #22 of 26 (903 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: new
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Mlocked: 0
------------------------------+---------------------------------------------

Comment(by udovdh@…):

The first few figures appear to indicate that 0.23-fixes ~ halves the
leaked RSS memory amount versus 0.22-fixes. We're at less than 10
megs/day.
So the 2400x changes really did change things?
Congratulations!
I'll keep running this 0.23-fixes instance to get some more numbers.
Then we could do valgrind again.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:21>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 22, 2010, 8:49 AM

Post #23 of 26 (876 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

#8266: memory leaks in backend
------------------------------+---------------------------------------------
Reporter: udovdh@… | Owner: ijr
Type: defect | Status: closed
Priority: major | Milestone: unknown
Component: MythTV - General | Version: 0.22-fixes
Severity: medium | Resolution: fixed
Mlocked: 0 |
------------------------------+---------------------------------------------
Changes (by danielk):

* status: new => closed
* resolution: => fixed

Comment:

Fixed in trunk:
{{{
On Thu, 2010-04-22 at 16:34 +0200, Udo van den Heuvel wrote:
%CPU %MEM VSZ RSS TTY STAT START TIME C
> 5.1 2.2 1706748 87208 ? Ssl Apr17 41:00 /usr/bin/myt
> 5.2 2.2 1706748 86804 ? Ssl Apr17 116:20 /usr/bin/myt
> 5.3 2.5 1706748 95612 ? Ssl Apr17 198:05 /usr/bin/myt
> 5.4 2.6 1706748 102480 ? Ssl Apr17 278:57 /usr/bin/myt
> 5.4 2.8 1706748 106516 ? Ssl Apr17 358:35 /usr/bin/myt
}}}

This sample shows zero growth in the memory requested by mythbackend.

It seems you are confused by the meaning of the numbers here so I'll
explain. VSZ is the total size of the libraries, executable, heap, and
stack. This has not grown at all, which means MythTV has not requested any
memory while recording 358 hours of programming per tuner. RSS is the the
resident set, this is the actual RAM that the MythTV process has access
to. This is allocated by the operating system based on what else you have
running. RSS will never grow beyond VSZ.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8266#comment:22>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Apr 22, 2010, 9:01 AM

Post #24 of 26 (877 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

mythtv at cvs

Apr 22, 2010, 9:27 AM

Post #25 of 26 (878 views)
Permalink

Re: Ticket #8266: memory leaks in backend [In reply to]

1 2

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads