Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #7615: MythUI fails to update cache for images in storage groups

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Nov 19, 2009, 2:17 AM

Post #1 of 6 (677 views)
Permalink
Ticket #7615: MythUI fails to update cache for images in storage groups

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: stuartm
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: 0.22
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------
The MythUI code to check whether a cached image is out-of-date only works
with local images (as it checks the modification time of the files). This
check fails for images in storage groups, so these never get updated
(unless the cache is cleared).

The attached patch retrieves the modification time from the backend for
images in storage groups.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Nov 20, 2009, 6:40 AM

Post #2 of 6 (621 views)
Permalink
Re: Ticket #7615: MythUI fails to update cache for images in storage groups [In reply to]

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: stuartm
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: 0.22
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------

Comment(by Robin Hill <myth@…>):

Here's an updated patch. This reduces the number of backend calls by
first checking whether the image is in the memory cache and has a last-
update time less than 2 seconds ago (this value may need fine-tuning but
seemed a good starting point). This prevents repeated calls for every
time the image is used (e.g. for every cover shot in a season directory).

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jan 22, 2010, 3:09 PM

Post #3 of 6 (522 views)
Permalink
Re: Ticket #7615: MythUI fails to update cache for images in storage groups [In reply to]

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: cpinkham
Type: defect | Status: assigned
Priority: minor | Milestone: 0.23
Component: MythTV - User Interface Library | Version: 0.22
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------
Changes (by stuartm):

* owner: stuartm => cpinkham
* status: new => assigned
* milestone: unknown => 0.23


Comment:

Reassigning to Chris as the SG expert.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Mar 3, 2010, 7:15 PM

Post #4 of 6 (466 views)
Permalink
Re: Ticket #7615: MythUI fails to update cache for images in storage groups [In reply to]

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: cpinkham
Type: defect | Status: assigned
Priority: minor | Milestone: 0.24
Component: MythTV - User Interface Library | Version: 0.22
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------
Changes (by cpinkham):

* milestone: 0.23 => 0.24


Comment:

I'm going to push this to 0.24. The only way to fix this without a non-
intrusive
patch is to add some form of RemoteFile::Stat(), but since RemoteFile does
not have
access to the main connection back to the master backend, this would mean
that we
would have to open and close a backend connection for each image we were
checking.

I already have most of a patch completed to move the main backend
connection
into libmythdb so that RemoteFile and libmythui can take advantage of it.
This is
part of a larger project I'm working on to create a directory
caching/monitoring
subsystem in Myth for various reasons. That will eventually be the
solution to
this ticket, so I'm leaving this open for now, but pushing off till 0.24.

The attached patch can not be used because it creates a circular
dependency.
libmyth depends on libmythui, so code in libmythui should not depend on
code in libmyth.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Mar 3, 2010, 7:16 PM

Post #5 of 6 (466 views)
Permalink
Re: Ticket #7615: MythUI fails to update cache for images in storage groups [In reply to]

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: cpinkham
Type: defect | Status: assigned
Priority: minor | Milestone: 0.24
Component: MythTV - User Interface Library | Version: head
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------
Changes (by cpinkham):

* version: 0.22 => head


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615#comment:4>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jun 30, 2010, 10:00 AM

Post #6 of 6 (239 views)
Permalink
Re: Ticket #7615: MythUI fails to update cache for images in storage groups [In reply to]

#7615: MythUI fails to update cache for images in storage groups
-----------------------------------------------+----------------------------
Reporter: Robin Hill <myth@…> | Owner: cpinkham
Type: defect | Status: closed
Priority: minor | Milestone: 0.24
Component: MythTV - User Interface Library | Version: head
Severity: medium | Resolution: fixed
Mlocked: 0 |
-----------------------------------------------+----------------------------
Changes (by cpinkham):

* status: assigned => closed
* resolution: => fixed


Comment:

(In [25230]) Check the last modified timestamp of remote myth:// images so
that we can
refresh them when needed.

Also allow the QUERY_SG_FILEINFO backend command to take the master's IP
address as well as hostname.

In combination with [25229], this fixes #7615 using a different patch that
uses the new RemoteFile::LastModified() to do the check.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7615#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.