Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: MythTV: Commits

Ticket #7633: Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset

 

 

MythTV commits RSS feed   Index | Next | Previous | View Threaded


mythtv at cvs

Nov 21, 2009, 11:06 PM

Post #1 of 4 (567 views)
Permalink
Ticket #7633: Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset

#7633: Default new recording end offset is set to DefaultStartOffset pref, should
be DefaultEndOffset
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: gigem
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - Scheduling | Version: head
Severity: medium | Mlocked: 0
-------------------------------------+--------------------------------------
This seems to have been broken in the transition from ScheduledRecording
to RecordingRule classes (based on my quick check of the SVN logs).

I think this is a trivial fix.

{{{
--- mythtv-trunk/mythtv/libs/libmythtv/recordingrule.cpp (revision
22880)
+++ mythtv-trunk/mythtv/libs/libmythtv/recordingrule.cpp (working
copy)
@@ -26,7 +26,7 @@
m_recPriority(0),
m_prefInput(0),
m_startOffset(gContext->GetNumSetting("DefaultStartOffset", 0)),
- m_endOffset(gContext->GetNumSetting("DefaultStartOffset", 0)),
+ m_endOffset(gContext->GetNumSetting("DefaultEndOffset", 0)),
m_dupMethod(static_cast<RecordingDupMethodType>(
gContext->GetNumSetting("prefDupMethod",
kDupCheckSubDesc))),
m_dupIn(kDupsInAll),
}}}

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7633>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jan 7, 2010, 6:17 AM

Post #2 of 4 (456 views)
Permalink
Re: Ticket #7633: Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset [In reply to]

#7633: Default new recording end offset is set to DefaultStartOffset pref, should
be DefaultEndOffset
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: gigem
Type: defect | Status: new
Priority: minor | Milestone: 0.23
Component: MythTV - Scheduling | Version: head
Severity: medium | Mlocked: 0
-------------------------------------+--------------------------------------
Changes (by stuarta):

* milestone: unknown => 0.23


--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7633#comment:1>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jan 10, 2010, 10:33 AM

Post #3 of 4 (428 views)
Permalink
Re: Ticket #7633: Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset [In reply to]

#7633: Default new recording end offset is set to DefaultStartOffset pref, should
be DefaultEndOffset
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: gigem
Type: defect | Status: closed
Priority: minor | Milestone: 0.23
Component: MythTV - Scheduling | Version: head
Severity: medium | Resolution: fixed
Mlocked: 0 |
-------------------------------------+--------------------------------------
Changes (by mdean):

* status: new => closed
* resolution: => fixed


Comment:

(In [23108]) Fix the DefaultEndOffset in recordingrule.cpp (a copy/paste
typo from [21745]). Fixes #7633.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7633#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits


mythtv at cvs

Jan 10, 2010, 7:01 PM

Post #4 of 4 (431 views)
Permalink
Re: Ticket #7633: Default new recording end offset is set to DefaultStartOffset pref, should be DefaultEndOffset [In reply to]

#7633: Default new recording end offset is set to DefaultStartOffset pref, should
be DefaultEndOffset
-------------------------------------+--------------------------------------
Reporter: mythtv@… | Owner: gigem
Type: defect | Status: closed
Priority: minor | Milestone: 0.23
Component: MythTV - Scheduling | Version: head
Severity: medium | Resolution: fixed
Mlocked: 0 |
-------------------------------------+--------------------------------------

Comment(by mdean):

(In [23110]) Fixes #7633. Fix the DefaultEndOffset in recordingrule.cpp.
Backports [23108] from trunk.

Thanks to Rob Mueller for the ticket and patch.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/7633#comment:3>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

MythTV commits RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.