mythtv at cvs
Oct 12, 2008, 1:47 PM
Post #1 of 1
(75 views)
Permalink
|
|
Ticket #5818: Patch for 'filemarkup table is inefficient'
|
|
#5818: Patch for 'filemarkup table is inefficient'
----------------------------------+-----------------------------------------
Reporter: simonwalls[at]yahoo.com | Owner: ijr
Type: enhancement | Status: new
Priority: minor | Milestone: 0.22
Component: mythtv | Version: 0.21-fixes
Severity: low | Mlocked: 0
----------------------------------+-----------------------------------------
This is 'the start' of a patch for the minor issue in Ticket #5109 with
the filemarkup table containing the full pathname of the file for every
single mark. Particularly when MARK_GOP_BYFRAME is in use, eg. for
mpeg-2's, there are many thousands of marks for a movie file.
This patch changes the usage of filemarkup.filename to be the intid of the
video (as found in videometadata.intid). It is against 0.21-fixes SVN
17450.
It does not purport to be complete and suitable for inclusion, since to do
it properly, a field name change would be required in the database schema
(filemarkup.filename -> filemarkup.intid) complete with upgrade of the
schema number etc etc in the appropriate file(s) eg.
mythvideo/dbcheck.cpp. It might be the case, although I don't think so at
this time, that some other plugins require changes.
However, the basics work despite those limitations and is in use on my
main system. I'm raising the ticket to get the patch recorded and
available to others, particularly the original submitter of Ticket #5109.
When I have more time, I can look at ensuring this patch is complete (all
other plugins do or don't require mods) and then including the date of
last rebuild of filemarkup in the videometadata table, to aid the other
latent problem I wrote of in Ticket #5109.
My database went from 63Mb to 74Mb with 33 mpeg2 files (including 12
movies) added to the filemarkup table (162,000 rows in table). Without the
patch an almost identical size increase occurred with only 3 movies
indexed.
A script to rebuild the seektables of all .mpg videos using mythtranscode
(with mpeg2 option) is included. (The original contents of filemarkup are
not dropped, they are retained in the table but will not be found, since
the access to the filemarkup table now looks for the numeric 'intid' from
the videometadata table, in that column).
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/5818>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits[at]mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
|
