Mailing List Archive: MythTV: Commits

Ticket #1293: Need to check if both seriesid and programid exists

Index | Next | Previous | View Threaded

mythtv at cvs

Feb 15, 2006, 11:04 AM

Post #1 of 9 (1868 views)
Permalink

Ticket #1293: Need to check if both seriesid and programid exists

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: defect | Status: new
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium |
---------------------+------------------------------------------------------
For "This show was recorded", both seriesid and programid need to exist in
order to be able to use it for the check.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 23, 2006, 4:13 PM

Post #2 of 9 (1789 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: defect | Status: new
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution:
---------------------+------------------------------------------------------
Comment (by tephra [at] gmail):

Since this bug only cropped up in the weeks before .19 was released,
shouldn't it be part of the .19 fixes?

see #1334 for my version of the problem.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 23, 2006, 5:05 PM

Post #3 of 9 (1781 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: patch | Status: new
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution:
---------------------+------------------------------------------------------
Changes (by Robert Tsai <rtsai1111>):

* type: defect => patch

Comment:

I think the current SVN checks for programid/seriesid. Looking at
ProgramInfo::ForgetHistory, I think that oldrecorded.duplicate might need
to be checked as well. See patch. This also has the (positive?) side-
effect that non-AutoExpired recordings are no longer marked as "This
showing was recorded".

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 23, 2006, 5:33 PM

Post #4 of 9 (1788 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: patch | Status: new
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution:
---------------------+------------------------------------------------------
Comment (by tephra [at] gmail):

Hi Robert,

I tried the patch, but am still getting shows in the future displaying as
"Already recorded"

Do you need anything from me? screenshots/db rows?

Cheers
Dave

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 23, 2006, 5:56 PM

Post #5 of 9 (1796 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

mythtv at cvs

Feb 23, 2006, 6:00 PM

Post #6 of 9 (1786 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: patch | Status: closed
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution: fixed
---------------------+------------------------------------------------------
Comment (by tephra [at] gmail):

Yep, I was just about to post this myself :) looks like the OR should have
been an AND :)

can we push this change the 0.19-fixes please :)

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 24, 2006, 2:51 AM

Post #7 of 9 (1797 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: patch | Status: closed
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution: fixed
---------------------+------------------------------------------------------
Comment (by oscar):

Next problem with this is the title/subtitle/description comparation that
breaks if for example there are no subtitles. "" = "" evaluates as true
thus marking the show as previously recorded..

It needs to behave the same way as myth does, if there's no sub AND desc,
it can't match them.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 27, 2006, 3:20 PM

Post #8 of 9 (1777 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

#1293: Need to check if both seriesid and programid exists
---------------------+------------------------------------------------------
Reporter: oscar | Owner: xris
Type: patch | Status: reopened
Priority: minor | Milestone: 0.20
Component: mythweb | Version: head
Severity: medium | Resolution:
---------------------+------------------------------------------------------
Changes (by anonymous):

* resolution: fixed =>
* status: closed => reopened

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1293>
MythTV <http://www.mythtv.org/>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits [at] mythtv
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

mythtv at cvs

Feb 27, 2006, 8:45 PM

Post #9 of 9 (1787 views)
Permalink

Re: Ticket #1293: Need to check if both seriesid and programid exists [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads