stevehay at apache
Jul 18, 2013, 9:40 AM
Post #1 of 1
(62 views)
Permalink
|
|
svn commit: r1504518 - /perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs
|
|
Author: stevehay
Date: Thu Jul 18 16:40:44 2013
New Revision: 1504518
URL: http://svn.apache.org/r1504518
Log:
There is no need to define a dummy perl_module symbol in ModPerl/Const/Const.xs on Windows
All DLLs except for the APR ones are linked against mod_perl.lib anyway (see ModPerl::BuildMM::WriteMakefile())
so they have the real definition of perl_module already.
Modified:
perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs
Modified: perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs
URL: http://svn.apache.org/viewvc/perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs?rev=1504518&r1=1504517&r2=1504518&view=diff
==============================================================================
--- perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs (original)
+++ perl/modperl/branches/httpd24/xs/ModPerl/Const/Const.xs Thu Jul 18 16:40:44 2013
@@ -17,10 +17,11 @@
#include "mod_perl.h"
#include "modperl_const.h"
-
+#ifndef WIN32
/* FIXME: To define extern perl_module to something so Const.so can be
* loaded later. Without this code, loading Const.so fails with
- * undefined_symbol: perl_module.
+ * undefined_symbol: perl_module. (Windows does not need this since it
+ * explicitly links against mod_perl.lib anyway.)
*/
module AP_MODULE_DECLARE_DATA perl_module = {
STANDARD20_MODULE_STUFF,
@@ -31,7 +32,7 @@ module AP_MODULE_DECLARE_DATA perl_modul
NULL, /* table of config file commands */
NULL, /* register hooks */
};
-
+#endif
MODULE = ModPerl::Const PACKAGE = ModPerl::Const
|
