Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ModPerl: Dev

[patch] Apache::Test #41239: t/TEST -ping does not return a valid return code to the calling shell

 

 

ModPerl dev RSS feed   Index | Next | Previous | View Threaded


fred at redhotpenguin

Apr 20, 2009, 10:41 PM

Post #1 of 2 (905 views)
Permalink
[patch] Apache::Test #41239: t/TEST -ping does not return a valid return code to the calling shell

http://rt.cpan.org/Public/Bug/Display.html?id=41239

This patch as demonstrated in the RT ticket resolves the issue.
Thoughts? Demonstrating documented behavior here on my test setup
(returning 1 return code to the shell).

Index: lib/Apache/TestRun.pm
===================================================================
--- lib/Apache/TestRun.pm (revision 766391)
+++ lib/Apache/TestRun.pm (working copy)
@@ -1173,6 +1173,7 @@
}
else {
warning "no server is running on $name";
+ exit_perl(0);
}

return $exit; #means call exit() if true

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe[at]perl.apache.org
For additional commands, e-mail: dev-help[at]perl.apache.org


adam.prime at utoronto

Apr 21, 2009, 7:53 AM

Post #2 of 2 (839 views)
Permalink
Re: [patch] Apache::Test #41239: t/TEST -ping does not return a valid return code to the calling shell [In reply to]

Fred Moyer wrote:
> http://rt.cpan.org/Public/Bug/Display.html?id=41239
>
> This patch as demonstrated in the RT ticket resolves the issue.
> Thoughts? Demonstrating documented behavior here on my test setup
> (returning 1 return code to the shell).
>

This seems reasonable to me.

Adam

> Index: lib/Apache/TestRun.pm
> ===================================================================
> --- lib/Apache/TestRun.pm (revision 766391)
> +++ lib/Apache/TestRun.pm (working copy)
> @@ -1173,6 +1173,7 @@
> }
> else {
> warning "no server is running on $name";
> + exit_perl(0);
> }
>
> return $exit; #means call exit() if true
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe[at]perl.apache.org
For additional commands, e-mail: dev-help[at]perl.apache.org

ModPerl dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.