Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ModPerl: Dev

PATCH for apache-1.3 when compiled with gcc 4.3

 

 

ModPerl dev RSS feed   Index | Next | Previous | View Threaded


sog at msg

Nov 29, 2008, 2:20 AM

Post #1 of 2 (1549 views)
Permalink
PATCH for apache-1.3 when compiled with gcc 4.3

Hi all,

This afternoon I try to compile my standard bundle (mod_perl 1.30,
apache 1.3.41, libapreq-1.33, mod_ssl-2.8.31) in Fedora 10 that ships
with gcc 4.3.2 only to discover that the change announced in
<http://www.gnu.org/software/gcc/gcc-4.2/changes.html> broke the
compilation of apache-1.3.41/src/os/unix/os-inline.c when using -std=c99
(default for Fedora's perl)

I known that the problem is apache related, not mod_perl's, but there
are many mod_perl 1.x users out there that can be in trouble.

The attached patch fixes the problem.

Any one have contacts with legacy apache maintainers?

Regards.

Salvador Ortiz.

========= CUT ======
--- src/os/unix/os.h.orig 2008-11-29 00:11:23.000000000 -0600
+++ src/os/unix/os.h 2008-11-29 00:15:15.000000000 -0600
@@ -33,7 +33,12 @@
/* Compiler supports inline, so include the inlineable functions as
* part of the header
*/
+#ifdef __GNUC_STDC_INLINE__
+#define INLINE extern ap_inline __attribute__((gnu_inline))
+#else
#define INLINE extern ap_inline
+#endif
+

INLINE int ap_os_is_path_absolute(const char *file);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


pgollucci at p6m7g8

Nov 29, 2008, 4:54 PM

Post #2 of 2 (1456 views)
Permalink
Re: PATCH for apache-1.3 when compiled with gcc 4.3 [In reply to]

Salvador Ortiz Garcia wrote:
> Hi all,
>
> This afternoon I try to compile my standard bundle (mod_perl 1.30,
> apache 1.3.41, libapreq-1.33, mod_ssl-2.8.31) in Fedora 10 that ships
> with gcc 4.3.2 only to discover that the change announced in
> <http://www.gnu.org/software/gcc/gcc-4.2/changes.html> broke the
> compilation of apache-1.3.41/src/os/unix/os-inline.c when using -std=c99
> (default for Fedora's perl)
I'm not sure which is better, but we could account for this is mod_perl
land. Personally, I wish both 1.x series would go away though.


--
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci [at] p6m7g8)
c:703.336.9354
Consultant - P6M7G8 Inc. - http://p6m7g8.net
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

ModPerl dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.