Mailing List Archive: ModPerl: Dev

[ANNOUNCE] mod_perl-1.28

Index | Next | Previous | View Threaded

gozer at cpan

Jul 2, 2003, 11:16 PM

Post #1 of 8 (1189 views)
Permalink

[ANNOUNCE] mod_perl-1.28

The URL

http://perl.apache.org/dist/mod_perl-1.28.tar.gz

has entered CPAN as

file: $CPAN/authors/id/G/GO/GOZER/mod_perl-1.28.tar.gz
size: 375986 bytes
md5: 889ad726a6d7c2fe03b2b1b93662f515

Changes since 1.27:

Apache::FakeRequest now isa Apache so code that is carefull about
$r and checks that $r->isa('Apache') will not fail [David Wheeler
<david [at] kineticode]

Add Mac OS X support to Apache::SizeLimit [David Wheeler
<david [at] kineticode>]

Add Win32 support to Apache::SizeLimit [Matt Phillips
<mphillips [at] virage> and Mohamed Hendawi <mhendawi [at] virage>]

Change Apache::SizeLimit to not push a cleanup handler if already in
the cleanup handler phase, and adjust docs to show that cleanup
handler is the preferred phase to use [Perrin Harkins
<perrin [at] elem>]

Rename Apache::test to Apache::testold because Apache::test on
case-insensitive systems will collide with Apache::Test which
supercedes Apache::test. So if you want to keep on using Apache::test,
either bundle it with your project (putting it under inc/ or t/ so it
won't be installed) or require mod_perl 1.28 and use Apache::testold
instead. Of course the best route is to port your test suite to use
a much better Apache::Test which work with mod_perl 1.0 and 2.0.
[Philippe M. Chiasson, Stas Bekman]

Tweak mod_perl.h to defined _INCLUDE_APACHE_FIRST only after apache
headers were included [Stas Bekman]

avoid various warnings under src/modules/perl/:
- declare bufsiz to be STRLEN in Apache.xs, and add
STRLEN to Apache/typemap
- add I32 typecast in Constants.xs
- avoid use of unregistered local variables for Win32
in mod_perl.c and perl_config.c
- s/I32/U8/ in mod_perl.h, perl_config.c, and perl_util.c
- declare i and http_code to be STRLEN in perl_util.c
[Stas Bekman, Randy Kobes]

don't use $r variable in Apache::PerlRun::compile(), so the script
won't use use inherited $r by mistake [Stas Bekman]

define PERL_DIRECTIVE_HANDLERS so that ModuleConfig.c gets
generated when building on Win32 within Visual Studio
[John Petrakis <jpetrakis [at] rcn>]

enable PERL_SECTIONS for Win32 [Dirk Maetens <dirk.maetens [at] chello>]

use touch() from ExtUtils::Command, rather than a system touch(),
for the benefit of platforms without touch(). [Randy Kobes
<randy [at] theoryx5>]

can't let the default typemap rule to convert sv into char* in
unescape_url, since it doesn't handle correctly undefs (returns an
unallocated "" string, which then causes a segfault in
ap_unescape_url. use SvPV_force, instead, which does the right
thing. [Stas Bekman]

Make sure to start perl, if it's not running, before processing Perl*
directives, with threaded perl and PERL_STACKED_HANDLERS=0 [Stas
Bekman]

Add Apache::Module to Bundle::Apache [Stas Bekman]

use $Config{'installstyle'} instead of hardcoded 'lib', to handle
Makefile.PL's PREFIX option correctly [Philippe M. Chiasson
<gozer [at] cpan>]

prevent segfaults in mod_perl_mark_where() when a sub can't get
resolved [Gerald Richter <richter [at] ecos>]

Apache::Status: Need to load B::Terse/TerseSize if it wasn't loaded
yet in that child before using it. [Dan Sully
<daniel [at] electricrain>]

document the server_root_relative() method [Stas Bekman
<stas [at] stason>]

eliminate warnings when flushing functions with empty () prototypes in
Apache::PerlRun::flush_namespace [Yair Lenga <yair.lenga [at] citigroup>]

fix Apache::Status to not use :: in filenames, which is not allowed on
certain OSs [DH <crazyinsomniac [at] yahoo>]

various cygwin fixes [Per Einar Ellefsen <per.einar [at] skynet>]

fix to compile with 5.8.0 on win32 [Randy Kobes
<randy [at] theoryx5>]

Document the possible misuses of the Apache::Constant constants
[Per Einar Ellefsen <per.einar [at] skynet>]

Patches since 1.27 can be reviewed here:

http://www.apache.org/~gozer/mp1/1.27-dev/
--
--
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Attachments:

signature.asc (0.18 KB)

steve.hay at uk

Jul 3, 2003, 12:46 AM

Post #2 of 8 (1164 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

Hi Philippe,

Philippe M. Chiasson wrote:

>The URL
>
> http://perl.apache.org/dist/mod_perl-1.28.tar.gz
>
>has entered CPAN
>
I still get the same test failures that I reported before when RC2 was
announced:

modules/request.......FAILED tests 3-8
Failed 6/10 tests, 40.00% okay

Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
libapreq-1.2 (built/installed *after* mod_perl 1.28).

I used to have "All tests successful" under mp-1.27.

(I note that Apache::Reload didn't make it in either; I thought the plan
was to put a backport of the version from mp2 into it?)

Steve

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

randy at theoryx5

Jul 3, 2003, 6:52 AM

Post #3 of 8 (1156 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

On Thu, 3 Jul 2003, Issac Goldstand wrote:

> Dare I hope that Randy managed to commit the patch that lets
> mp-1.28 build on win32 with activestate perl 5.8.0? It was so
> close to working and it's a major platform release, IMHO...
> (Randy: I'm toying with the patch you sent me...)

No, I didn't commit it. The patch shouldn't affect any other
platform, but before committing it it would be good to, first of
all, see if someone can see a better way and/or can see if
there's something wrong in principle with it, and secondly, to
get some further testing of it on other machines and also outside
of the mod_perl tests (which all pass). For example, it would be
interesting to see if the problems Steve finds with the
t/request.t tests on 5.8.0 without LARGE_FILES support are still
there - the mod_perl tests I did were without libapreq, so the
t/request.t (and t/cookie.t) tests were skipped.

--
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

randy at theoryx5

Jul 3, 2003, 10:50 PM

Post #4 of 8 (1143 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

On Thu, 3 Jul 2003, Steve Hay wrote:

> Philippe M. Chiasson wrote:
> >The URL
> > http://perl.apache.org/dist/mod_perl-1.28.tar.gz
> >has entered CPAN
> >
> I still get the same test failures that I reported before when
> RC2 was announced:
>
> modules/request.......FAILED tests 3-8
> Failed 6/10 tests, 40.00% okay
>
> Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
> libapreq-1.2 (built/installed *after* mod_perl 1.28).
>
> I used to have "All tests successful" under mp-1.27.

This may be a problem with libapreq - the mod_perl
t/modules/request.t tests, among other things, the sizes involved
with file uploads. The error log you posted earlier reported a
difference in these sizes for three (text) files, with a binary
(gif) file apparently OK (interestingly, with a patch I posted
earlier to allow Win32 ActivePerl 8xx to be used with mod_perl 1
(with LARGE_FILES support), I get a failure with the gif file,
but not the text files). Anyway, could you see if the following
helps (applied to the libapreq sources)? For me, this allows all
the mod_perl t/modules/request tests to pass.
============================================================
Index: Request/Request.xs
===================================================================
RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
retrieving revision 1.36
diff -u -r1.36 Request.xs
--- Request/Request.xs 25 Jun 2003 07:59:37 -0000 1.36
+++ Request/Request.xs 4 Jul 2003 05:32:59 -0000
@@ -533,7 +533,7 @@
if (fd < 0)
XSRETURN_UNDEF;

- if ( !(RETVAL = PerlIO_fdopen(fd, "r")) )
+ if ( !(RETVAL = PerlIO_fdopen(fd, "rb")) )
XSRETURN_UNDEF;
#else
if ( ( RETVAL = PerlIO_importFILE(fp,0) ) == NULL )
@@ -558,7 +558,7 @@
PerlIO *fp;

fd = PerlLIO_dup(fd);
- if (!(fp = PerlIO_fdopen(fd, "r"))) {
+ if (!(fp = PerlIO_fdopen(fd, "rb"))) {
PerlLIO_close(fd);
croak("fdopen failed!");
}
========================================================
The first "r" -> "rb" change (which affects the mod_perl tests)
is only relevant for Perl > 5.7, which is why this problem didn't
arise on Win32 with Perl-5.6. Also, I think this "r" -> "rb"
doesn't have any effect on Unix, but I haven't tested this.

--
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

steve.hay at uk

Jul 4, 2003, 12:26 AM

Post #5 of 8 (1155 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

Hi Randy,

Randy Kobes wrote:

>On Thu, 3 Jul 2003, Steve Hay wrote:
>
>
>
>>Philippe M. Chiasson wrote:
>>
>>
>>>The URL
>>> http://perl.apache.org/dist/mod_perl-1.28.tar.gz
>>>has entered CPAN
>>>
>>>
>>>
>>I still get the same test failures that I reported before when
>>RC2 was announced:
>>
>>modules/request.......FAILED tests 3-8
>> Failed 6/10 tests, 40.00% okay
>>
>>Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
>>libapreq-1.2 (built/installed *after* mod_perl 1.28).
>>
>>I used to have "All tests successful" under mp-1.27.
>>
>>
>
>This may be a problem with libapreq - the mod_perl
>t/modules/request.t tests, among other things, the sizes involved
>with file uploads. The error log you posted earlier reported a
>difference in these sizes for three (text) files, with a binary
>(gif) file apparently OK (interestingly, with a patch I posted
>earlier to allow Win32 ActivePerl 8xx to be used with mod_perl 1
>(with LARGE_FILES support), I get a failure with the gif file,
>but not the text files). Anyway, could you see if the following
>helps (applied to the libapreq sources)? For me, this allows all
>the mod_perl t/modules/request tests to pass.
>
Yes, this fixes it for me.

All the mod_perl 1.28 tests now pass (and all the libapreq 1.2 tests
still pass as well).

Thanks!

Steve

>============================================================
>Index: Request/Request.xs
>===================================================================
>RCS file: /home/cvs/httpd-apreq/Request/Request.xs,v
>retrieving revision 1.36
>diff -u -r1.36 Request.xs
>--- Request/Request.xs 25 Jun 2003 07:59:37 -0000 1.36
>+++ Request/Request.xs 4 Jul 2003 05:32:59 -0000
>@@ -533,7 +533,7 @@
> if (fd < 0)
> XSRETURN_UNDEF;
>
>- if ( !(RETVAL = PerlIO_fdopen(fd, "r")) )
>+ if ( !(RETVAL = PerlIO_fdopen(fd, "rb")) )
> XSRETURN_UNDEF;
> #else
> if ( ( RETVAL = PerlIO_importFILE(fp,0) ) == NULL )
>@@ -558,7 +558,7 @@
> PerlIO *fp;
>
> fd = PerlLIO_dup(fd);
>- if (!(fp = PerlIO_fdopen(fd, "r"))) {
>+ if (!(fp = PerlIO_fdopen(fd, "rb"))) {
> PerlLIO_close(fd);
> croak("fdopen failed!");
> }
>========================================================
>The first "r" -> "rb" change (which affects the mod_perl tests)
>is only relevant for Perl > 5.7, which is why this problem didn't
>arise on Win32 with Perl-5.6. Also, I think this "r" -> "rb"
>doesn't have any effect on Unix, but I haven't tested this.
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

gozer at cpan

Jul 4, 2003, 5:10 AM

Post #6 of 8 (1167 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

On Thu, 2003-07-03 at 15:46, Steve Hay wrote:
> Hi Philippe,
>
> Philippe M. Chiasson wrote:
>
> >The URL
> >
> > http://perl.apache.org/dist/mod_perl-1.28.tar.gz
> >
> >has entered CPAN
> >
> I still get the same test failures that I reported before when RC2 was
> announced:
>
> modules/request.......FAILED tests 3-8
> Failed 6/10 tests, 40.00% okay
>
> Setup: Windows XP, Perl 5.8.0, Apache 1.3.27, Apache-Test 1.03,
> libapreq-1.2 (built/installed *after* mod_perl 1.28).
>
> I used to have "All tests successful" under mp-1.27.
>
> (I note that Apache::Reload didn't make it in either; I thought the plan
> was to put a backport of the version from mp2 into it?)

After discussing this at length with Stas, we decided it would be
simpler to release 1.28 as-is (since it's been almost a year since the
last release) and quicken the release milestone of 1.29 to include
Apache::Reltoad and a whole bunch of other 'controversial' unresolved
issues.

So, Apache::Reload did not make it, but:

1. it is on CPAN
2. Apache::StatINC is still in
3. mod_perl-1.29 will have Apache::Reload
4. mod_perl-1.29 will be released soon

So, that's what it'll be for now folks !

> Steve
>
>

Attachments:

signature.asc (0.18 KB)

gozer at cpan

Jul 4, 2003, 5:12 AM

Post #7 of 8 (1156 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

On Thu, 2003-07-03 at 21:52, Randy Kobes wrote:
> On Thu, 3 Jul 2003, Issac Goldstand wrote:
>
> > Dare I hope that Randy managed to commit the patch that lets
> > mp-1.28 build on win32 with activestate perl 5.8.0? It was so
> > close to working and it's a major platform release, IMHO...
> > (Randy: I'm toying with the patch you sent me...)
>
> No, I didn't commit it. The patch shouldn't affect any other
> platform, but before committing it it would be good to, first of
> all, see if someone can see a better way and/or can see if
> there's something wrong in principle with it, and secondly, to
> get some further testing of it on other machines and also outside
> of the mod_perl tests (which all pass). For example, it would be
> interesting to see if the problems Steve finds with the
> t/request.t tests on 5.8.0 without LARGE_FILES support are still
> there - the mod_perl tests I did were without libapreq, so the
> t/request.t (and t/cookie.t) tests were skipped.

Absolutely! And Randy, as soon as you are happy with both a patch and
satisfactory test results (in your opinion), I'd say commit++

Gozer out.

Attachments:

signature.asc (0.18 KB)

randy at theoryx5

Jul 5, 2003, 9:32 PM

Post #8 of 8 (1164 views)
Permalink

Re: [ANNOUNCE] mod_perl-1.28 [In reply to]

On Fri, 4 Jul 2003, Philippe M. Chiasson wrote:

> On Thu, 2003-07-03 at 21:52, Randy Kobes wrote:
> > > > On Thu, 3 Jul 2003, Issac Goldstand wrote:
> >
> > > Dare I hope that Randy managed to commit the patch that lets
> > > mp-1.28 build on win32 with activestate perl 5.8.0? It was so
> > > close to working and it's a major platform release, IMHO...
> > > (Randy: I'm toying with the patch you sent me...)

> > No, I didn't commit it.
[ .. ]
> Absolutely! And Randy, as soon as you are happy with both a patch and
> satisfactory test results (in your opinion), I'd say commit++

Thanks ... I've tested running a few mod_perl 1 things now on
ActivePerl 806 with this patch, and it seems OK. This includes
Apache-ASP and HTML-Mason, as well as some XS-based packages like
Embperl, AxKit, libapreq, and Apache-Template that link against
mod_perl. There's a few apparent pecularities, but they may be
particular to my system, specifically trying to coexist with
mod_perl 2. So I'll commit the patch, and we'll see how it fares.

--
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads