Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ModPerl: Dev

Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c

 

 

ModPerl dev RSS feed   Index | Next | Previous | View Threaded


fred at redhotpenguin

Jul 27, 2011, 9:06 PM

Post #1 of 8 (898 views)
Permalink
Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c

I committed the 5.14 compatibility patch today. We have enough
changes for a 1.32 release...


---------- Forwarded message ----------
From: <phred [at] apache>
Date: Wed, Jul 27, 2011 at 12:15 PM
Subject: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes
Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs
src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h
src/modules/perl/perl_config.c
To: modperl-cvs [at] perl


Author: phred
Date: Wed Jul 27 19:15:01 2011
New Revision: 1151596

URL: http://svn.apache.org/viewvc?rev=1151596&view=rev
Log:
RT 64999
perl 5.14 compatibility, GvCV and GvGP lvalue changes in perl core

Reported by: Dave Mitchell
Fixed by: sendwade [at] hotmail
Tested by: Perrin Harkins, Fred Moyer

Modified:
   perl/modperl/branches/1.x/Changes
   perl/modperl/branches/1.x/Symbol/Symbol.xs
   perl/modperl/branches/1.x/src/modules/perl/Constants.xs
   perl/modperl/branches/1.x/src/modules/perl/Log.xs
   perl/modperl/branches/1.x/src/modules/perl/mod_perl.c
   perl/modperl/branches/1.x/src/modules/perl/mod_perl.h
   perl/modperl/branches/1.x/src/modules/perl/perl_config.c

Modified: perl/modperl/branches/1.x/Changes
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/Changes?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/Changes (original)
+++ perl/modperl/branches/1.x/Changes Wed Jul 27 19:15:01 2011
@@ -10,8 +10,11 @@ all changes without author attribution a

 =item 1.32-dev

+RT 64999, perl 5.14 compatibility, GvCV and GvGP lvalue changes in perl core
+[<sendwade [at] hotmail>]
+
 RT 40918, fix issue with sigils in perl binary path
-[Slave Rezic <SREZIC [at] cpan>]
+[Slaven Rezic <SREZIC [at] cpan>]

 Work around a gcc optimization specific bug which
 cuased seg faults on FreeBSD 7.x during mod_perl startup.

Modified: perl/modperl/branches/1.x/Symbol/Symbol.xs
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/Symbol/Symbol.xs?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/Symbol/Symbol.xs (original)
+++ perl/modperl/branches/1.x/Symbol/Symbol.xs Wed Jul 27 19:15:01 2011
@@ -30,7 +30,7 @@ static void undef(SV *ref)
           has_proto = TRUE;

       cv_undef(cv);
-       CvGV(cv) = gv;   /* let user-undef'd sub keep its identity */
+        CvGV_set(cv, gv); /* let user-undef'd sub keep its identity */
        if(has_proto)
            SvPOK_on(cv); /* otherwise we get `Prototype mismatch:' */


Modified: perl/modperl/branches/1.x/src/modules/perl/Constants.xs
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/Constants.xs?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/Constants.xs (original)
+++ perl/modperl/branches/1.x/src/modules/perl/Constants.xs Wed Jul 27
19:15:01 2011
@@ -20,7 +20,7 @@ static void export_cv(SV *pclass, SV *ca
           SvPVX(caller), sub, SvPVX(pclass), sub);
 #endif
    gv = gv_fetchpv(form("%_::%s", caller, sub), TRUE, SVt_PVCV);
-    GvCV(gv) = perl_get_cv(form("%_::%s", pclass, sub), TRUE);
+    GvCV_set(gv, perl_get_cv(form("%_::%s", pclass, sub), TRUE));
    GvIMPORTED_CV_on(gv);
 }


Modified: perl/modperl/branches/1.x/src/modules/perl/Log.xs
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/Log.xs?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/Log.xs (original)
+++ perl/modperl/branches/1.x/src/modules/perl/Log.xs Wed Jul 27 19:15:01 2011
@@ -10,7 +10,7 @@
 static void perl_cv_alias(char *to, char *from)
 {
    GV *gp = gv_fetchpv(to, TRUE, SVt_PVCV);
-    GvCV(gp) = perl_get_cv(from, TRUE);
+    GvCV_set(gp, perl_get_cv(from, TRUE));
 }

 static void ApacheLog(int level, SV *sv, SV *msg)

Modified: perl/modperl/branches/1.x/src/modules/perl/mod_perl.c
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/mod_perl.c?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/mod_perl.c (original)
+++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.c Wed Jul 27
19:15:01 2011
@@ -791,8 +791,8 @@ void perl_startup (server_rec *s, pool *
    /* *CORE::GLOBAL::exit = \&Apache::exit */
    if(gv_stashpv("CORE::GLOBAL", FALSE)) {
       GV *exitgp = gv_fetchpv("CORE::GLOBAL::exit", TRUE, SVt_PVCV);
-       GvCV(exitgp) = perl_get_cv("Apache::exit", TRUE);
-       GvIMPORTED_CV_on(exitgp);
+       GvCV_set(exitgp, perl_get_cv("Apache::exit", TRUE));
+       GvIMPORTED_CV_on(exitgp);
    }

    ENTER_SAFE(s,p);

Modified: perl/modperl/branches/1.x/src/modules/perl/mod_perl.h
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/mod_perl.h?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/mod_perl.h (original)
+++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.h Wed Jul 27
19:15:01 2011
@@ -1026,6 +1026,14 @@ else { \
 #define PERL_HEADER_PARSER_CREATE(s)
 #endif

+#ifndef GvCV_set
+#define GvCV_set(gv, cv) (GvCV(gv) = (cv))
+#endif
+
+#ifndef GvCV_set
+#define CvGV_set(gv, cv) (CvVG(gv) = (cv))
+#endif
+
 typedef struct {
    array_header *PerlPassEnv;
    array_header *PerlRequire;

Modified: perl/modperl/branches/1.x/src/modules/perl/perl_config.c
URL: http://svn.apache.org/viewvc/perl/modperl/branches/1.x/src/modules/perl/perl_config.c?rev=1151596&r1=1151595&r2=1151596&view=diff
==============================================================================
--- perl/modperl/branches/1.x/src/modules/perl/perl_config.c (original)
+++ perl/modperl/branches/1.x/src/modules/perl/perl_config.c Wed Jul
27 19:15:01 2011
@@ -1720,7 +1720,7 @@ void perl_clear_symtab(HV *symtab)
       if((cv = GvCV((GV*)val)) && (GvSTASH((GV*)val) == GvSTASH(CvGV(cv)))) {
            GV *gv = CvGV(cv);
            cv_undef(cv);
-            CvGV(cv) = gv;
+            CvGV_set(cv, gv);
            GvCVGEN(gv) = 1; /* invalidate method cache */
        }
    }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


sog at msg

Jul 28, 2011, 1:42 AM

Post #2 of 8 (862 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

The commited patch has two typos:

On 07/27/2011 02:15 PM, phred [at] apache wrote:
> --- perl/modperl/branches/1.x/src/modules/perl/mod_perl.h (original)
> +++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.h Wed Jul 27
> 19:15:01 2011
> @@ -1026,6 +1026,14 @@ else { \
> #define PERL_HEADER_PARSER_CREATE(s)
> #endif
>
> +#ifndef GvCV_set
> +#define GvCV_set(gv, cv) (GvCV(gv) = (cv))
> +#endif
> +
> +#ifndef GvCV_set
s/GvCV/CvGV/
> +#define CvGV_set(gv, cv) (CvVG(gv) = (cv))
s/VG/GV/
> +#endif
> +
> typedef struct {
> array_header *PerlPassEnv;
> array_header *PerlRequire;

Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on
Jun 28.

Regards.

Salvador Ortiz.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


fred at redhotpenguin

Jul 28, 2011, 9:40 AM

Post #3 of 8 (861 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

On Thu, Jul 28, 2011 at 1:42 AM, Salvador Ortiz Garcia <sog [at] msg> wrote:
>
> The commited patch has two typos:

Thanks for the spot, will correct this today.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


cnpengwei at gmail

Jul 28, 2011, 10:17 PM

Post #4 of 8 (882 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

Hi All,

I am sorry to sent this mail to want to get help from you.

Anyway.... I am install the perl module of DBD::Oracle on one 64 bit RedHat
Vmware,

I have installed the Oracle Instant Client, and can use sql*plus to connect
to remote Database to fetch data.

But when I use cpanp to install DBD::Oracle, it alarms below info:

**********************************************************************
CPAN Terminal> i DBD::Oracle

[MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
[MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
[MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
Installing DBD::Oracle (1.28)
Running [/usr/bin/perl /usr/bin/cpanp-run-perl
/root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL]...
Using DBI 1.616 (for perl 5.008008 on x86_64-linux-thread-multi) installed
in /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/

Configuring DBD::Oracle for perl 5.008008 on linux
(x86_64-linux-thread-multi)

Remember to actually *READ* the README file! Especially if you have any
problems.

Installing on a linux, Ver#2.6
Using Oracle in /home/oracle
Multiple copies of Driver.xst found in:
/usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
/usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/ at
/root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 37
SP2-1503: Unable to initialize Oracle call interface
SP2-0152: ORACLE may not be functioning properly

If sqlplus failed due to a linker/symbol/relocation/library
error or similar problem
then it's likely that you've not configured your environment
correctly.
Specifically, your LD_LIBRARY_PATH environment variable
set to include the directory containing the Oracle libraries.

I'm having trouble finding your Oracle version number... trying harder

WARNING: I could not determine Oracle client version so I'll just
default to version 8.0.0.0. Some features of DBD::Oracle may not work.
Oracle version based logic in Makefile.PL may produce erroneous results.
You can use "perl Makefile.PL -V X.Y.Z" to specify a your client version.

Oracle version 8.0.0.0 (8.0)
DBD::Oracle no longer supports Oracle client versions before 9.2
Try a version before 1.25 for 9 and 1.18 for 8! at
/root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 175.
BEGIN failed--compilation aborted at /usr/bin/cpanp-run-perl line 8.
[ERROR] Could not run '/usr/bin/perl Makefile.PL': Using DBI 1.616 (for perl
5.008008 on x86_64-linux-thread-multi) installed in
/usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/

Configuring DBD::Oracle for perl 5.008008 on linux
(x86_64-linux-thread-multi)

Remember to actually *READ* the README file! Especially if you have any
problems.

Installing on a linux, Ver#2.6
Using Oracle in /home/oracle
Multiple copies of Driver.xst found in:
/usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
/usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/ at
/root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 37
SP2-1503: Unable to initialize Oracle call interface
SP2-0152: ORACLE may not be functioning properly

If sqlplus failed due to a linker/symbol/relocation/library
error or similar problem
then it's likely that you've not configured your environment
correctly.
Specifically, your LD_LIBRARY_PATH environment variable
set to include the directory containing the Oracle libraries.

I'm having trouble finding your Oracle version number... trying harder

WARNING: I could not determine Oracle client version so I'll just
default to version 8.0.0.0. Some features of DBD::Oracle may not work.
Oracle version based logic in Makefile.PL may produce erroneous results.
You can use "perl Makefile.PL -V X.Y.Z" to specify a your client version.

Oracle version 8.0.0.0 (8.0)
DBD::Oracle no longer supports Oracle client versions before 9.2
Try a version before 1.25 for 9 and 1.18 for 8! at
/root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 175.
BEGIN failed--compilation aborted at /usr/bin/cpanp-run-perl line 8.
-- cannot continue

[ERROR] Unable to create a new distribution object for 'DBD::Oracle' --
cannot continue

*** Install log written to:
/root/.cpanplus/install-logs/DBD-Oracle-1.28-1311839802.log

Error installing 'DBD::Oracle'
Problem installing one or more modules
*** You can view the complete error buffer by pressing 'p' ***

CPAN Terminal>

**********************************************************************

2011/7/28 Salvador Ortiz Garcia <sog [at] msg>

>
> The commited patch has two typos:
>
>
> On 07/27/2011 02:15 PM, phred [at] apache wrote:
>
>> --- perl/modperl/branches/1.x/src/**modules/perl/mod_perl.h (original)
>> +++ perl/modperl/branches/1.x/src/**modules/perl/mod_perl.h Wed Jul 27
>> 19:15:01 2011
>> @@ -1026,6 +1026,14 @@ else { \
>> #define PERL_HEADER_PARSER_CREATE(s)
>> #endif
>>
>> +#ifndef GvCV_set
>> +#define GvCV_set(gv, cv) (GvCV(gv) = (cv))
>> +#endif
>> +
>> +#ifndef GvCV_set
>>
> s/GvCV/CvGV/
>
> +#define CvGV_set(gv, cv) (CvVG(gv) = (cv))
>>
> s/VG/GV/
>
> +#endif
>> +
>> typedef struct {
>> array_header *PerlPassEnv;
>> array_header *PerlRequire;
>>
>
> Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on Jun
> 28.
>
> Regards.
>
> Salvador Ortiz.
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe [at] perl**org<dev-unsubscribe [at] perl>
> For additional commands, e-mail: dev-help [at] perl
>
>


fred at redhotpenguin

Jul 28, 2011, 11:17 PM

Post #5 of 8 (861 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

You probably want to contact the DBD::Oracle maintainer, his contact
info is here - https://metacpan.org/module/DBD::Oracle

This list is for mod_perl development issues, so there isn't a lot of
DBD::Oracle expertise here.

On Thu, Jul 28, 2011 at 10:17 PM, peng wei <cnpengwei [at] gmail> wrote:
> Hi All,
> I am sorry to sent this mail to want to get help from you.
> Anyway.... I am install the perl module of DBD::Oracle on one 64 bit RedHat
> Vmware,
> I have installed the Oracle Instant Client, and can use sql*plus to connect
> to remote Database to fetch data.
> But when I use cpanp to install DBD::Oracle, it alarms below info:
> **********************************************************************
>    CPAN Terminal> i DBD::Oracle
>
> [MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
> [MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
> [MSG] No '/root/.cpanplus/custom-sources' dir, skipping custom sources
> Installing DBD::Oracle (1.28)
> Running [/usr/bin/perl /usr/bin/cpanp-run-perl
> /root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL]...
> Using DBI 1.616 (for perl 5.008008 on x86_64-linux-thread-multi) installed
> in /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
>
> Configuring DBD::Oracle for perl 5.008008 on linux
> (x86_64-linux-thread-multi)
>
> Remember to actually *READ* the README file! Especially if you have any
> problems.
>
> Installing on a linux, Ver#2.6
> Using Oracle in /home/oracle
> Multiple copies of Driver.xst found in:
> /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
> /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/ at
> /root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 37
> SP2-1503: Unable to initialize Oracle call interface
> SP2-0152: ORACLE may not be functioning properly
>
>             If sqlplus failed due to a linker/symbol/relocation/library
> error or similar problem
>             then it's likely that you've not configured your environment
> correctly.
>             Specifically, your LD_LIBRARY_PATH environment variable
>             set to include the directory containing the Oracle libraries.
>
> I'm having trouble finding your Oracle version number... trying harder
>
> WARNING: I could not determine Oracle client version so I'll just
> default to version 8.0.0.0. Some features of DBD::Oracle may not work.
> Oracle version based logic in Makefile.PL may produce erroneous results.
> You can use "perl Makefile.PL -V X.Y.Z" to specify a your client version.
>
> Oracle version 8.0.0.0 (8.0)
> DBD::Oracle no longer supports Oracle client versions before 9.2
> Try a version before 1.25 for 9 and 1.18 for 8! at
> /root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 175.
> BEGIN failed--compilation aborted at /usr/bin/cpanp-run-perl line 8.
> [ERROR] Could not run '/usr/bin/perl Makefile.PL': Using DBI 1.616 (for perl
> 5.008008 on x86_64-linux-thread-multi) installed in
> /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
>
> Configuring DBD::Oracle for perl 5.008008 on linux
> (x86_64-linux-thread-multi)
>
> Remember to actually *READ* the README file! Especially if you have any
> problems.
>
> Installing on a linux, Ver#2.6
> Using Oracle in /home/oracle
> Multiple copies of Driver.xst found in:
> /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/
> /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux-thread-multi/auto/DBI/ at
> /root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 37
> SP2-1503: Unable to initialize Oracle call interface
> SP2-0152: ORACLE may not be functioning properly
>
>             If sqlplus failed due to a linker/symbol/relocation/library
> error or similar problem
>             then it's likely that you've not configured your environment
> correctly.
>             Specifically, your LD_LIBRARY_PATH environment variable
>             set to include the directory containing the Oracle libraries.
>
> I'm having trouble finding your Oracle version number... trying harder
>
> WARNING: I could not determine Oracle client version so I'll just
> default to version 8.0.0.0. Some features of DBD::Oracle may not work.
> Oracle version based logic in Makefile.PL may produce erroneous results.
> You can use "perl Makefile.PL -V X.Y.Z" to specify a your client version.
>
> Oracle version 8.0.0.0 (8.0)
> DBD::Oracle no longer supports Oracle client versions before 9.2
> Try a version before 1.25 for 9 and 1.18 for 8! at
> /root/.cpanplus/5.8.8/build/DBD-Oracle-1.28/Makefile.PL line 175.
> BEGIN failed--compilation aborted at /usr/bin/cpanp-run-perl line 8.
> -- cannot continue
>
> [ERROR] Unable to create a new distribution object for 'DBD::Oracle' --
> cannot continue
>
> *** Install log written to:
>   /root/.cpanplus/install-logs/DBD-Oracle-1.28-1311839802.log
>
> Error installing 'DBD::Oracle'
> Problem installing one or more modules
> *** You can view the complete error buffer by pressing 'p' ***
>
> CPAN Terminal>
> **********************************************************************
>
> 2011/7/28 Salvador Ortiz Garcia <sog [at] msg>
>>
>> The commited patch has two typos:
>>
>> On 07/27/2011 02:15 PM, phred [at] apache wrote:
>>>
>>> --- perl/modperl/branches/1.x/src/modules/perl/mod_perl.h (original)
>>> +++ perl/modperl/branches/1.x/src/modules/perl/mod_perl.h Wed Jul 27
>>> 19:15:01 2011
>>> @@ -1026,6 +1026,14 @@ else { \
>>>  #define PERL_HEADER_PARSER_CREATE(s)
>>>  #endif
>>>
>>> +#ifndef GvCV_set
>>> +#define GvCV_set(gv, cv) (GvCV(gv) = (cv))
>>> +#endif
>>> +
>>> +#ifndef GvCV_set
>>
>> s/GvCV/CvGV/
>>>
>>> +#define CvGV_set(gv, cv) (CvVG(gv) = (cv))
>>
>> s/VG/GV/
>>>
>>> +#endif
>>> +
>>>  typedef struct {
>>>     array_header *PerlPassEnv;
>>>     array_header *PerlRequire;
>>
>> Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on
>> Jun 28.
>>
>> Regards.
>>
>> Salvador Ortiz.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe [at] perl
>> For additional commands, e-mail: dev-help [at] perl
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


fred at redhotpenguin

Jul 30, 2011, 10:28 PM

Post #6 of 8 (849 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

On Thu, Jul 28, 2011 at 1:42 AM, Salvador Ortiz Garcia <sog [at] msg> wrote:
>
> The commited patch has two typos:

Thanks again for the review, fixes applied r1152547. All tests
successful with 5.14.1.

> Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on Jun
> 28.

Do you have a link to that email? I looked on gossamer-threads but
didn't have enough time to track it down.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


sog at msg

Jul 31, 2011, 10:57 PM

Post #7 of 8 (845 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

On 07/31/2011 12:28 AM, Fred Moyer wrote:
> On Thu, Jul 28, 2011 at 1:42 AM, Salvador Ortiz Garcia<sog [at] msg> wrote:
>> The commited patch has two typos:
> Thanks again for the review, fixes applied r1152547. All tests
> successful with 5.14.1.
>
Thanks to you.
>> Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on Jun
>> 28.
> Do you have a link to that email? I looked on gossamer-threads but
> didn't have enough time to track it down.
Sure: http://www.gossamer-threads.com/lists/modperl/modperl/103205#103205

BTW, after a new review I think that Wade's patch isn't complete:
"Symbol.xs" do not include "mod_perl.h" so it needs its own macro
definition.

Can you take a look, please?

Thanks.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl


fred at redhotpenguin

Aug 12, 2011, 10:24 PM

Post #8 of 8 (786 views)
Permalink
Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c [In reply to]

On Sun, Jul 31, 2011 at 10:57 PM, Salvador Ortiz Garcia <sog [at] msg> wrote:
>> Do you have a link to that email?  I looked on gossamer-threads but
>> didn't have enough time to track it down.
>
> Sure: http://www.gossamer-threads.com/lists/modperl/modperl/103205#103205
>
> BTW, after a new review I think that Wade's patch isn't complete:
> "Symbol.xs" do not include "mod_perl.h" so it needs its own macro
> definition.
>
> Can you take a look, please?

Thanks, I added the macro to Symbol.xs, and changed the argument
layout in mod_perl.h to match your patch. The order of variables made
more intuitive sense.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe [at] perl
For additional commands, e-mail: dev-help [at] perl

ModPerl dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.