Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Lucene: Java-Dev

[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

 

 

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded


jira at apache

Nov 23, 2009, 2:35 PM

Post #1 of 5 (209 views)
Permalink
[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled

[ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781679#action_12781679 ]

Michael McCandless commented on LUCENE-2092:
--------------------------------------------

This is quite nasty. Uwe, should we re-spin 3.0 for it? Or for 3.0.1?

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
> Key: LUCENE-2092
> URL: https://issues.apache.org/jira/browse/LUCENE-2092
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
> Reporter: Hoss Man
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


jira at apache

Nov 23, 2009, 4:08 PM

Post #2 of 5 (195 views)
Permalink
[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781706#action_12781706 ]

Michael McCandless commented on LUCENE-2092:
--------------------------------------------

Fixed on trunk... I'll backport to 3.0 once Uwe opens it up...

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
> Key: LUCENE-2092
> URL: https://issues.apache.org/jira/browse/LUCENE-2092
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
> Reporter: Hoss Man
> Assignee: Michael McCandless
> Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


jira at apache

Nov 23, 2009, 4:32 PM

Post #3 of 5 (194 views)
Permalink
[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781716#action_12781716 ]

Erick Erickson commented on LUCENE-2092:
----------------------------------------

Well, if it's been there since 1.9 and this is the first time it's been reported, it hasn't caused the world to stop yet. So I don't think it's worth the work unless we have to spin another 3.0 for additional reasons.

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
> Key: LUCENE-2092
> URL: https://issues.apache.org/jira/browse/LUCENE-2092
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
> Reporter: Hoss Man
> Assignee: Michael McCandless
> Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


dmsmith555 at gmail

Nov 23, 2009, 4:45 PM

Post #4 of 5 (192 views)
Permalink
Re: [jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled [In reply to]

Since this is a bug fix, please mark it for 2.9.2 if there ever is one.

On Nov 23, 2009, at 7:08 PM, Michael McCandless (JIRA) wrote:

>
> [ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781706#action_12781706 ]
>
> Michael McCandless commented on LUCENE-2092:
> --------------------------------------------
>
> Fixed on trunk... I'll backport to 3.0 once Uwe opens it up...
>
>> BooleanQuery.hashCode and equals ignore isCoordDisabled
>> -------------------------------------------------------
>>
>> Key: LUCENE-2092
>> URL: https://issues.apache.org/jira/browse/LUCENE-2092
>> Project: Lucene - Java
>> Issue Type: Bug
>> Components: Query/Scoring
>> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
>> Reporter: Hoss Man
>> Assignee: Michael McCandless
>> Attachments: LUCENE-2092.patch
>>
>>
>> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
>> bug traces back to at least 1.9
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
> For additional commands, e-mail: java-dev-help [at] lucene
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


jira at apache

Nov 23, 2009, 11:14 PM

Post #5 of 5 (184 views)
Permalink
[jira] Commented: (LUCENE-2092) BooleanQuery.hashCode and equals ignore isCoordDisabled [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781804#action_12781804 ]

Uwe Schindler commented on LUCENE-2092:
---------------------------------------

bq. Well, if it's been there since 1.9 and this is the first time it's been reported, it hasn't caused the world to stop yet. So I don't think it's worth the work unless we have to spin another 3.0 for additional reasons.

+1

But you can commit to *3.0* branch and also *2.9* branch. I did'nt want to have commits in 3.0, because if I respin a release, I would not be able to only take *some* of the fixes into 3.0.0. That was the reason.

For now i marked this issue as fix for 3.1, 3.0.1, 2.9.2

> BooleanQuery.hashCode and equals ignore isCoordDisabled
> -------------------------------------------------------
>
> Key: LUCENE-2092
> URL: https://issues.apache.org/jira/browse/LUCENE-2092
> Project: Lucene - Java
> Issue Type: Bug
> Components: Query/Scoring
> Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4, 2.4.1, 2.9, 2.9.1
> Reporter: Hoss Man
> Assignee: Michael McCandless
> Fix For: 2.9.2, 3.0.1, 3.1
>
> Attachments: LUCENE-2092.patch
>
>
> BooleanQuery.isCoordDisabled() is not considered by BooleanQuery's hashCode() or equals() methods ... this can cause serious badness to happen when caching BooleanQueries.
> bug traces back to at least 1.9

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.