Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Lucene: Java-Dev

[jira] Updated: (LUCENE-2052) Scan method signatures and add varargs where possible

 

 

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded


jira at apache

Nov 13, 2009, 3:31 PM

Post #1 of 3 (244 views)
Permalink
[jira] Updated: (LUCENE-2052) Scan method signatures and add varargs where possible

[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2052:
----------------------------------

Attachment: LUCENE-2052.patch

Here a patch that adds more varargs where it makes sense (e.g. MultiSearcher ctor to pass Searchables, adding more than one sub query, merge boolean queries and so on - everywhere, where the array is not the meaning but more a unlimited list of parameters).

If somebody finds something in addition, speak load!

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


jira at apache

Nov 13, 2009, 3:49 PM

Post #2 of 3 (233 views)
Permalink
[jira] Updated: (LUCENE-2052) Scan method signatures and add varargs where possible [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-2052:
----------------------------------

Attachment: LUCENE-2052.patch

Updated patch, as there may be a backwards comp problem (but only if you recompile!) if you try to override a varargs method with an array param (which is not possible). Removed the varargs from docFreq(Term[]) because of that again.

Also added changes.txt.

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene


jira at apache

Nov 13, 2009, 8:48 PM

Post #3 of 3 (218 views)
Permalink
[jira] Updated: (LUCENE-2052) Scan method signatures and add varargs where possible [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-2052:
--------------------------------

Attachment: LUCENE-2052_fa.patch

uwe, here is one i found that got skipped in LUCENE-1987

> Scan method signatures and add varargs where possible
> -----------------------------------------------------
>
> Key: LUCENE-2052
> URL: https://issues.apache.org/jira/browse/LUCENE-2052
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2052.patch, LUCENE-2052.patch, LUCENE-2052_fa.patch
>
>
> I changed a lot of signatures, but there may be more. The important ones like MultiReader and MultiSearcher are already done. This applies also to contrib. Varargs are no backwards break, they stay arrays as before.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.