jira at apache
Nov 6, 2009, 2:28 PM
Post #3 of 5
(279 views)
Permalink
|
|
[jira] Updated: (LUCENE-2030) CachingSpanFilter synchronizing on a none final protected object
[In reply to]
|
|
[ https://issues.apache.org/jira/browse/LUCENE-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2030:
----------------------------------
Attachment: LUCENE-2030.patch
New patch. The previous one had the problem, that it also blocked during creating the Filter/SpanResult. Now it only locks correctly before creating the WeakHashMap at all and when requesting/putting entries. The only problem is, that two threads may create the same DocIdSet at the same time because of cache miss, but that is not a problem at all for correct behaviour.
> CachingSpanFilter synchronizing on a none final protected object
> ----------------------------------------------------------------
>
> Key: LUCENE-2030
> URL: https://issues.apache.org/jira/browse/LUCENE-2030
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.9
> Reporter: Simon Willnauer
> Assignee: Uwe Schindler
> Priority: Minor
> Fix For: 3.1
>
> Attachments: LUCENE-2030.patch, LUCENE-2030.patch, LUCENE-2030.patch
>
>
> CachingSpanFilter and CachingWrapperFilter expose their internal cache via a protected member which is lazily instantiated in the getDocSetId method. The current code yields the chance to double instantiate the cache and internally synchronizes on a protected none final member. My first guess is that this member was exposed for testing purposes so it should rather be changed to package private.
> This patch breaks backwards compat while I guess the cleanup is kind of worth breaking it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene
|
