jira at apache
Nov 4, 2009, 6:52 PM
Post #2 of 2
(143 views)
Permalink
|
|
[jira] Issue Comment Edited: (LUCENE-2012) Add @Override annotations
[In reply to]
|
|
[ https://issues.apache.org/jira/browse/LUCENE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773740#action_12773740 ]
Uwe Schindler edited comment on LUCENE-2012 at 11/5/09 2:50 AM:
----------------------------------------------------------------
test for the patches, it also fixes whitespace where broken. *EDIT* other way round: patch for the tests
Will commit now.
was (Author: thetaphi):
test for the patches, it also fixes whitespace where broken.
Will commit now.
> Add @Override annotations
> -------------------------
>
> Key: LUCENE-2012
> URL: https://issues.apache.org/jira/browse/LUCENE-2012
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-2012-tests.patch, LUCENE-2012.patch
>
>
> During removal of deprecated APIs, mostly the problem was, to not only remove the method in the (abstract) base class (e.g. Scorer.explain()), but also remove it in sub classes that override it. You can easily forget that (especially, if the method was not marked deprecated in the subclass). By adding @Override annotations everywhere in Lucene, such removals are simple, because the compiler throws out an error message in all subclasses which then no longer override the method.
> Also it helps preventing the well-known traps like overriding hashcode() instead of hashCode().
> The patch was generated automatically, and is rather large. Should I apply it, or would it break too many patches (but I think, trunk has changed so much, that this is only a minimum of additional work to merge)?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe [at] lucene
For additional commands, e-mail: java-dev-help [at] lucene
|
