Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Lucene: Java-Dev

[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery

 

 

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded


jira at apache

Jun 30, 2009, 1:06 AM

Post #1 of 7 (321 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Summary: Rename RangeQuery -> TermRangeQuery (was: Rename RangeQuery -> TextRangeQuery)

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Fix For: 2.9
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 2, 2009, 8:03 AM

Post #2 of 7 (287 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: RangeFilter.java
RangeQuery.java
LUCENE-1713.patch

Here the patch for reference. The deprecated old classes are attached as separate files for a second commit step. Please note, that it will not apply to your checkout, because it needs a SVN rename of RangeQuery, RangeFilter and RangeTermEnum to Term*.

This patch also converts all tests and contrib to use the new classes and non-deprecated ctors. In TermRange* all deprecated methods are removed and only stay alive in the old classes. The new TermRangeQuery use constant score mode per default (as planned for 3.0), but the old deprecated classes use boolean rewrite per default. I will edit the tests after this commit, to also test boolean rewrite (because of the new defaults, only constant score rewrite ist tested)

I will commit this soon (approx 2 hours) in two steps (first the patch, then svn add of the new deprecated classes) to not prevent people from doing things.

All tests, especially bw-tests pass.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713.patch, RangeFilter.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 2, 2009, 8:15 AM

Post #3 of 7 (287 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: LUCENE-1713.patch

correct patch.

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713.patch, RangeFilter.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 2, 2009, 8:15 AM

Post #4 of 7 (286 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: (was: LUCENE-1713.patch)

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713.patch, RangeFilter.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 2, 2009, 3:41 PM

Post #5 of 7 (280 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: RangeFilter.java

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713-backwards-branch.patch, LUCENE-1713.patch, LUCENE-1713.patch, RangeFilter.java, RangeFilter.java, RangeQuery.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 2, 2009, 3:41 PM

Post #6 of 7 (280 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: RangeQuery.java
LUCENE-1713-backwards-branch.patch
LUCENE-1713.patch

New patch for reference (before all Range* must be svn renamed to TermRange*):
- Restores original API of RangeQuery and RangeFilter (the backards-tag must be changed to use the original 2.4 tests, see java-dev-mail from me regarding this)
- RangeQuery is a deprecated dummy class deleagting everything to TermRangeQuery, but is not a subclass, because different semantics of ctors and some getter methods.
- new classes use cleaner API (no such strange methods like getLowerTermText() because of overriding)

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713-backwards-branch.patch, LUCENE-1713.patch, LUCENE-1713.patch, RangeFilter.java, RangeFilter.java, RangeQuery.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org


jira at apache

Jul 4, 2009, 1:17 PM

Post #7 of 7 (233 views)
Permalink
[jira] Updated: (LUCENE-1713) Rename RangeQuery -> TermRangeQuery [In reply to]

[ https://issues.apache.org/jira/browse/LUCENE-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-1713:
----------------------------------

Attachment: LUCENE-1713.patch

Last update.

The patch also contains regenerated QueryParser classes (see LUCENE-1646).

> Rename RangeQuery -> TermRangeQuery
> -----------------------------------
>
> Key: LUCENE-1713
> URL: https://issues.apache.org/jira/browse/LUCENE-1713
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1713-backwards-branch.patch, LUCENE-1713.patch, LUCENE-1713.patch, LUCENE-1713.patch, RangeFilter.java, RangeFilter.java, RangeQuery.java, RangeQuery.java
>
>
> Since we now have NumericRangeQuery (LUCENE-1701) we should rename RangeQuery to TextRangeQuery to make it clear that TextRangeQuery (TermRangeQuery? StringRangeQuery) is based entirely on text comparison.
> And, existing users on upgrading to 2.9 and using RangeQuery for [slow] numeric searching would realize they now have a good option for numeric range searching.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe[at]lucene.apache.org
For additional commands, e-mail: java-dev-help[at]lucene.apache.org

Lucene java-dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.